diff mbox series

[4/5] fstests/MAINTAINERS: add some specific reviewers

Message ID 20230404171411.699655-5-zlang@kernel.org (mailing list archive)
State New, archived
Headers show
Series fstests specific MAINTAINERS file | expand

Commit Message

Zorro Lang April 4, 2023, 5:14 p.m. UTC
Some people contribute to someone specific fs testing mostly, record
some of them as Reviewer.

Signed-off-by: Zorro Lang <zlang@kernel.org>
---

If someone doesn't want to be in cc list of related fstests patch, please
reply this email, I'll remove that reviewer line.

Or if someone else (who contribute to fstests very much) would like to a
specific reviewer, nominate yourself to get a review.

Thanks,
Zorro

 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Darrick J. Wong April 4, 2023, 11:23 p.m. UTC | #1
On Wed, Apr 05, 2023 at 01:14:10AM +0800, Zorro Lang wrote:
> Some people contribute to someone specific fs testing mostly, record
> some of them as Reviewer.
> 
> Signed-off-by: Zorro Lang <zlang@kernel.org>
> ---
> 
> If someone doesn't want to be in cc list of related fstests patch, please
> reply this email, I'll remove that reviewer line.
> 
> Or if someone else (who contribute to fstests very much) would like to a
> specific reviewer, nominate yourself to get a review.
> 
> Thanks,
> Zorro
> 
>  MAINTAINERS | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 620368cb..0ad12a38 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -108,6 +108,7 @@ Maintainers List
>  	  or reviewer or co-maintainer can be in cc list.
>  
>  BTRFS
> +R:	Filipe Manana <fdmanana@suse.com>
>  L:	linux-btrfs@vger.kernel.org
>  S:	Supported
>  F:	tests/btrfs/
> @@ -137,16 +138,19 @@ F:	tests/f2fs/
>  F:	common/f2fs
>  
>  FSVERITY
> +R:	Eric Biggers <ebiggers@google.com>
>  L:	fsverity@lists.linux.dev
>  S:	Supported
>  F:	common/verity
>  
>  FSCRYPT
> +R:	Eric Biggers <ebiggers@google.com>
>  L:      linux-fscrypt@vger.kernel.org
>  S:	Supported
>  F:	common/encrypt
>  
>  FS-IDMAPPED
> +R:	Christian Brauner <brauner@kernel.org>
>  L:	linux-fsdevel@vger.kernel.org
>  S:	Supported
>  F:	src/vfs/
> @@ -163,6 +167,7 @@ S:	Supported
>  F:	tests/ocfs2/
>  
>  OVERLAYFS
> +R:	Amir Goldstein <amir73il@gmail.com>
>  L:	linux-unionfs@vger.kernel.org
>  S:	Supported
>  F:	tests/overlay
> @@ -174,6 +179,7 @@ S:	Supported
>  F:	tests/udf/
>  
>  XFS
> +R:	Darrick J. Wong <djwong@kernel.org>

For this one hunk,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

>  L:	linux-xfs@vger.kernel.org
>  S:	Supported
>  F:	common/dump
> -- 
> 2.39.2
>
Amir Goldstein April 5, 2023, 7:29 a.m. UTC | #2
On Tue, Apr 4, 2023 at 8:14 PM Zorro Lang <zlang@kernel.org> wrote:
>
> Some people contribute to someone specific fs testing mostly, record
> some of them as Reviewer.
>
> Signed-off-by: Zorro Lang <zlang@kernel.org>
> ---
>
> If someone doesn't want to be in cc list of related fstests patch, please
> reply this email, I'll remove that reviewer line.
>
> Or if someone else (who contribute to fstests very much) would like to a
> specific reviewer, nominate yourself to get a review.
>
> Thanks,
> Zorro
>
>  MAINTAINERS | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 620368cb..0ad12a38 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -108,6 +108,7 @@ Maintainers List
>           or reviewer or co-maintainer can be in cc list.
>

>
>  OVERLAYFS
> +R:     Amir Goldstein <amir73il@gmail.com>
>  L:     linux-unionfs@vger.kernel.org
>  S:     Supported
>  F:     tests/overlay

For overlayfs
Acked-by: Amir Goldstein <amir73il@gmail.com>
Christian Brauner April 5, 2023, 7:47 a.m. UTC | #3
On Wed, Apr 05, 2023 at 01:14:10AM +0800, Zorro Lang wrote:
> Some people contribute to someone specific fs testing mostly, record
> some of them as Reviewer.
> 
> Signed-off-by: Zorro Lang <zlang@kernel.org>
> ---
> 
> If someone doesn't want to be in cc list of related fstests patch, please
> reply this email, I'll remove that reviewer line.
> 
> Or if someone else (who contribute to fstests very much) would like to a
> specific reviewer, nominate yourself to get a review.
> 
> Thanks,
> Zorro
> 
>  MAINTAINERS | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 620368cb..0ad12a38 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -108,6 +108,7 @@ Maintainers List
>  	  or reviewer or co-maintainer can be in cc list.
>  
>  BTRFS
> +R:	Filipe Manana <fdmanana@suse.com>
>  L:	linux-btrfs@vger.kernel.org
>  S:	Supported
>  F:	tests/btrfs/
> @@ -137,16 +138,19 @@ F:	tests/f2fs/
>  F:	common/f2fs
>  
>  FSVERITY
> +R:	Eric Biggers <ebiggers@google.com>
>  L:	fsverity@lists.linux.dev
>  S:	Supported
>  F:	common/verity
>  
>  FSCRYPT
> +R:	Eric Biggers <ebiggers@google.com>
>  L:      linux-fscrypt@vger.kernel.org
>  S:	Supported
>  F:	common/encrypt
>  
>  FS-IDMAPPED

I'd just make this VFS since src/vfs/ covers generic vfs functionality.

But up to you,

Acked-by: Christian Brauner <brauner@kernel.org>

> +R:	Christian Brauner <brauner@kernel.org>
>  L:	linux-fsdevel@vger.kernel.org
>  S:	Supported
>  F:	src/vfs/
> @@ -163,6 +167,7 @@ S:	Supported
>  F:	tests/ocfs2/
>  
>  OVERLAYFS
> +R:	Amir Goldstein <amir73il@gmail.com>
>  L:	linux-unionfs@vger.kernel.org
>  S:	Supported
>  F:	tests/overlay
> @@ -174,6 +179,7 @@ S:	Supported
>  F:	tests/udf/
>  
>  XFS
> +R:	Darrick J. Wong <djwong@kernel.org>
>  L:	linux-xfs@vger.kernel.org
>  S:	Supported
>  F:	common/dump
> -- 
> 2.39.2
>
Zorro Lang April 6, 2023, 5:02 a.m. UTC | #4
On Wed, Apr 05, 2023 at 09:47:55AM +0200, Christian Brauner wrote:
> On Wed, Apr 05, 2023 at 01:14:10AM +0800, Zorro Lang wrote:
> > Some people contribute to someone specific fs testing mostly, record
> > some of them as Reviewer.
> > 
> > Signed-off-by: Zorro Lang <zlang@kernel.org>
> > ---
> > 
> > If someone doesn't want to be in cc list of related fstests patch, please
> > reply this email, I'll remove that reviewer line.
> > 
> > Or if someone else (who contribute to fstests very much) would like to a
> > specific reviewer, nominate yourself to get a review.
> > 
> > Thanks,
> > Zorro
> > 
> >  MAINTAINERS | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 620368cb..0ad12a38 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -108,6 +108,7 @@ Maintainers List
> >  	  or reviewer or co-maintainer can be in cc list.
> >  
> >  BTRFS
> > +R:	Filipe Manana <fdmanana@suse.com>
> >  L:	linux-btrfs@vger.kernel.org
> >  S:	Supported
> >  F:	tests/btrfs/
> > @@ -137,16 +138,19 @@ F:	tests/f2fs/
> >  F:	common/f2fs
> >  
> >  FSVERITY
> > +R:	Eric Biggers <ebiggers@google.com>
> >  L:	fsverity@lists.linux.dev
> >  S:	Supported
> >  F:	common/verity
> >  
> >  FSCRYPT
> > +R:	Eric Biggers <ebiggers@google.com>
> >  L:      linux-fscrypt@vger.kernel.org
> >  S:	Supported
> >  F:	common/encrypt
> >  
> >  FS-IDMAPPED
> 
> I'd just make this VFS since src/vfs/ covers generic vfs functionality.
> 
> But up to you,

Sure, it can be "VFS". I didn't use "VFS" directly due to vfs is larger, current
src/vfs only tests a small part of it, more tests are under tests/generic directory.
And we don't have many vfs tests, e.g. we don't test new mount API in fstests.

We need a way to sort out "VFS" only files/tests (e.g. group tag), and if we use
"VFS" at here, would you like to be a reviewer of all vfs tests?

Thanks,
Zorro

> 
> Acked-by: Christian Brauner <brauner@kernel.org>
> 
> > +R:	Christian Brauner <brauner@kernel.org>
> >  L:	linux-fsdevel@vger.kernel.org
> >  S:	Supported
> >  F:	src/vfs/
> > @@ -163,6 +167,7 @@ S:	Supported
> >  F:	tests/ocfs2/
> >  
> >  OVERLAYFS
> > +R:	Amir Goldstein <amir73il@gmail.com>
> >  L:	linux-unionfs@vger.kernel.org
> >  S:	Supported
> >  F:	tests/overlay
> > @@ -174,6 +179,7 @@ S:	Supported
> >  F:	tests/udf/
> >  
> >  XFS
> > +R:	Darrick J. Wong <djwong@kernel.org>
> >  L:	linux-xfs@vger.kernel.org
> >  S:	Supported
> >  F:	common/dump
> > -- 
> > 2.39.2
> > 
>
Christian Brauner April 6, 2023, 7:49 a.m. UTC | #5
On Thu, Apr 06, 2023 at 01:02:28PM +0800, Zorro Lang wrote:
> On Wed, Apr 05, 2023 at 09:47:55AM +0200, Christian Brauner wrote:
> > On Wed, Apr 05, 2023 at 01:14:10AM +0800, Zorro Lang wrote:
> > > Some people contribute to someone specific fs testing mostly, record
> > > some of them as Reviewer.
> > > 
> > > Signed-off-by: Zorro Lang <zlang@kernel.org>
> > > ---
> > > 
> > > If someone doesn't want to be in cc list of related fstests patch, please
> > > reply this email, I'll remove that reviewer line.
> > > 
> > > Or if someone else (who contribute to fstests very much) would like to a
> > > specific reviewer, nominate yourself to get a review.
> > > 
> > > Thanks,
> > > Zorro
> > > 
> > >  MAINTAINERS | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 620368cb..0ad12a38 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -108,6 +108,7 @@ Maintainers List
> > >  	  or reviewer or co-maintainer can be in cc list.
> > >  
> > >  BTRFS
> > > +R:	Filipe Manana <fdmanana@suse.com>
> > >  L:	linux-btrfs@vger.kernel.org
> > >  S:	Supported
> > >  F:	tests/btrfs/
> > > @@ -137,16 +138,19 @@ F:	tests/f2fs/
> > >  F:	common/f2fs
> > >  
> > >  FSVERITY
> > > +R:	Eric Biggers <ebiggers@google.com>
> > >  L:	fsverity@lists.linux.dev
> > >  S:	Supported
> > >  F:	common/verity
> > >  
> > >  FSCRYPT
> > > +R:	Eric Biggers <ebiggers@google.com>
> > >  L:      linux-fscrypt@vger.kernel.org
> > >  S:	Supported
> > >  F:	common/encrypt
> > >  
> > >  FS-IDMAPPED
> > 
> > I'd just make this VFS since src/vfs/ covers generic vfs functionality.
> > 
> > But up to you,
> 
> Sure, it can be "VFS". I didn't use "VFS" directly due to vfs is larger, current
> src/vfs only tests a small part of it, more tests are under tests/generic directory.
> And we don't have many vfs tests, e.g. we don't test new mount API in fstests.
> 
> We need a way to sort out "VFS" only files/tests (e.g. group tag), and if we use
> "VFS" at here, would you like to be a reviewer of all vfs tests?

Sure, I can try and help.
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 620368cb..0ad12a38 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -108,6 +108,7 @@  Maintainers List
 	  or reviewer or co-maintainer can be in cc list.
 
 BTRFS
+R:	Filipe Manana <fdmanana@suse.com>
 L:	linux-btrfs@vger.kernel.org
 S:	Supported
 F:	tests/btrfs/
@@ -137,16 +138,19 @@  F:	tests/f2fs/
 F:	common/f2fs
 
 FSVERITY
+R:	Eric Biggers <ebiggers@google.com>
 L:	fsverity@lists.linux.dev
 S:	Supported
 F:	common/verity
 
 FSCRYPT
+R:	Eric Biggers <ebiggers@google.com>
 L:      linux-fscrypt@vger.kernel.org
 S:	Supported
 F:	common/encrypt
 
 FS-IDMAPPED
+R:	Christian Brauner <brauner@kernel.org>
 L:	linux-fsdevel@vger.kernel.org
 S:	Supported
 F:	src/vfs/
@@ -163,6 +167,7 @@  S:	Supported
 F:	tests/ocfs2/
 
 OVERLAYFS
+R:	Amir Goldstein <amir73il@gmail.com>
 L:	linux-unionfs@vger.kernel.org
 S:	Supported
 F:	tests/overlay
@@ -174,6 +179,7 @@  S:	Supported
 F:	tests/udf/
 
 XFS
+R:	Darrick J. Wong <djwong@kernel.org>
 L:	linux-xfs@vger.kernel.org
 S:	Supported
 F:	common/dump