| Message ID | 20230405075223.579461-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] drm/bridge: ti-sn65dsi83: use dev_err_probe if host attach failed | expand |
Hi Alexander, Thank you for the patch. On Wed, Apr 05, 2023 at 09:52:23AM +0200, Alexander Stein wrote: > There might be cases where the host attach is deferred, use dev_err_probe > to add more detailed information to /sys/kernel/debug/devices_deferred. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > index 91ecfbe45bf9..988e537ab884 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > @@ -698,8 +698,10 @@ static int sn65dsi83_probe(struct i2c_client *client) > drm_bridge_add(&ctx->bridge); > > ret = sn65dsi83_host_attach(ctx); > - if (ret) > + if (ret) { > + dev_err_probe(dev, ret, "failed to attach DSI host\n"); > goto err_remove_bridge; > + } > > return 0; >
From: Robert Foss <rfoss@kernel.org> On Wed, 5 Apr 2023 09:52:23 +0200, Alexander Stein wrote: > There might be cases where the host attach is deferred, use dev_err_probe > to add more detailed information to /sys/kernel/debug/devices_deferred. > > Applied, thanks! [1/1] drm/bridge: ti-sn65dsi83: use dev_err_probe if host attach failed https://cgit.freedesktop.org/drm/drm-misc/commit/?id=ce7498acaa88 Rob
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 91ecfbe45bf9..988e537ab884 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c @@ -698,8 +698,10 @@ static int sn65dsi83_probe(struct i2c_client *client) drm_bridge_add(&ctx->bridge); ret = sn65dsi83_host_attach(ctx); - if (ret) + if (ret) { + dev_err_probe(dev, ret, "failed to attach DSI host\n"); goto err_remove_bridge; + } return 0;
There might be cases where the host attach is deferred, use dev_err_probe to add more detailed information to /sys/kernel/debug/devices_deferred. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)