diff mbox series

[isar-cip-core] make script report all potential errors

Message ID 20230405074756.600213-1-srinuvasan_a@mentor.com (mailing list archive)
State Accepted
Headers show
Series [isar-cip-core] make script report all potential errors | expand

Commit Message

Srinuvasan Arjunan April 5, 2023, 7:47 a.m. UTC 
From: Srinuvasan A <srinuvasan_a@mentor.com>

Let us try and make sure that all bits we have are executed as expected.

Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
---
 scripts/generate-sb-db-from-existing-certificate.sh | 3 +++
 scripts/generate_secure_boot_keys.sh                | 3 +++
 scripts/start-efishell.sh                           | 3 +++
 3 files changed, 9 insertions(+)

Comments

Jan Kiszka April 5, 2023, 9:38 a.m. UTC | #1 
On 05.04.23 09:47, Srinuvasan Arjunan wrote:
> From: Srinuvasan A <srinuvasan_a@mentor.com>
> 
> Let us try and make sure that all bits we have are executed as expected.
> 
> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> ---
>  scripts/generate-sb-db-from-existing-certificate.sh | 3 +++
>  scripts/generate_secure_boot_keys.sh                | 3 +++
>  scripts/start-efishell.sh                           | 3 +++
>  3 files changed, 9 insertions(+)
> 
> diff --git a/scripts/generate-sb-db-from-existing-certificate.sh b/scripts/generate-sb-db-from-existing-certificate.sh
> index 035f189..ddaf4c9 100755
> --- a/scripts/generate-sb-db-from-existing-certificate.sh
> +++ b/scripts/generate-sb-db-from-existing-certificate.sh
> @@ -1,4 +1,7 @@
>  #!/bin/sh
> +
> +set -e
> +
>  name=${SB_NAME:-snakeoil}
>  keydir=${SB_KEYDIR:-./keys}
>  if [ ! -d  ${keydir} ]; then
> diff --git a/scripts/generate_secure_boot_keys.sh b/scripts/generate_secure_boot_keys.sh
> index 8d3f8c0..4988a68 100755
> --- a/scripts/generate_secure_boot_keys.sh
> +++ b/scripts/generate_secure_boot_keys.sh
> @@ -1,4 +1,7 @@
>  #!/bin/sh
> +
> +set -e
> +
>  name=${SB_NAME:-demo}
>  keydir=${SB_KEYDIR:-./keys}
>  if [ ! -d  ${keydir} ]; then
> diff --git a/scripts/start-efishell.sh b/scripts/start-efishell.sh
> index 980b9cc..cc8dc58 100755
> --- a/scripts/start-efishell.sh
> +++ b/scripts/start-efishell.sh
> @@ -1,4 +1,7 @@
>  #!/bin/sh
> +
> +set -e
> +
>  ovmf_code=${OVMF_CODE:-/usr/share/OVMF/OVMF_CODE_4M.secboot.fd}
>  ovmf_vars=${OVMF_VARS:-./OVMF_VARS_4M.fd}
>  DISK=$1

Thanks, applied.

Jan
diff mbox series

Patch

diff --git a/scripts/generate-sb-db-from-existing-certificate.sh b/scripts/generate-sb-db-from-existing-certificate.sh
index 035f189..ddaf4c9 100755
--- a/scripts/generate-sb-db-from-existing-certificate.sh
+++ b/scripts/generate-sb-db-from-existing-certificate.sh
@@ -1,4 +1,7 @@ 
 #!/bin/sh
+
+set -e
+
 name=${SB_NAME:-snakeoil}
 keydir=${SB_KEYDIR:-./keys}
 if [ ! -d  ${keydir} ]; then
diff --git a/scripts/generate_secure_boot_keys.sh b/scripts/generate_secure_boot_keys.sh
index 8d3f8c0..4988a68 100755
--- a/scripts/generate_secure_boot_keys.sh
+++ b/scripts/generate_secure_boot_keys.sh
@@ -1,4 +1,7 @@ 
 #!/bin/sh
+
+set -e
+
 name=${SB_NAME:-demo}
 keydir=${SB_KEYDIR:-./keys}
 if [ ! -d  ${keydir} ]; then
diff --git a/scripts/start-efishell.sh b/scripts/start-efishell.sh
index 980b9cc..cc8dc58 100755
--- a/scripts/start-efishell.sh
+++ b/scripts/start-efishell.sh
@@ -1,4 +1,7 @@ 
 #!/bin/sh
+
+set -e
+
 ovmf_code=${OVMF_CODE:-/usr/share/OVMF/OVMF_CODE_4M.secboot.fd}
 ovmf_vars=${OVMF_VARS:-./OVMF_VARS_4M.fd}
 DISK=$1