[0/4] ASoC: qcom: fixes for Click/Pop Noise

Message

Srinivas Kandagatla March 23, 2023, 4:43 p.m. UTC

Click/Pop Noise was a long pending issue with WSA Codecs which are prone
to accumlate DC when ports are active but without any data streams.
There are multiple places in the current setup, where this could happen
in both startup as well as shutdown path.

This patches help fix those issues by making sure the PA is Muted/Unmuted
inline with the stream start/stop events.

Other than this there is a patch to fix DSP graph saturation issue as we never unload
playback graph before loading same graph.

Srinivas Kandagatla (4):
  ASoC: qcom: q6apm-lpass-dai: close graphs before opening a new one
  ASoC: qcom: sdw: do not restart soundwire ports for every prepare
  ASoC: codecs: wsa883x: mute/unmute PA in correct sequence
  ASoC: codecs: wsa881x: mute/unmute PA in correct sequence

 sound/soc/codecs/wsa881x.c              | 30 ++++++++++++++++++++-
 sound/soc/codecs/wsa883x.c              | 36 ++++++++++++++++++++-----
 sound/soc/qcom/qdsp6/q6apm-lpass-dais.c |  3 +++
 sound/soc/qcom/sdw.c                    |  7 ++---
 4 files changed, 63 insertions(+), 13 deletions(-)

Comments

Mark Brown April 6, 2023, 3:03 p.m. UTC | #1

On Thu, 23 Mar 2023 16:43:59 +0000, Srinivas Kandagatla wrote:
> Click/Pop Noise was a long pending issue with WSA Codecs which are prone
> to accumlate DC when ports are active but without any data streams.
> There are multiple places in the current setup, where this could happen
> in both startup as well as shutdown path.
> 
> This patches help fix those issues by making sure the PA is Muted/Unmuted
> inline with the stream start/stop events.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/4] ASoC: qcom: q6apm-lpass-dai: close graphs before opening a new one
      commit: c52615e494f17f44b076ac8ae5a53cfc0041a0dd
[2/4] ASoC: qcom: sdw: do not restart soundwire ports for every prepare
      commit: e2e530886359246ae782c779be248c59bc2ed111

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark