diff mbox series

[6/7] dt-bindings: usb: mtu3: add two optional clocks

Message ID 20230403025230.25035-6-chunfeng.yun@mediatek.com (mailing list archive)
State Superseded
Headers show
Series [1/7] usb: mtu3: give back request when rx error happens | expand

Commit Message

Chunfeng Yun April 3, 2023, 2:52 a.m. UTC 
Add optional clock 'xhci_ck' and 'frmcnt_ck';
Add optional property "assigned-clock" and "assigned-clock-parents";

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 .../devicetree/bindings/usb/mediatek,mtu3.yaml       | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Rob Herring (Arm) April 4, 2023, 1:43 p.m. UTC | #1 
On Mon, Apr 03, 2023 at 10:52:29AM +0800, Chunfeng Yun wrote:
> Add optional clock 'xhci_ck' and 'frmcnt_ck';
> Add optional property "assigned-clock" and "assigned-clock-parents";
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
>  .../devicetree/bindings/usb/mediatek,mtu3.yaml       | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> index d2655173e108..50c15f2ce14d 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> @@ -66,6 +66,8 @@ properties:
>        - description: Reference clock used by low power mode etc
>        - description: Mcu bus clock for register access
>        - description: DMA bus clock for data transfer
> +      - description: DRD controller clock
> +      - description: Frame count clock
>  
>    clock-names:
>      minItems: 1
> @@ -74,6 +76,16 @@ properties:
>        - const: ref_ck
>        - const: mcu_ck
>        - const: dma_ck
> +      - const: xhci_ck
> +      - const: frmcnt_ck
> +
> +  assigned-clocks:
> +    minItems: 1
> +    maxItems: 6
> +
> +  assigned-clock-parents:
> +    minItems: 1
> +    maxItems: 6

You don't need to include assigned-clocks properties. They are 
implicitly allowed (when clocks is present).

Rob
Chunfeng Yun April 7, 2023, 8:03 a.m. UTC | #2 
On Tue, 2023-04-04 at 08:43 -0500, Rob Herring wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Mon, Apr 03, 2023 at 10:52:29AM +0800, Chunfeng Yun wrote:
> > Add optional clock 'xhci_ck' and 'frmcnt_ck';
> > Add optional property "assigned-clock" and "assigned-clock-
> > parents";
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> >  .../devicetree/bindings/usb/mediatek,mtu3.yaml       | 12
> > ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > index d2655173e108..50c15f2ce14d 100644
> > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > @@ -66,6 +66,8 @@ properties:
> >        - description: Reference clock used by low power mode etc
> >        - description: Mcu bus clock for register access
> >        - description: DMA bus clock for data transfer
> > +      - description: DRD controller clock
> > +      - description: Frame count clock
> > 
> >    clock-names:
> >      minItems: 1
> > @@ -74,6 +76,16 @@ properties:
> >        - const: ref_ck
> >        - const: mcu_ck
> >        - const: dma_ck
> > +      - const: xhci_ck
> > +      - const: frmcnt_ck
> > +
> > +  assigned-clocks:
> > +    minItems: 1
> > +    maxItems: 6
> > +
> > +  assigned-clock-parents:
> > +    minItems: 1
> > +    maxItems: 6
> 
> You don't need to include assigned-clocks properties. They are
> implicitly allowed (when clocks is present).
Got it, will modify it, thanks a lot

> 
> Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
index d2655173e108..50c15f2ce14d 100644
--- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
@@ -66,6 +66,8 @@  properties:
       - description: Reference clock used by low power mode etc
       - description: Mcu bus clock for register access
       - description: DMA bus clock for data transfer
+      - description: DRD controller clock
+      - description: Frame count clock
 
   clock-names:
     minItems: 1
@@ -74,6 +76,16 @@  properties:
       - const: ref_ck
       - const: mcu_ck
       - const: dma_ck
+      - const: xhci_ck
+      - const: frmcnt_ck
+
+  assigned-clocks:
+    minItems: 1
+    maxItems: 6
+
+  assigned-clock-parents:
+    minItems: 1
+    maxItems: 6
 
   phys:
     description: