| Message ID | 20230318133952.1684907-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/kmb: remove unused set_test_mode_src_osc_freq_target_low, hi_bits functions | expand |
On Sat, Mar 18, 2023 at 6:39 AM Tom Rix <trix@redhat.com> wrote: > > clang with W=1 reports > drivers/gpu/drm/kmb/kmb_dsi.c:822:2: error: unused function > 'set_test_mode_src_osc_freq_target_low_bits' [-Werror,-Wunused-function] > set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi *kmb_dsi, > ^ > drivers/gpu/drm/kmb/kmb_dsi.c:834:2: error: unused function > 'set_test_mode_src_osc_freq_target_hi_bits' [-Werror,-Wunused-function] > set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi *kmb_dsi, > ^ > These static functions are not used, so remove them. > > Signed-off-by: Tom Rix <trix@redhat.com> Thanks for the patch! Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > drivers/gpu/drm/kmb/kmb_dsi.c | 28 ---------------------------- > 1 file changed, 28 deletions(-) > > diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c b/drivers/gpu/drm/kmb/kmb_dsi.c > index cf7cf0b07541..ed99b14375aa 100644 > --- a/drivers/gpu/drm/kmb/kmb_dsi.c > +++ b/drivers/gpu/drm/kmb/kmb_dsi.c > @@ -818,34 +818,6 @@ static void test_mode_send(struct kmb_dsi *kmb_dsi, u32 dphy_no, > } > } > > -static inline void > - set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi *kmb_dsi, > - u32 dphy_no, > - u32 freq) > -{ > - /* Typical rise/fall time=166, refer Table 1207 databook, > - * sr_osc_freq_target[7:0] > - */ > - test_mode_send(kmb_dsi, dphy_no, TEST_CODE_SLEW_RATE_DDL_CYCLES, > - (freq & 0x7f)); > -} > - > -static inline void > - set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi *kmb_dsi, > - u32 dphy_no, > - u32 freq) > -{ > - u32 data; > - > - /* Flag this as high nibble */ > - data = ((freq >> 6) & 0x1f) | (1 << 7); > - > - /* Typical rise/fall time=166, refer Table 1207 databook, > - * sr_osc_freq_target[11:7] > - */ > - test_mode_send(kmb_dsi, dphy_no, TEST_CODE_SLEW_RATE_DDL_CYCLES, data); > -} > - > static void mipi_tx_get_vco_params(struct vco_params *vco) > { > int i; > -- > 2.27.0 >
diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c b/drivers/gpu/drm/kmb/kmb_dsi.c index cf7cf0b07541..ed99b14375aa 100644 --- a/drivers/gpu/drm/kmb/kmb_dsi.c +++ b/drivers/gpu/drm/kmb/kmb_dsi.c @@ -818,34 +818,6 @@ static void test_mode_send(struct kmb_dsi *kmb_dsi, u32 dphy_no, } } -static inline void - set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi *kmb_dsi, - u32 dphy_no, - u32 freq) -{ - /* Typical rise/fall time=166, refer Table 1207 databook, - * sr_osc_freq_target[7:0] - */ - test_mode_send(kmb_dsi, dphy_no, TEST_CODE_SLEW_RATE_DDL_CYCLES, - (freq & 0x7f)); -} - -static inline void - set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi *kmb_dsi, - u32 dphy_no, - u32 freq) -{ - u32 data; - - /* Flag this as high nibble */ - data = ((freq >> 6) & 0x1f) | (1 << 7); - - /* Typical rise/fall time=166, refer Table 1207 databook, - * sr_osc_freq_target[11:7] - */ - test_mode_send(kmb_dsi, dphy_no, TEST_CODE_SLEW_RATE_DDL_CYCLES, data); -} - static void mipi_tx_get_vco_params(struct vco_params *vco) { int i;
clang with W=1 reports drivers/gpu/drm/kmb/kmb_dsi.c:822:2: error: unused function 'set_test_mode_src_osc_freq_target_low_bits' [-Werror,-Wunused-function] set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi *kmb_dsi, ^ drivers/gpu/drm/kmb/kmb_dsi.c:834:2: error: unused function 'set_test_mode_src_osc_freq_target_hi_bits' [-Werror,-Wunused-function] set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi *kmb_dsi, ^ These static functions are not used, so remove them. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/gpu/drm/kmb/kmb_dsi.c | 28 ---------------------------- 1 file changed, 28 deletions(-)