| Message ID | 20230331164041.1859088-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amd/pm: remove unused num_of_active_display variable | expand |
On Fri, Mar 31, 2023 at 9:40 AM Tom Rix <trix@redhat.com> wrote: > > clang with W=1 reports > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:1700:6: error: variable > 'num_of_active_display' set but not used [-Werror,-Wunused-but-set-variable] > int num_of_active_display = 0; > ^ > This variable is not used so remove it. > > Signed-off-by: Tom Rix <trix@redhat.com> Thanks for the patch! Fixes: commit 75145aab7a0d ("drm/amdgpu/swsmu: clean up a bunch of stale interfaces") Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > index b5d64749990e..f93f7a9ed631 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > @@ -1696,8 +1696,6 @@ static int smu_display_configuration_change(void *handle, > const struct amd_pp_display_configuration *display_config) > { > struct smu_context *smu = handle; > - int index = 0; > - int num_of_active_display = 0; > > if (!smu->pm_enabled || !smu->adev->pm.dpm_enabled) > return -EOPNOTSUPP; > @@ -1708,11 +1706,6 @@ static int smu_display_configuration_change(void *handle, > smu_set_min_dcef_deep_sleep(smu, > display_config->min_dcef_deep_sleep_set_clk / 100); > > - for (index = 0; index < display_config->num_path_including_non_display; index++) { > - if (display_config->displays[index].controller_id != 0) > - num_of_active_display++; > - } > - > return 0; > } > > -- > 2.27.0 >
[AMD Official Use Only - General] Reviewed-by: Evan Quan <evan.quan@amd.com> > -----Original Message----- > From: Tom Rix <trix@redhat.com> > Sent: Saturday, April 1, 2023 12:41 AM > To: Quan, Evan <Evan.Quan@amd.com>; Deucher, Alexander > <Alexander.Deucher@amd.com>; Koenig, Christian > <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; > airlied@gmail.com; daniel@ffwll.ch; nathan@kernel.org; > ndesaulniers@google.com; Zhang, Hawking <Hawking.Zhang@amd.com>; > Feng, Kenneth <Kenneth.Feng@amd.com>; Lazar, Lijo > <Lijo.Lazar@amd.com>; Wang, Yang(Kevin) <KevinYang.Wang@amd.com>; > Huang, Tim <Tim.Huang@amd.com>; andrealmeid@igalia.com; Liu, Kun > <Kun.Liu2@amd.com>; Limonciello, Mario <Mario.Limonciello@amd.com> > Cc: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- > kernel@vger.kernel.org; llvm@lists.linux.dev; Tom Rix <trix@redhat.com> > Subject: [PATCH] drm/amd/pm: remove unused num_of_active_display > variable > > clang with W=1 reports > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:1700:6: error: > variable > 'num_of_active_display' set but not used [-Werror,-Wunused-but-set- > variable] > int num_of_active_display = 0; > ^ > This variable is not used so remove it. > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > index b5d64749990e..f93f7a9ed631 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > @@ -1696,8 +1696,6 @@ static int smu_display_configuration_change(void > *handle, > const struct > amd_pp_display_configuration *display_config) { > struct smu_context *smu = handle; > - int index = 0; > - int num_of_active_display = 0; > > if (!smu->pm_enabled || !smu->adev->pm.dpm_enabled) > return -EOPNOTSUPP; > @@ -1708,11 +1706,6 @@ static int smu_display_configuration_change(void > *handle, > smu_set_min_dcef_deep_sleep(smu, > display_config- > >min_dcef_deep_sleep_set_clk / 100); > > - for (index = 0; index < display_config- > >num_path_including_non_display; index++) { > - if (display_config->displays[index].controller_id != 0) > - num_of_active_display++; > - } > - > return 0; > } > > -- > 2.27.0
Applied. Thanks! On Sun, Apr 9, 2023 at 8:48 PM Quan, Evan <Evan.Quan@amd.com> wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Evan Quan <evan.quan@amd.com> > > > -----Original Message----- > > From: Tom Rix <trix@redhat.com> > > Sent: Saturday, April 1, 2023 12:41 AM > > To: Quan, Evan <Evan.Quan@amd.com>; Deucher, Alexander > > <Alexander.Deucher@amd.com>; Koenig, Christian > > <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; > > airlied@gmail.com; daniel@ffwll.ch; nathan@kernel.org; > > ndesaulniers@google.com; Zhang, Hawking <Hawking.Zhang@amd.com>; > > Feng, Kenneth <Kenneth.Feng@amd.com>; Lazar, Lijo > > <Lijo.Lazar@amd.com>; Wang, Yang(Kevin) <KevinYang.Wang@amd.com>; > > Huang, Tim <Tim.Huang@amd.com>; andrealmeid@igalia.com; Liu, Kun > > <Kun.Liu2@amd.com>; Limonciello, Mario <Mario.Limonciello@amd.com> > > Cc: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- > > kernel@vger.kernel.org; llvm@lists.linux.dev; Tom Rix <trix@redhat.com> > > Subject: [PATCH] drm/amd/pm: remove unused num_of_active_display > > variable > > > > clang with W=1 reports > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:1700:6: error: > > variable > > 'num_of_active_display' set but not used [-Werror,-Wunused-but-set- > > variable] > > int num_of_active_display = 0; > > ^ > > This variable is not used so remove it. > > > > Signed-off-by: Tom Rix <trix@redhat.com> > > --- > > drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > > b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > > index b5d64749990e..f93f7a9ed631 100644 > > --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > > +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > > @@ -1696,8 +1696,6 @@ static int smu_display_configuration_change(void > > *handle, > > const struct > > amd_pp_display_configuration *display_config) { > > struct smu_context *smu = handle; > > - int index = 0; > > - int num_of_active_display = 0; > > > > if (!smu->pm_enabled || !smu->adev->pm.dpm_enabled) > > return -EOPNOTSUPP; > > @@ -1708,11 +1706,6 @@ static int smu_display_configuration_change(void > > *handle, > > smu_set_min_dcef_deep_sleep(smu, > > display_config- > > >min_dcef_deep_sleep_set_clk / 100); > > > > - for (index = 0; index < display_config- > > >num_path_including_non_display; index++) { > > - if (display_config->displays[index].controller_id != 0) > > - num_of_active_display++; > > - } > > - > > return 0; > > } > > > > -- > > 2.27.0
diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c index b5d64749990e..f93f7a9ed631 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c @@ -1696,8 +1696,6 @@ static int smu_display_configuration_change(void *handle, const struct amd_pp_display_configuration *display_config) { struct smu_context *smu = handle; - int index = 0; - int num_of_active_display = 0; if (!smu->pm_enabled || !smu->adev->pm.dpm_enabled) return -EOPNOTSUPP; @@ -1708,11 +1706,6 @@ static int smu_display_configuration_change(void *handle, smu_set_min_dcef_deep_sleep(smu, display_config->min_dcef_deep_sleep_set_clk / 100); - for (index = 0; index < display_config->num_path_including_non_display; index++) { - if (display_config->displays[index].controller_id != 0) - num_of_active_display++; - } - return 0; }
clang with W=1 reports drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:1700:6: error: variable 'num_of_active_display' set but not used [-Werror,-Wunused-but-set-variable] int num_of_active_display = 0; ^ This variable is not used so remove it. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 7 ------- 1 file changed, 7 deletions(-)