| Message ID | 20230407150137.79947-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ufs: hwmon: constify pointers to hwmon_channel_info | expand |
On 4/7/23 08:01, Krzysztof Kozlowski wrote: > -static const struct hwmon_channel_info *ufs_hwmon_info[] = { > +static const struct hwmon_channel_info * const ufs_hwmon_info[] = { > HWMON_CHANNEL_INFO(temp, HWMON_T_ENABLE | HWMON_T_INPUT | HWMON_T_CRIT | HWMON_T_LCRIT), > NULL > }; A nit: to me the use of whitespace in this patch does not seem to be compliant with the Linux kernel coding style. Thanks, Bart.
On 07/04/2023 20:30, Bart Van Assche wrote: > On 4/7/23 08:01, Krzysztof Kozlowski wrote: >> -static const struct hwmon_channel_info *ufs_hwmon_info[] = { >> +static const struct hwmon_channel_info * const ufs_hwmon_info[] = { >> HWMON_CHANNEL_INFO(temp, HWMON_T_ENABLE | HWMON_T_INPUT | HWMON_T_CRIT | HWMON_T_LCRIT), >> NULL >> }; > > A nit: to me the use of whitespace in this patch does not seem to be > compliant with the Linux kernel coding style. You mean it should be: hwmon_channel_info *const ufs_hwmon_info ? I think the pointer * is tied only to variable name, but not to const. Majority seems to choose similarly: git grep "\*const" | wc -l 2763 git grep "\* const" | wc -l 16204 But if this is more than a nit, but your preference, I can fix it. Best regards, Krzysztof
On 4/7/23 08:01, Krzysztof Kozlowski wrote: > Statically allocated array of pointed to hwmon_channel_info can be made > const for safety. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > This depends on hwmon core patch: > https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/ > > Therefore I propose this should also go via hwmon tree. > I am not going to apply patches for 10+ subsystems through the hwmon tree. This can only result in chaos. The dependent patch is available at git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-const or wait until after the next commit window to apply this patch. Thanks, Guenter > Cc: Jean Delvare <jdelvare@suse.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: linux-hwmon@vger.kernel.org > --- > drivers/ufs/core/ufs-hwmon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/core/ufs-hwmon.c b/drivers/ufs/core/ufs-hwmon.c > index 4c6a872b7a7c..229e2ad70903 100644 > --- a/drivers/ufs/core/ufs-hwmon.c > +++ b/drivers/ufs/core/ufs-hwmon.c > @@ -146,7 +146,7 @@ static umode_t ufs_hwmon_is_visible(const void *_data, enum hwmon_sensor_types t > return 0; > } > > -static const struct hwmon_channel_info *ufs_hwmon_info[] = { > +static const struct hwmon_channel_info * const ufs_hwmon_info[] = { > HWMON_CHANNEL_INFO(temp, HWMON_T_ENABLE | HWMON_T_INPUT | HWMON_T_CRIT | HWMON_T_LCRIT), > NULL > };
diff --git a/drivers/ufs/core/ufs-hwmon.c b/drivers/ufs/core/ufs-hwmon.c index 4c6a872b7a7c..229e2ad70903 100644 --- a/drivers/ufs/core/ufs-hwmon.c +++ b/drivers/ufs/core/ufs-hwmon.c @@ -146,7 +146,7 @@ static umode_t ufs_hwmon_is_visible(const void *_data, enum hwmon_sensor_types t return 0; } -static const struct hwmon_channel_info *ufs_hwmon_info[] = { +static const struct hwmon_channel_info * const ufs_hwmon_info[] = { HWMON_CHANNEL_INFO(temp, HWMON_T_ENABLE | HWMON_T_INPUT | HWMON_T_CRIT | HWMON_T_LCRIT), NULL };
Statically allocated array of pointed to hwmon_channel_info can be made const for safety. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- This depends on hwmon core patch: https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/ Therefore I propose this should also go via hwmon tree. Cc: Jean Delvare <jdelvare@suse.com> Cc: Guenter Roeck <linux@roeck-us.net> Cc: linux-hwmon@vger.kernel.org --- drivers/ufs/core/ufs-hwmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)