| Message ID | 20230412112739.160376-6-angelogioacchino.delregno@collabora.com |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | MediaTek Helio X10 - Mailbox, Display, MMC/SD/SDIO | expand |
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > Add a compatible string for MediaTek Helio X10 MT6795, using the same > DSI block as MT8173. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../display/mediatek/mediatek,dsi.yaml | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml > index 4707b60238b0..12441b937684 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml > @@ -22,13 +22,18 @@ allOf: > > properties: > compatible: > - enum: > - - mediatek,mt2701-dsi > - - mediatek,mt7623-dsi > - - mediatek,mt8167-dsi > - - mediatek,mt8173-dsi > - - mediatek,mt8183-dsi > - - mediatek,mt8186-dsi > + oneOf: > + - enum: > + - mediatek,mt2701-dsi > + - mediatek,mt7623-dsi > + - mediatek,mt8167-dsi > + - mediatek,mt8173-dsi > + - mediatek,mt8183-dsi > + - mediatek,mt8186-dsi > + - items: > + - enum: > + - mediatek,mt6795-dsi > + - const: mediatek,mt8173-dsi Same here, why not const? > > reg: > maxItems: 1
Il 12/04/23 14:36, Matthias Brugger ha scritto: > > > On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: >> Add a compatible string for MediaTek Helio X10 MT6795, using the same >> DSI block as MT8173. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> .../display/mediatek/mediatek,dsi.yaml | 19 ++++++++++++------- >> 1 file changed, 12 insertions(+), 7 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml >> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml >> index 4707b60238b0..12441b937684 100644 >> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml >> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml >> @@ -22,13 +22,18 @@ allOf: >> properties: >> compatible: >> - enum: >> - - mediatek,mt2701-dsi >> - - mediatek,mt7623-dsi >> - - mediatek,mt8167-dsi >> - - mediatek,mt8173-dsi >> - - mediatek,mt8183-dsi >> - - mediatek,mt8186-dsi >> + oneOf: >> + - enum: >> + - mediatek,mt2701-dsi >> + - mediatek,mt7623-dsi >> + - mediatek,mt8167-dsi >> + - mediatek,mt8173-dsi >> + - mediatek,mt8183-dsi >> + - mediatek,mt8186-dsi >> + - items: >> + - enum: >> + - mediatek,mt6795-dsi >> + - const: mediatek,mt8173-dsi > > Same here, why not const? > For both DPI and DSI: many other SoCs can work with the same handling as MT8173, that's all the ones from the same era, one example is MT6765, MT6755... as well as MT6752 and 67533 afaik. ...that's why :-) Cheers, Angelo >> reg: >> maxItems: 1
On Wed, 12 Apr 2023 13:27:17 +0200, AngeloGioacchino Del Regno wrote: > Add a compatible string for MediaTek Helio X10 MT6795, using the same > DSI block as MT8173. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../display/mediatek/mediatek,dsi.yaml | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230412112739.160376-6-angelogioacchino.delregno@collabora.com dsi@1400c000: compatible: 'oneOf' conditional failed, one must be fixed: arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb arch/arm/boot/dts/mt7623n-rfb-emmc.dtb dsi@14014000: 'port' is a required property arch/arm64/boot/dts/mediatek/mt8183-evb.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku0.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku1.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb dsi@14014000: Unevaluated properties are not allowed ('ports' was unexpected) arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku0.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku1.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb dsi@1401b000: 'port' is a required property arch/arm64/boot/dts/mediatek/mt8173-elm.dtb arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtb arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dtb dsi@1401b000: Unevaluated properties are not allowed ('ports' was unexpected) arch/arm64/boot/dts/mediatek/mt8173-elm.dtb arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtb arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dtb
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > Add a compatible string for MediaTek Helio X10 MT6795, using the same > DSI block as MT8173. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../display/mediatek/mediatek,dsi.yaml | 19 ++++++++++++------- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml index 4707b60238b0..12441b937684 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml @@ -22,13 +22,18 @@ allOf: properties: compatible: - enum: - - mediatek,mt2701-dsi - - mediatek,mt7623-dsi - - mediatek,mt8167-dsi - - mediatek,mt8173-dsi - - mediatek,mt8183-dsi - - mediatek,mt8186-dsi + oneOf: + - enum: + - mediatek,mt2701-dsi + - mediatek,mt7623-dsi + - mediatek,mt8167-dsi + - mediatek,mt8173-dsi + - mediatek,mt8183-dsi + - mediatek,mt8186-dsi + - items: + - enum: + - mediatek,mt6795-dsi + - const: mediatek,mt8173-dsi reg: maxItems: 1
Add a compatible string for MediaTek Helio X10 MT6795, using the same DSI block as MT8173. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- .../display/mediatek/mediatek,dsi.yaml | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-)