diff mbox series

[v2] selinux: ensure av_permissions.h is built when needed

Message ID 20230412234942.533478-1-paul@paul-moore.com (mailing list archive)
State Accepted
Delegated to: Paul Moore
Headers show
Series [v2] selinux: ensure av_permissions.h is built when needed | expand

Commit Message

Paul Moore April 12, 2023, 11:49 p.m. UTC
The Makefile rule responsible for building flask.h and
av_permissions.h only lists flask.h as a target which means that
av_permissions.h is only generated when flask.h needs to be
generated.  This patch fixes this by adding av_permissions.h as a
target to the rule.

Fixes: 8753f6bec352 ("selinux: generate flask headers during kernel build")
Signed-off-by: Paul Moore <paul@paul-moore.com>

--
v2:
- typo fix in the description
- use grouped target
v1:
- initial release
---
 security/selinux/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul Moore April 13, 2023, 8:26 p.m. UTC | #1
On Wed, Apr 12, 2023 at 7:49 PM Paul Moore <paul@paul-moore.com> wrote:
>
> The Makefile rule responsible for building flask.h and
> av_permissions.h only lists flask.h as a target which means that
> av_permissions.h is only generated when flask.h needs to be
> generated.  This patch fixes this by adding av_permissions.h as a
> target to the rule.
>
> Fixes: 8753f6bec352 ("selinux: generate flask headers during kernel build")
> Signed-off-by: Paul Moore <paul@paul-moore.com>
>
> --
> v2:
> - typo fix in the description
> - use grouped target
> v1:
> - initial release
> ---
>  security/selinux/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Merged into selinux/next.
diff mbox series

Patch

diff --git a/security/selinux/Makefile b/security/selinux/Makefile
index 103c2776478a..0aecf9334ec3 100644
--- a/security/selinux/Makefile
+++ b/security/selinux/Makefile
@@ -26,5 +26,5 @@  quiet_cmd_flask = GEN     $(obj)/flask.h $(obj)/av_permissions.h
       cmd_flask = $< $(obj)/flask.h $(obj)/av_permissions.h
 
 targets += flask.h av_permissions.h
-$(obj)/flask.h: scripts/selinux/genheaders/genheaders FORCE
+$(obj)/flask.h $(obj)/av_permissions.h &: scripts/selinux/genheaders/genheaders FORCE
 	$(call if_changed,flask)