| Message ID | 20230415151722.3188010-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amd/display: set variable dccg314_init storage-class-specifier to static | expand |
On 4/15/23 11:17, Tom Rix wrote: > smatch reports > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_dccg.c:277:6: warning: symbol > 'dccg314_init' was not declared. Should it be static? > > This variable is only used in one file so should be static. > > Signed-off-by: Tom Rix <trix@redhat.com> Applied, thanks! > --- > drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c > index 6f879265ad9c..de7bfba2c179 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c > @@ -274,7 +274,7 @@ static void dccg314_set_dpstreamclk( > } > } > > -void dccg314_init(struct dccg *dccg) > +static void dccg314_init(struct dccg *dccg) > { > int otg_inst; >
diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c index 6f879265ad9c..de7bfba2c179 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c @@ -274,7 +274,7 @@ static void dccg314_set_dpstreamclk( } } -void dccg314_init(struct dccg *dccg) +static void dccg314_init(struct dccg *dccg) { int otg_inst;
smatch reports drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_dccg.c:277:6: warning: symbol 'dccg314_init' was not declared. Should it be static? This variable is only used in one file so should be static. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)