diff mbox series

drm/amd/display: remove unused variable oldest_index

Message ID 20230414150830.3173504-1-trix@redhat.com (mailing list archive)
State New, archived
Headers show
Series drm/amd/display: remove unused variable oldest_index | expand

Commit Message

Tom Rix April 14, 2023, 3:08 p.m. UTC 
cpp_check reports
drivers/gpu/drm/amd/display/modules/freesync/freesync.c:1143:17: style: Variable
  'oldest_index' is assigned a value that is never used. [unreadVariable]
   oldest_index = 0;
                ^

This variable is not used so remove.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Alex Deucher April 17, 2023, 7:28 p.m. UTC | #1 
Applied.  Thanks!

On Fri, Apr 14, 2023 at 11:08 AM Tom Rix <trix@redhat.com> wrote:
>
> cpp_check reports
> drivers/gpu/drm/amd/display/modules/freesync/freesync.c:1143:17: style: Variable
>   'oldest_index' is assigned a value that is never used. [unreadVariable]
>    oldest_index = 0;
>                 ^
>
> This variable is not used so remove.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> index 5c41a4751db4..5798c0eafa1f 100644
> --- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> +++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> @@ -1137,10 +1137,6 @@ void mod_freesync_handle_preflip(struct mod_freesync *mod_freesync,
>
>         if (in_out_vrr->supported &&
>                         in_out_vrr->state == VRR_STATE_ACTIVE_VARIABLE) {
> -               unsigned int oldest_index = plane->time.index + 1;
> -
> -               if (oldest_index >= DC_PLANE_UPDATE_TIMES_MAX)
> -                       oldest_index = 0;
>
>                 last_render_time_in_us = curr_time_stamp_in_us -
>                                 plane->time.prev_update_time_in_us;
> --
> 2.27.0
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
index 5c41a4751db4..5798c0eafa1f 100644
--- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
+++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
@@ -1137,10 +1137,6 @@  void mod_freesync_handle_preflip(struct mod_freesync *mod_freesync,
 
 	if (in_out_vrr->supported &&
 			in_out_vrr->state == VRR_STATE_ACTIVE_VARIABLE) {
-		unsigned int oldest_index = plane->time.index + 1;
-
-		if (oldest_index >= DC_PLANE_UPDATE_TIMES_MAX)
-			oldest_index = 0;
 
 		last_render_time_in_us = curr_time_stamp_in_us -
 				plane->time.prev_update_time_in_us;