| Message ID | 20230414151227.348725-1-johannes@sipsolutions.net (mailing list archive) |
|---|---|
| Headers | show |
| Series | extend drop reasons | expand |
On Fri, 14 Apr 2023 17:12:24 +0200 Johannes Berg wrote: > Here's v3 after the discussions. The first patch is new, to > separate the reasons (needed in a lot of places) from the new > infrastructure (needed only in skbuff.c, drop_monitor and in > mac80211 in the last patch). FWIW: Acked-by: Jakub Kicinski <kuba@kernel.org>
On Fri, 14 Apr 2023 18:22:19 -0700 Jakub Kicinski wrote: > FWIW: > > Acked-by: Jakub Kicinski <kuba@kernel.org> I take that back :) This: > + /** @SKB_DROP_REASON_SUBSYS_MASK: subsystem mask in drop reasons, > + * see &enum skb_drop_reason_subsys > + */ is not valid kdoc, confusingly. If it's longer than one line, the /** has to be on an otherwise empty line. Run the new files thru ./scripts/kernel-doc -none, perhaps.
On Fri, 2023-04-14 at 19:20 -0700, Jakub Kicinski wrote: > On Fri, 14 Apr 2023 18:22:19 -0700 Jakub Kicinski wrote: > > FWIW: > > > > Acked-by: Jakub Kicinski <kuba@kernel.org> > > I take that back :) > > This: > > > + /** @SKB_DROP_REASON_SUBSYS_MASK: subsystem mask in drop reasons, > > + * see &enum skb_drop_reason_subsys > > + */ > > is not valid kdoc, confusingly. > If it's longer than one line, the /** has to be on an otherwise empty line. Meh. > Run the new files thru ./scripts/kernel-doc -none, perhaps. Yeah, I can even run the whole nipa thing, it just seemed obvious enough and our automation isn't quite working yet so it's another manual step... Sorry about that. johannes PS: you're not using the docker container I guess: https://patchwork.hopto.org/static/nipa/739889/13211664/checkpatch/stderr (I fixed that in the dockerfile I think?)