| Message ID | 20230418-dpu-drop-useless-for-lookup-v1-2-b9897ceb6f3e@somainline.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/msm/dpu: Drop useless for-loop HW block lookup | expand |
On 4/17/2023 4:14 PM, Marijn Suijten wrote: > The WB debug log mask ended up never being assigned, leading to writes > to this block to never be logged even if the mask is enabled in > dpu_hw_util_log_mask via sysfs. This should be debugfs not sysfs. > > Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback blocks") > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > --- With that fixed, Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
On 2023-04-18 09:06:34, Abhinav Kumar wrote: > > On 4/17/2023 4:14 PM, Marijn Suijten wrote: > > The WB debug log mask ended up never being assigned, leading to writes > > to this block to never be logged even if the mask is enabled in > > dpu_hw_util_log_mask via sysfs. > > This should be debugfs not sysfs. Good catch! I've queued this up for v2 if it comes to it, otherwise it can perhaps be fixed up while applying for msm-fixes? > > Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback blocks") > > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > > --- > > With that fixed, > > Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> Thanks! - Marijn
On 4/19/2023 2:28 AM, Marijn Suijten wrote: > On 2023-04-18 09:06:34, Abhinav Kumar wrote: >> >> On 4/17/2023 4:14 PM, Marijn Suijten wrote: >>> The WB debug log mask ended up never being assigned, leading to writes >>> to this block to never be logged even if the mask is enabled in >>> dpu_hw_util_log_mask via sysfs. >> >> This should be debugfs not sysfs. > > Good catch! I've queued this up for v2 if it comes to it, otherwise it > can perhaps be fixed up while applying for msm-fixes? > Yes, I can fix it up while applying to -fixes. >>> Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback blocks") >>> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> >>> --- >> >> With that fixed, >> >> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > > Thanks! > > - Marijn
On 18/04/2023 02:14, Marijn Suijten wrote: > The WB debug log mask ended up never being assigned, leading to writes > to this block to never be logged even if the mask is enabled in > dpu_hw_util_log_mask via sysfs. > > Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback blocks") > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 1 + > 1 file changed, 1 insertion(+) With the mentioned commit message changes: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c index db5e6040017f..f33b48045b5c 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c @@ -61,6 +61,7 @@ static const struct dpu_wb_cfg *_wb_offset(enum dpu_wb wb, for (i = 0; i < m->wb_count; i++) { if (wb == m->wb[i].id) { b->blk_addr = addr + m->wb[i].base; + b->log_mask = DPU_DBG_MASK_WB; return &m->wb[i]; } }
The WB debug log mask ended up never being assigned, leading to writes to this block to never be logged even if the mask is enabled in dpu_hw_util_log_mask via sysfs. Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback blocks") Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 1 + 1 file changed, 1 insertion(+)