| Message ID | 20230323-add-opt4001-driver-v2-1-0bae0398669d@axis.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Support for Texas Instruments OPT4001 Ambient Light Sensor | expand |
On 18/04/2023 12:36, Stefan Windfeldt-Prytz wrote: > Add devicetree bindings for opt4001 ambient light sensor. Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). Subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. > > Signed-off-by: Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com> > --- > .../devicetree/bindings/iio/light/ti,opt4001.yaml | 69 ++++++++++++++++++++++ > 1 file changed, 69 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml b/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml > new file mode 100644 > index 000000000000..43fd1a992aea > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/light/ti,opt4001.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments OPT4001 Ambient Light Sensor > + > +maintainers: > + - Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com> > + > +description: | Do not need '|' unless you need to preserve formatting. > + Ambient light sensor with an i2c interface. > + Last part of compatible is for the packaging used. > + Picostar is a 4 pinned SMT and sot-5x3 is a 8 pinned SOT. > + Only sot-5x3 has an interrupt pin. Drop this sentence. It obvious from the schema. > + https://www.ti.com/lit/gpn/opt4001 > + > +properties: > + compatible: > + enum: > + - ti,opt4001-picostar > + - ti,opt4001-sot-5x3 Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml b/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml new file mode 100644 index 000000000000..43fd1a992aea --- /dev/null +++ b/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml @@ -0,0 +1,69 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/light/ti,opt4001.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments OPT4001 Ambient Light Sensor + +maintainers: + - Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com> + +description: | + Ambient light sensor with an i2c interface. + Last part of compatible is for the packaging used. + Picostar is a 4 pinned SMT and sot-5x3 is a 8 pinned SOT. + Only sot-5x3 has an interrupt pin. + https://www.ti.com/lit/gpn/opt4001 + +properties: + compatible: + enum: + - ti,opt4001-picostar + - ti,opt4001-sot-5x3 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + vdd-supply: + description: Regulator that provides power to the sensor + +required: + - compatible + - reg + +allOf: + - if: + properties: + compatible: + contains: + const: ti,opt4001-sot-5x3 + then: + properties: + interrupts: + maxItems: 1 + else: + properties: + interrupts: false + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + light-sensor@44 { + compatible = "ti,opt4001-sot-5x3"; + reg = <0x44>; + vdd-supply = <&vdd_reg>; + interrupt-parent = <&gpio1>; + interrupts = <28 IRQ_TYPE_EDGE_FALLING>; + }; + }; +...
Add devicetree bindings for opt4001 ambient light sensor. Signed-off-by: Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com> --- .../devicetree/bindings/iio/light/ti,opt4001.yaml | 69 ++++++++++++++++++++++ 1 file changed, 69 insertions(+)