| Message ID | 20230418152824.110823-7-nick.hawkins@hpe.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ARM: Add GPIO and PSU Support | expand |
On 18/04/2023 17:28, nick.hawkins@hpe.com wrote: > From: Nick Hawkins <nick.hawkins@hpe.com> > > Provide i2c register information and CPLD register information to the > driver. > > Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com> > --- > .../bindings/hwmon/hpe,gxp-psu.yaml | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml b/Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml > new file mode 100644 > index 000000000000..60ca0f6ace46 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/hpe,gxp-psu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP psu controller > + > +maintainers: > + - Nicholas Hawkins <nick.hawkins@hpe.com> > + > +properties: > + compatible: > + const: hpe,gxp-psu Missing blank line. > + interrupts: > + maxItems: 1 > + > + reg: > + maxItems: 1 All your bindings are written with different style... reg is second in your previous patchset, so what order did you choose here? > + > + hpe,sysreg: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the global status registers shared between each psu > + controller instance. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + Drop blank line. > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + psu@48 { > + compatible = "hpe,gxp-psu"; > + reg = <0x48>; Add also interrupts. Best regards, Krzysztof
On Tue, Apr 18, 2023 at 10:28:21AM -0500, nick.hawkins@hpe.com wrote: > From: Nick Hawkins <nick.hawkins@hpe.com> > > Provide i2c register information and CPLD register information to the > driver. > > Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com> > --- > .../bindings/hwmon/hpe,gxp-psu.yaml | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml b/Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml > new file mode 100644 > index 000000000000..60ca0f6ace46 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/hpe,gxp-psu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP psu controller > + > +maintainers: > + - Nicholas Hawkins <nick.hawkins@hpe.com> > + > +properties: > + compatible: > + const: hpe,gxp-psu > + interrupts: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > + hpe,sysreg: Why is this optional? > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the global status registers shared between each psu > + controller instance. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + psu@48 { > + compatible = "hpe,gxp-psu"; > + reg = <0x48>; > + hpe,sysreg = <&sysreg_system_controller2>; > + }; > + }; > -- > 2.17.1 >
diff --git a/Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml b/Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml new file mode 100644 index 000000000000..60ca0f6ace46 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml @@ -0,0 +1,45 @@ +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/hpe,gxp-psu.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HPE GXP psu controller + +maintainers: + - Nicholas Hawkins <nick.hawkins@hpe.com> + +properties: + compatible: + const: hpe,gxp-psu + interrupts: + maxItems: 1 + + reg: + maxItems: 1 + + hpe,sysreg: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to the global status registers shared between each psu + controller instance. + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + psu@48 { + compatible = "hpe,gxp-psu"; + reg = <0x48>; + hpe,sysreg = <&sysreg_system_controller2>; + }; + };