| Message ID | 20230414104230.23165-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: display: simplify compatibles syntax | expand |
On 14/04/2023 12:42, Krzysztof Kozlowski wrote: > Lists (items) with one item should be just const or enum because it is > shorter and simpler. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Rebased on next-20230406. I hope it applies cleanly... > --- > .../display/bridge/analogix,anx7625.yaml | 3 +-- > .../display/panel/sharp,lq101r1sx01.yaml | 4 ++-- > .../bindings/display/solomon,ssd1307fb.yaml | 24 +++++++++---------- > 3 files changed, 14 insertions(+), 17 deletions(-) > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On Fri, 14 Apr 2023 12:42:30 +0200, Krzysztof Kozlowski wrote: > Lists (items) with one item should be just const or enum because it is > shorter and simpler. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Rebased on next-20230406. I hope it applies cleanly... > --- > .../display/bridge/analogix,anx7625.yaml | 3 +-- > .../display/panel/sharp,lq101r1sx01.yaml | 4 ++-- > .../bindings/display/solomon,ssd1307fb.yaml | 24 +++++++++---------- > 3 files changed, 14 insertions(+), 17 deletions(-) > Applied, thanks!
On 14/04/2023 12:42, Krzysztof Kozlowski wrote: > Lists (items) with one item should be just const or enum because it is > shorter and simpler. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Rebased on next-20230406. I hope it applies cleanly... > --- > .../display/bridge/analogix,anx7625.yaml | 3 +-- > .../display/panel/sharp,lq101r1sx01.yaml | 4 ++-- > .../bindings/display/solomon,ssd1307fb.yaml | 24 +++++++++---------- > 3 files changed, 14 insertions(+), 17 deletions(-) > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Should I apply those patches ? Until now Rob finished by applying them. Neil
On 27/04/2023 13:50, Neil Armstrong wrote: > On 14/04/2023 12:42, Krzysztof Kozlowski wrote: >> Lists (items) with one item should be just const or enum because it is >> shorter and simpler. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> --- >> >> Rebased on next-20230406. I hope it applies cleanly... >> --- >> .../display/bridge/analogix,anx7625.yaml | 3 +-- >> .../display/panel/sharp,lq101r1sx01.yaml | 4 ++-- >> .../bindings/display/solomon,ssd1307fb.yaml | 24 +++++++++---------- >> 3 files changed, 14 insertions(+), 17 deletions(-) >> > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> > > Should I apply those patches ? Until now Rob finished by applying them. Thanks. This and the mediatek display one were applied already by Rob. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml index 7960745a8dbe..a1ed1004651b 100644 --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml @@ -16,8 +16,7 @@ description: | properties: compatible: - items: - - const: analogix,anx7625 + const: analogix,anx7625 reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml b/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml index 9ec0e8aae4c6..57b44a0e763d 100644 --- a/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml @@ -34,8 +34,8 @@ properties: - items: - const: sharp,lq101r1sx03 - const: sharp,lq101r1sx01 - - items: - - const: sharp,lq101r1sx01 + - enum: + - sharp,lq101r1sx01 reg: true power-supply: true diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml index 8bd58913804a..94bb5ef567c6 100644 --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml @@ -14,20 +14,18 @@ properties: compatible: oneOf: # Deprecated compatible strings - - items: - - enum: - - solomon,ssd1305fb-i2c - - solomon,ssd1306fb-i2c - - solomon,ssd1307fb-i2c - - solomon,ssd1309fb-i2c + - enum: + - solomon,ssd1305fb-i2c + - solomon,ssd1306fb-i2c + - solomon,ssd1307fb-i2c + - solomon,ssd1309fb-i2c deprecated: true - - items: - - enum: - - sinowealth,sh1106 - - solomon,ssd1305 - - solomon,ssd1306 - - solomon,ssd1307 - - solomon,ssd1309 + - enum: + - sinowealth,sh1106 + - solomon,ssd1305 + - solomon,ssd1306 + - solomon,ssd1307 + - solomon,ssd1309 reg: maxItems: 1
Lists (items) with one item should be just const or enum because it is shorter and simpler. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Rebased on next-20230406. I hope it applies cleanly... --- .../display/bridge/analogix,anx7625.yaml | 3 +-- .../display/panel/sharp,lq101r1sx01.yaml | 4 ++-- .../bindings/display/solomon,ssd1307fb.yaml | 24 +++++++++---------- 3 files changed, 14 insertions(+), 17 deletions(-)