| Message ID | c167c16a535049d56f817bbede9c9f6f0a0f4c68.1681626553.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 574399f4c997ad71fab95dd875a9ff55424f9a3d |
| Headers | show |
| Series | ASoC: fsl: Simplify an error message | expand |
On 4/16/2023 9:29 AM, Christophe JAILLET wrote: > dev_err_probe() already display the error code. There is no need to > duplicate it explicitly in the error message. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com> Thanks, Iulia > --- > sound/soc/fsl/fsl-asoc-card.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c > index bffa1048d31e..40870668ee24 100644 > --- a/sound/soc/fsl/fsl-asoc-card.c > +++ b/sound/soc/fsl/fsl-asoc-card.c > @@ -858,7 +858,7 @@ static int fsl_asoc_card_probe(struct platform_device *pdev) > > ret = devm_snd_soc_register_card(&pdev->dev, &priv->card); > if (ret) { > - dev_err_probe(&pdev->dev, ret, "snd_soc_register_card failed: %d\n", ret); > + dev_err_probe(&pdev->dev, ret, "snd_soc_register_card failed\n"); > goto asrc_fail; > } >
On Sun, Apr 16, 2023 at 2:29 PM Christophe JAILLET < christophe.jaillet@wanadoo.fr> wrote: > dev_err_probe() already display the error code. There is no need to > duplicate it explicitly in the error message. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com> Best regards wang shengjiu > --- > sound/soc/fsl/fsl-asoc-card.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c > index bffa1048d31e..40870668ee24 100644 > --- a/sound/soc/fsl/fsl-asoc-card.c > +++ b/sound/soc/fsl/fsl-asoc-card.c > @@ -858,7 +858,7 @@ static int fsl_asoc_card_probe(struct platform_device > *pdev) > > ret = devm_snd_soc_register_card(&pdev->dev, &priv->card); > if (ret) { > - dev_err_probe(&pdev->dev, ret, "snd_soc_register_card > failed: %d\n", ret); > + dev_err_probe(&pdev->dev, ret, "snd_soc_register_card > failed\n"); > goto asrc_fail; > } > > -- > 2.34.1 > >
On Sun, 16 Apr 2023 08:29:34 +0200, Christophe JAILLET wrote: > dev_err_probe() already display the error code. There is no need to > duplicate it explicitly in the error message. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl: Simplify an error message commit: 574399f4c997ad71fab95dd875a9ff55424f9a3d All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c index bffa1048d31e..40870668ee24 100644 --- a/sound/soc/fsl/fsl-asoc-card.c +++ b/sound/soc/fsl/fsl-asoc-card.c @@ -858,7 +858,7 @@ static int fsl_asoc_card_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(&pdev->dev, &priv->card); if (ret) { - dev_err_probe(&pdev->dev, ret, "snd_soc_register_card failed: %d\n", ret); + dev_err_probe(&pdev->dev, ret, "snd_soc_register_card failed\n"); goto asrc_fail; }
dev_err_probe() already display the error code. There is no need to duplicate it explicitly in the error message. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- sound/soc/fsl/fsl-asoc-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)