| Message ID | 1681971690-28858-1-git-send-email-quic_sarannya@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | rpmsg signaling/flowcontrol patches | expand |
Hello Sarannya, On 4/20/23 08:21, Sarannya S wrote: > Added new IOCTLS- RPMSG_GET_OUTGOING_FLOWCONTROL and RPMSG_SET_INCOMING_FLOWCONTROL > to get/set the rpmsg char device's flow control signal. > Updated the cmd name 'RPM_CMD_SIGNALS' to 'GLINK_CMD_SIGNALS'. > Changed 'remote_flow' to bool type, and updated it's evaluation. > Updated evaluation of 'set' in rpmsg_char as 'set = !!arg'. > Add destination address of endpoint as parameter in rpmsg_set_flow_control. > Addressed review comments to change variable names/descriptions. > > Chris Lew (2): > rpmsg: glink: Add support to handle signals command > rpmsg: char: Add RPMSG GET/SET FLOWCONTROL IOCTL support > > Deepak Kumar Singh (1): > rpmsg: core: Add signal API support Please increase the version each time you push an update, otherwise it is very difficult to track the update. So this one should be V7 It is also helpful for reviewers and maintainers to include in your cover-letter a summary of the changes from the previous version. Regards, Arnaud > > drivers/rpmsg/qcom_glink_native.c | 64 +++++++++++++++++++++++++++++++++++++++ > drivers/rpmsg/rpmsg_char.c | 49 ++++++++++++++++++++++++++---- > drivers/rpmsg/rpmsg_core.c | 21 +++++++++++++ > drivers/rpmsg/rpmsg_internal.h | 2 ++ > include/linux/rpmsg.h | 15 +++++++++ > include/uapi/linux/rpmsg.h | 11 ++++++- > 6 files changed, 155 insertions(+), 7 deletions(-) >
On 4/20/2023 11:51 AM, Sarannya S wrote: > Added new IOCTLS- RPMSG_GET_OUTGOING_FLOWCONTROL and RPMSG_SET_INCOMING_FLOWCONTROL > to get/set the rpmsg char device's flow control signal. > Updated the cmd name 'RPM_CMD_SIGNALS' to 'GLINK_CMD_SIGNALS'. > Changed 'remote_flow' to bool type, and updated it's evaluation. > Updated evaluation of 'set' in rpmsg_char as 'set = !!arg'. > Add destination address of endpoint as parameter in rpmsg_set_flow_control. > Addressed review comments to change variable names/descriptions. Something to notice, you are not changing the version number as you have sent v6 here again. Also maintain the changes happened from the last patch series properly. Like Changes in v6: - .. - .. Change in v5: (a lore kernel link will be helpful here for reviewer to remind the conversation happened during last review) - .. - .. --Mukesh > > Chris Lew (2): > rpmsg: glink: Add support to handle signals command > rpmsg: char: Add RPMSG GET/SET FLOWCONTROL IOCTL support > > Deepak Kumar Singh (1): > rpmsg: core: Add signal API support > > drivers/rpmsg/qcom_glink_native.c | 64 +++++++++++++++++++++++++++++++++++++++ > drivers/rpmsg/rpmsg_char.c | 49 ++++++++++++++++++++++++++---- > drivers/rpmsg/rpmsg_core.c | 21 +++++++++++++ > drivers/rpmsg/rpmsg_internal.h | 2 ++ > include/linux/rpmsg.h | 15 +++++++++ > include/uapi/linux/rpmsg.h | 11 ++++++- > 6 files changed, 155 insertions(+), 7 deletions(-) >
On Thu, 20 Apr 2023 at 00:22, Sarannya S <quic_sarannya@quicinc.com> wrote: > > Added new IOCTLS- RPMSG_GET_OUTGOING_FLOWCONTROL and RPMSG_SET_INCOMING_FLOWCONTROL > to get/set the rpmsg char device's flow control signal. > Updated the cmd name 'RPM_CMD_SIGNALS' to 'GLINK_CMD_SIGNALS'. > Changed 'remote_flow' to bool type, and updated it's evaluation. > Updated evaluation of 'set' in rpmsg_char as 'set = !!arg'. > Add destination address of endpoint as parameter in rpmsg_set_flow_control. > Addressed review comments to change variable names/descriptions. > > Chris Lew (2): > rpmsg: glink: Add support to handle signals command > rpmsg: char: Add RPMSG GET/SET FLOWCONTROL IOCTL support > > Deepak Kumar Singh (1): > rpmsg: core: Add signal API support > > drivers/rpmsg/qcom_glink_native.c | 64 +++++++++++++++++++++++++++++++++++++++ > drivers/rpmsg/rpmsg_char.c | 49 ++++++++++++++++++++++++++---- > drivers/rpmsg/rpmsg_core.c | 21 +++++++++++++ > drivers/rpmsg/rpmsg_internal.h | 2 ++ > include/linux/rpmsg.h | 15 +++++++++ > include/uapi/linux/rpmsg.h | 11 ++++++- > 6 files changed, 155 insertions(+), 7 deletions(-) > It is not possible to follow what is happening with this patchset. Please send a proper V7 that takes into account the comments that were received _and_ a summary of what changed between the revisions. > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >