diff mbox series

[1/7] intel_idle: use pr_info instead of printk

Message ID 20230419143947.1342730-2-dedekind1@gmail.com (mailing list archive)
State Mainlined, archived
Headers show
Series misc intel_idle cleanups | expand

Commit Message

Artem Bityutskiy April 19, 2023, 2:39 p.m. UTC 
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

Substitute 'printk()' with 'pr_info()', because 'intel_idle' already uses
'pr_debug()', so using 'pr_info()' will be more consistent.

In addition to this, this patch addresses  the following checkpatch.pl
warning:
  WARNING: printk() should include KERN_<LEVEL> facility level

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 drivers/idle/intel_idle.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zhang Rui April 20, 2023, 8:22 a.m. UTC | #1 
On Wed, 2023-04-19 at 17:39 +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> Substitute 'printk()' with 'pr_info()', because 'intel_idle' already
> uses
> 'pr_debug()', so using 'pr_info()' will be more consistent.
> 
> In addition to this, this patch addresses  the following
> checkpatch.pl
> warning:
>   WARNING: printk() should include KERN_<LEVEL> facility level
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

Reviewed-by: Zhang Rui <rui.zhang@intel.com>

thanks,
rui
> ---
>  drivers/idle/intel_idle.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index 938c17f25d94..726a361da422 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -1895,7 +1895,7 @@ static void __init
> intel_idle_init_cstates_icpu(struct cpuidle_driver *drv)
>  		drv->states[drv->state_count] =
> cpuidle_state_table[cstate];
>  
>  		if ((cpuidle_state_table[cstate].flags &
> CPUIDLE_FLAG_IRQ_ENABLE) || force_irq_on) {
> -			printk("intel_idle: forced intel_idle_irq for
> state %d\n", cstate);
> +			pr_info("forced intel_idle_irq for state %d\n",
> cstate);
>  			drv->states[drv->state_count].enter =
> intel_idle_irq;
>  		}
>
diff mbox series

Patch

diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index 938c17f25d94..726a361da422 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -1895,7 +1895,7 @@  static void __init intel_idle_init_cstates_icpu(struct cpuidle_driver *drv)
 		drv->states[drv->state_count] = cpuidle_state_table[cstate];
 
 		if ((cpuidle_state_table[cstate].flags & CPUIDLE_FLAG_IRQ_ENABLE) || force_irq_on) {
-			printk("intel_idle: forced intel_idle_irq for state %d\n", cstate);
+			pr_info("forced intel_idle_irq for state %d\n", cstate);
 			drv->states[drv->state_count].enter = intel_idle_irq;
 		}