mbox series

[0/4] Few config related refactors

Message ID 20230323165017.27121-1-mariusz.tkaczyk@linux.intel.com (mailing list archive)
Headers show
Series Few config related refactors | expand

Message

Mariusz Tkaczyk March 23, 2023, 4:50 p.m. UTC
Hi Jes,
These patches remove multiple inlines across code and replace them
by defines or functions. No functional changes intended. The goal
is to make this some code reusable for both config and cmdline
(mdadm.c). I next patchset I will start optimizing names verification
(extended v2 of previous patchset).

Mariusz Tkaczyk (4):
  mdadm: define DEV_MD_DIR
  mdadm: define DEV_NUM_PREF
  mdadm: define is_devname_ignore()
  mdadm: numbered names verification

 Create.c      |  7 +++----
 Detail.c      |  9 ++++-----
 Incremental.c | 10 ++++------
 Monitor.c     | 34 +++++++++++++++++++---------------
 config.c      | 43 +++++++++++++++++++++----------------------
 lib.c         |  4 ++--
 mapfile.c     | 12 ++++++------
 mdadm.c       |  5 ++---
 mdadm.h       | 21 ++++++++++++++++++++-
 mdopen.c      | 16 ++++++++--------
 super-ddf.c   |  2 +-
 super-intel.c |  2 +-
 super1.c      |  3 +--
 sysfs.c       |  2 +-
 util.c        | 44 ++++++++++++++++++++++++++++++++++++++++++++
 15 files changed, 137 insertions(+), 77 deletions(-)

Comments

Xiao Ni March 24, 2023, 2:13 a.m. UTC | #1
On Fri, Mar 24, 2023 at 12:50 AM Mariusz Tkaczyk
<mariusz.tkaczyk@linux.intel.com> wrote:
>
> Hi Jes,
> These patches remove multiple inlines across code and replace them
> by defines or functions. No functional changes intended. The goal
> is to make this some code reusable for both config and cmdline
> (mdadm.c). I next patchset I will start optimizing names verification
> (extended v2 of previous patchset).
>
> Mariusz Tkaczyk (4):
>   mdadm: define DEV_MD_DIR
>   mdadm: define DEV_NUM_PREF
>   mdadm: define is_devname_ignore()
>   mdadm: numbered names verification
>
>  Create.c      |  7 +++----
>  Detail.c      |  9 ++++-----
>  Incremental.c | 10 ++++------
>  Monitor.c     | 34 +++++++++++++++++++---------------
>  config.c      | 43 +++++++++++++++++++++----------------------
>  lib.c         |  4 ++--
>  mapfile.c     | 12 ++++++------
>  mdadm.c       |  5 ++---
>  mdadm.h       | 21 ++++++++++++++++++++-
>  mdopen.c      | 16 ++++++++--------
>  super-ddf.c   |  2 +-
>  super-intel.c |  2 +-
>  super1.c      |  3 +--
>  sysfs.c       |  2 +-
>  util.c        | 44 ++++++++++++++++++++++++++++++++++++++++++++
>  15 files changed, 137 insertions(+), 77 deletions(-)
>
> --
> 2.26.2
>

Acked-by: Xiao Ni <xni@redhat.com>
Mariusz Tkaczyk April 20, 2023, 10:46 a.m. UTC | #2
On Fri, 24 Mar 2023 10:13:04 +0800
Xiao Ni <xni@redhat.com> wrote:

> On Fri, Mar 24, 2023 at 12:50 AM Mariusz Tkaczyk
> <mariusz.tkaczyk@linux.intel.com> wrote:
> >
> > Hi Jes,
> > These patches remove multiple inlines across code and replace them
> > by defines or functions. No functional changes intended. The goal
> > is to make this some code reusable for both config and cmdline
> > (mdadm.c). I next patchset I will start optimizing names verification
> > (extended v2 of previous patchset).
> >
> > Mariusz Tkaczyk (4):
> >   mdadm: define DEV_MD_DIR
> >   mdadm: define DEV_NUM_PREF
> >   mdadm: define is_devname_ignore()
> >   mdadm: numbered names verification
> >
> >  Create.c      |  7 +++----
> >  Detail.c      |  9 ++++-----
> >  Incremental.c | 10 ++++------
> >  Monitor.c     | 34 +++++++++++++++++++---------------
> >  config.c      | 43 +++++++++++++++++++++----------------------
> >  lib.c         |  4 ++--
> >  mapfile.c     | 12 ++++++------
> >  mdadm.c       |  5 ++---
> >  mdadm.h       | 21 ++++++++++++++++++++-
> >  mdopen.c      | 16 ++++++++--------
> >  super-ddf.c   |  2 +-
> >  super-intel.c |  2 +-
> >  super1.c      |  3 +--
> >  sysfs.c       |  2 +-
> >  util.c        | 44 ++++++++++++++++++++++++++++++++++++++++++++
> >  15 files changed, 137 insertions(+), 77 deletions(-)
> >
> > --
> > 2.26.2
> >  
> 
> Acked-by: Xiao Ni <xni@redhat.com>
> 

Hi Jes,
Could you please take those patches?
We are working on changes in other areas and the error enum will be useful.

Thanks,
Mariusz
Jes Sorensen May 8, 2023, 8:26 p.m. UTC | #3
On 3/23/23 12:50, Mariusz Tkaczyk wrote:
> Hi Jes,
> These patches remove multiple inlines across code and replace them
> by defines or functions. No functional changes intended. The goal
> is to make this some code reusable for both config and cmdline
> (mdadm.c). I next patchset I will start optimizing names verification
> (extended v2 of previous patchset).

Applied!

I'll push the later, I left my key at home.

Thanks,
Jes