| Message ID | 20230406110804.12024-1-zajec5@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] dt-bindings: nvmem: brcm,nvram: add #nvmem-cell-cells for MACs | expand |
On Thu, Apr 06, 2023 at 01:08:02PM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > Broadcom's NVRAM contains MACs for Ethernet interfaces. Those MACs are > usually base addresses that are also used for calculating other MACs. > > For example if a router vendor decided to use gmac0 it most likely > programmed NVRAM of each unit with a proper "et0macaddr" value. That is > a base. > > Ethernet interface is usually connected to switch port. Switch usually > includes few LAN ports and a WAN port. MAC of WAN port gets calculated > as relative address to the interface one. Offset varies depending on > device model. > > Wireless MACs may also need to be calculated using relevant offsets. > > To support all those scenarios let MAC NVMEM cells be referenced with an > index specifying MAC offset. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > .../devicetree/bindings/nvmem/brcm,nvram.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > index 36def7128fca..a921e05cc544 100644 > --- a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > +++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > @@ -36,14 +36,26 @@ properties: > et0macaddr: > type: object > description: First Ethernet interface's MAC address > + properties: > + "#nvmem-cell-cells": > + description: The first argument is a MAC address offset. > + const: 1 Not a new issue, but these nodes are missing 'additionalProperties: false'. Can you add that. With that, Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml index 36def7128fca..a921e05cc544 100644 --- a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml +++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml @@ -36,14 +36,26 @@ properties: et0macaddr: type: object description: First Ethernet interface's MAC address + properties: + "#nvmem-cell-cells": + description: The first argument is a MAC address offset. + const: 1 et1macaddr: type: object description: Second Ethernet interface's MAC address + properties: + "#nvmem-cell-cells": + description: The first argument is a MAC address offset. + const: 1 et2macaddr: type: object description: Third Ethernet interface's MAC address + properties: + "#nvmem-cell-cells": + description: The first argument is a MAC address offset. + const: 1 unevaluatedProperties: false