| Message ID | 20230419181309.338354-2-cristian.ciocaltea@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Enable rk3588 timer support | expand |
On 19/04/2023 20:13, Cristian Ciocaltea wrote: > The compatible string for Rockchip RK3288 is wrongly provided in the > 'enum' item, in addition to the subsequent 'const', which allows the > usage of an incorrect specification: > > compatible = "rockchip,rk3288-timer", "rockchip,rk3288-timer"; > > As the rk3288 string is also specified in the top-most 'const' item, the > binding already allows the usage of the correct variant: > > compatible = "rockchip,rk3288-timer"; > > Drop the unwanted rk3288 entry from the enum. > > Fixes: faa186adbd06 ("dt-bindings: timer: convert rockchip,rk-timer.txt to YAML") > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml b/Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml index 65e59836a660..2bdb6e6bdb21 100644 --- a/Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml +++ b/Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml @@ -23,7 +23,6 @@ properties: - rockchip,rk3188-timer - rockchip,rk3228-timer - rockchip,rk3229-timer - - rockchip,rk3288-timer - rockchip,rk3368-timer - rockchip,px30-timer - const: rockchip,rk3288-timer
The compatible string for Rockchip RK3288 is wrongly provided in the 'enum' item, in addition to the subsequent 'const', which allows the usage of an incorrect specification: compatible = "rockchip,rk3288-timer", "rockchip,rk3288-timer"; As the rk3288 string is also specified in the top-most 'const' item, the binding already allows the usage of the correct variant: compatible = "rockchip,rk3288-timer"; Drop the unwanted rk3288 entry from the enum. Fixes: faa186adbd06 ("dt-bindings: timer: convert rockchip,rk-timer.txt to YAML") Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> Reviewed-by: Heiko Stuebner <heiko@sntech.de> --- Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml | 1 - 1 file changed, 1 deletion(-)