| Message ID | 20230419-mips-check_bugs-init-attribute-v2-0-60a7ee65d4bf@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | MIPS: Fix check_bugs() modpost warning | expand |
On Fri, Apr 21, 2023 at 09:11:25AM -0700, Nathan Chancellor wrote: > Hi all, > > This series fixes a modpost warning visible in -next from check_bugs() > and helps avoid a potential, albeit unlikely, warning from > check_bugs_early(). > > --- > Changes in v2: > - Now two separate patches: one to avoid current check_bugs() warning > and one to avoid potential check_bugs_early() warning. > - Sink body of check_bugs_early() into setup_arch() directly, rather > than marking it as __init (Nick). > - Add Naresh's reported-by to patch 1, which came after v1 was sent. > - Reword commit messages to note that there is not a problem at run time > because check_bugs() and check_bugs_early(), while not marked __init, > are only called from __init functions; modpost does not know this > though, hence the warning. > - Link to v1: https://lore.kernel.org/r/20230419-mips-check_bugs-init-attribute-v1-1-91e6eed55b89@kernel.org > > --- > Nathan Chancellor (2): > MIPS: Mark check_bugs() as __init > MIPS: Sink body of check_bugs_early() into its only call site > > arch/mips/include/asm/bugs.h | 8 +------- > arch/mips/kernel/setup.c | 3 ++- > 2 files changed, 3 insertions(+), 8 deletions(-) > --- > base-commit: 6a8f57ae2eb07ab39a6f0ccad60c760743051026 > change-id: 20230419-mips-check_bugs-init-attribute-026103bdb255 > > Best regards, > -- > Nathan Chancellor <nathan@kernel.org> series applied to mips-next. Thomas.
Hi all, This series fixes a modpost warning visible in -next from check_bugs() and helps avoid a potential, albeit unlikely, warning from check_bugs_early(). --- Changes in v2: - Now two separate patches: one to avoid current check_bugs() warning and one to avoid potential check_bugs_early() warning. - Sink body of check_bugs_early() into setup_arch() directly, rather than marking it as __init (Nick). - Add Naresh's reported-by to patch 1, which came after v1 was sent. - Reword commit messages to note that there is not a problem at run time because check_bugs() and check_bugs_early(), while not marked __init, are only called from __init functions; modpost does not know this though, hence the warning. - Link to v1: https://lore.kernel.org/r/20230419-mips-check_bugs-init-attribute-v1-1-91e6eed55b89@kernel.org --- Nathan Chancellor (2): MIPS: Mark check_bugs() as __init MIPS: Sink body of check_bugs_early() into its only call site arch/mips/include/asm/bugs.h | 8 +------- arch/mips/kernel/setup.c | 3 ++- 2 files changed, 3 insertions(+), 8 deletions(-) --- base-commit: 6a8f57ae2eb07ab39a6f0ccad60c760743051026 change-id: 20230419-mips-check_bugs-init-attribute-026103bdb255 Best regards,