[v3,2/4] arm64: dts: qcom: sa8155p-adp: Make -cells decimal

Commit Message

Andrew Halaney April 21, 2023, 8:55 p.m. UTC

The property logically makes sense in decimal, and is the standard used
elsewhere.

Suggested-by: Konrad Dybcio <[e-mail]>
Reviewed-by: Konrad Dybcio <[e-mail]>
Signed-off-by: Andrew Halaney <[e-mail]>
---

Changes since v2:
    * Collect tags
Changes since v1:
    * New patch (Konrad)

 arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski April 24, 2023, 7:21 a.m. UTC | #1

On 21/04/2023 22:55, Andrew Halaney wrote:
> The property logically makes sense in decimal, and is the standard used
> elsewhere.
> 
> Suggested-by: Konrad Dybcio <[e-mail]>
> Reviewed-by: Konrad Dybcio <[e-mail]>
> Signed-off-by: Andrew Halaney <[e-mail]>
> ---
> 
> Changes since v2:
>     * Collect tags
> Changes since v1:
>     * New patch (Konrad)

Doing such changes per one board will be a lot of churn...

Best regards,
Krzysztof

Andrew Halaney April 24, 2023, 2:38 p.m. UTC | #2

On Mon, Apr 24, 2023 at 09:21:45AM +0200, Krzysztof Kozlowski wrote:
> On 21/04/2023 22:55, Andrew Halaney wrote:
> > The property logically makes sense in decimal, and is the standard used
> > elsewhere.
> > 
> > Suggested-by: Konrad Dybcio <[e-mail]>
> > Reviewed-by: Konrad Dybcio <[e-mail]>
> > Signed-off-by: Andrew Halaney <[e-mail]>
> > ---
> > 
> > Changes since v2:
> >     * Collect tags
> > Changes since v1:
> >     * New patch (Konrad)
> 
> Doing such changes per one board will be a lot of churn...
> 

Agreed, are you suggesting I drop this patch (and if we do this sort of
cleanup to do it in bulk)? Sorry, not entirely sure I am picking up what
that comment is implying.

Personally, I'd prefer to keeping that patch as this series is trying to
clean up the particular ethernet node.. but if the purpose of the series
was just to clean -cells up then I'd go with the bulk approach.

So as is, I'm going to leave it like so unless you have specific advice
against doing so.

Thanks,
Andrew

Krzysztof Kozlowski April 25, 2023, 8:22 a.m. UTC | #3

On 24/04/2023 16:38, Andrew Halaney wrote:
> On Mon, Apr 24, 2023 at 09:21:45AM +0200, Krzysztof Kozlowski wrote:
>> On 21/04/2023 22:55, Andrew Halaney wrote:
>>> The property logically makes sense in decimal, and is the standard used
>>> elsewhere.
>>>
>>> Suggested-by: Konrad Dybcio <[e-mail]>
>>> Reviewed-by: Konrad Dybcio <[e-mail]>
>>> Signed-off-by: Andrew Halaney <[e-mail]>
>>> ---
>>>
>>> Changes since v2:
>>>     * Collect tags
>>> Changes since v1:
>>>     * New patch (Konrad)
>>
>> Doing such changes per one board will be a lot of churn...
>>
> 
> Agreed, are you suggesting I drop this patch (and if we do this sort of
> cleanup to do it in bulk)? Sorry, not entirely sure I am picking up what
> that comment is implying.

Yes, I suggest to fix all Qualcomm arm64 boards with one patch. There
are just few more occurrences of this. It's also pure cleanup, no
functional change.

> 
> Personally, I'd prefer to keeping that patch as this series is trying to
> clean up the particular ethernet node.. but if the purpose of the series
> was just to clean -cells up then I'd go with the bulk approach.
> 
> So as is, I'm going to leave it like so unless you have specific advice
> against doing so.

Best regards,
Krzysztof

Patch

diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
index 029b23198b3a..ac52a8dfeba1 100644
--- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
+++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
@@ -353,8 +353,8 @@  &ethernet {
 
 	mdio {
 		compatible = "snps,dwmac-mdio";
-		#address-cells = <0x1>;
-		#size-cells = <0x0>;
+		#address-cells = <1>;
+		#size-cells = <0>;
 
 		/* Micrel KSZ9031RNZ PHY */
 		rgmii_phy: phy@7 {