mbox series

[0/2] memcg: OOM log improvements

Message ID 20230426133919.1342942-1-yosryahmed@google.com (mailing list archive)
Headers show
Series memcg: OOM log improvements | expand

Message

Yosry Ahmed April 26, 2023, 1:39 p.m. UTC 
This short patch series brings back some cgroup v1 stats in OOM logs,
and it makes memcg OOM logging less reliant on printk() internals.

The series uses seq_buf_do_printk() which was only recently introduced
[1]. It did not land in Linus's tree yet, but ideally it will land this
merge window. I thought I would share the patches meanwhile for
feedback.

[1]https://lore.kernel.org/lkml/20230415100110.1419872-1-senozhatsky@chromium.org/

Yosry Ahmed (2):
  memcg: use seq_buf_do_printk() with mem_cgroup_print_oom_meminfo()
  memcg: dump memory.stat during cgroup OOM for v1

 mm/memcontrol.c | 85 ++++++++++++++++++++++++++++---------------------
 1 file changed, 48 insertions(+), 37 deletions(-)

Comments

Steven Rostedt April 26, 2023, 2:19 p.m. UTC | #1 
On Wed, 26 Apr 2023 13:39:17 +0000
Yosry Ahmed <yosryahmed@google.com> wrote:

> The series uses seq_buf_do_printk() which was only recently introduced
> [1]. It did not land in Linus's tree yet, but ideally it will land this
> merge window. I thought I would share the patches meanwhile for
> feedback.
> 
> [1]https://lore.kernel.org/lkml/20230415100110.1419872-1-senozhatsky@chromium.org/

FYI, it's running through my tests right now (with several other patches).

If everything passes, I'll let it sit in linux-next for a day or two than
push to Linus at the end of the week.

-- Steve
Yosry Ahmed April 26, 2023, 2:20 p.m. UTC | #2 
On Wed, Apr 26, 2023 at 7:19 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Wed, 26 Apr 2023 13:39:17 +0000
> Yosry Ahmed <yosryahmed@google.com> wrote:
>
> > The series uses seq_buf_do_printk() which was only recently introduced
> > [1]. It did not land in Linus's tree yet, but ideally it will land this
> > merge window. I thought I would share the patches meanwhile for
> > feedback.
> >
> > [1]https://lore.kernel.org/lkml/20230415100110.1419872-1-senozhatsky@chromium.org/
>
> FYI, it's running through my tests right now (with several other patches).
>
> If everything passes, I'll let it sit in linux-next for a day or two than
> push to Linus at the end of the week.
>
> -- Steve

Great! Thanks for the update!