| Message ID | 20230314121216.413434-14-schnelle@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
Hi Niklas, On Tue, Mar 14, 2023 at 1:12 PM Niklas Schnelle <schnelle@linux.ibm.com> wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. > > Co-developed-by: Arnd Bergmann <arnd@kernel.org> > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com> Thanks for your patch! > --- a/drivers/input/serio/Kconfig > +++ b/drivers/input/serio/Kconfig > @@ -75,6 +75,7 @@ config SERIO_Q40KBD > config SERIO_PARKBD > tristate "Parallel port keyboard adapter" > depends on PARPORT > + depends on HAS_IOPORT > help > Say Y here if you built a simple parallel port adapter to attach > an additional AT keyboard, XT keyboard or PS/2 mouse. This driver seems to use only the parport and serio APIs, so it might work on systems without HAS_IOPORT. Dunno for sure. Gr{oetje,eeting}s, Geert
On Wed, 2023-03-15 at 09:22 +0100, Geert Uytterhoeven wrote: > Hi Niklas, > > On Tue, Mar 14, 2023 at 1:12 PM Niklas Schnelle <schnelle@linux.ibm.com> wrote: > > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > > not being declared. We thus need to add HAS_IOPORT as dependency for > > those drivers using them. > > > > Co-developed-by: Arnd Bergmann <arnd@kernel.org> > > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com> > > Thanks for your patch! > > > --- a/drivers/input/serio/Kconfig > > +++ b/drivers/input/serio/Kconfig > > @@ -75,6 +75,7 @@ config SERIO_Q40KBD > > config SERIO_PARKBD > > tristate "Parallel port keyboard adapter" > > depends on PARPORT > > + depends on HAS_IOPORT > > help > > Say Y here if you built a simple parallel port adapter to attach > > an additional AT keyboard, XT keyboard or PS/2 mouse. > > This driver seems to use only the parport and serio APIs, so it might > work on systems without HAS_IOPORT. Dunno for sure. > > Gr{oetje,eeting}s, > > Geert > Thanks, yes you're right this driver compiles fine without inb()/outb() etc. I removed the dependency, not sure if it used to have a dependency or this was a mixup but it's corrected for v4. Thanks, Niklas
diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig index f39b7b3f7942..5d125627c595 100644 --- a/drivers/input/serio/Kconfig +++ b/drivers/input/serio/Kconfig @@ -75,6 +75,7 @@ config SERIO_Q40KBD config SERIO_PARKBD tristate "Parallel port keyboard adapter" depends on PARPORT + depends on HAS_IOPORT help Say Y here if you built a simple parallel port adapter to attach an additional AT keyboard, XT keyboard or PS/2 mouse. @@ -148,6 +149,7 @@ config HIL_MLC config SERIO_PCIPS2 tristate "PCI PS/2 keyboard and PS/2 mouse controller" depends on PCI + depends on HAS_IOPORT help Say Y here if you have a Mobility Docking station with PS/2 keyboard and mice ports. diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig index 1a2049b336a6..6c268b8f0d19 100644 --- a/drivers/input/touchscreen/Kconfig +++ b/drivers/input/touchscreen/Kconfig @@ -690,6 +690,7 @@ config TOUCHSCREEN_INEXIO config TOUCHSCREEN_MK712 tristate "ICS MicroClock MK712 touchscreen" + depends on ISA help Say Y here if you have the ICS MicroClock MK712 touchscreen controller chip in your system.
In a future patch HAS_IOPORT=n will result in inb()/outb() and friends not being declared. We thus need to add HAS_IOPORT as dependency for those drivers using them. Co-developed-by: Arnd Bergmann <arnd@kernel.org> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com> --- drivers/input/serio/Kconfig | 2 ++ drivers/input/touchscreen/Kconfig | 1 + 2 files changed, 3 insertions(+)