mbox series

[v3,00/11] wifi: ath12k: (v3) EHT support

Message ID 20230413215156.2649-1-quic_alokad@quicinc.com (mailing list archive)
Headers show
Series wifi: ath12k: (v3) EHT support | expand

Message

Aloka Dixit April 13, 2023, 9:51 p.m. UTC 
Add driver support to bring AP up in EHT mode, configure a preamble
puncturing bitmap and associate with an EHT client.

v3: Modified patches 6 and 9 to fix some issues,
changelog included in the respective patches.
v2: This version modifies only few commit descriptions,
changelog included in the respective patches.

Following list gives the details for each patch.
1-4: Propagation of EHT capabilities from target to userspace.
Patches 1, 2 refactor the existing code to make EHT additions easier.
5: Addition of EHT phy modes.
6-9: EHT related additions in peer association.
10: Process the new WMI service ready ext2 event.
11: Preamble puncturing support.

Aloka Dixit (9):
  wifi: ath12k: rename HE capabilities setup/copy functions
  wifi: ath12k: move HE capabilities processing to a new function
  wifi: ath12k: process EHT capabilities
  wifi: ath12k: propagate EHT capabilities to userspace
  wifi: ath12k: prepare EHT peer assoc parameters
  wifi: ath12k: add WMI support for EHT peer
  wifi: ath12k: peer assoc for 320 MHz
  wifi: ath12k: parse WMI service ready ext2 event
  wifi: ath12k: configure puncturing bitmap

Muna Sinada (1):
  wifi: ath12k: add EHT PHY modes

Pradeep Kumar Chitrapu (1):
  wifi: ath12k: add MLO header in peer association

 drivers/net/wireless/ath/ath12k/core.h |   9 +
 drivers/net/wireless/ath/ath12k/mac.c  | 555 ++++++++++++++++++++-----
 drivers/net/wireless/ath/ath12k/mac.h  |   2 +-
 drivers/net/wireless/ath/ath12k/wmi.c  | 218 +++++++++-
 drivers/net/wireless/ath/ath12k/wmi.h  | 116 +++++-
 5 files changed, 790 insertions(+), 110 deletions(-)


base-commit: 177555b57ca0a0519c12a2bdb64309ddbb363e11

Comments

Kalle Valo April 26, 2023, 6:03 a.m. UTC | #1 
Aloka Dixit <quic_alokad@quicinc.com> writes:

> Add driver support to bring AP up in EHT mode, configure a preamble
> puncturing bitmap and associate with an EHT client.
>
> v3: Modified patches 6 and 9 to fix some issues,
> changelog included in the respective patches.
> v2: This version modifies only few commit descriptions,
> changelog included in the respective patches.
>
> Following list gives the details for each patch.
> 1-4: Propagation of EHT capabilities from target to userspace.
> Patches 1, 2 refactor the existing code to make EHT additions easier.
> 5: Addition of EHT phy modes.
> 6-9: EHT related additions in peer association.
> 10: Process the new WMI service ready ext2 event.
> 11: Preamble puncturing support.
>
> Aloka Dixit (9):
>   wifi: ath12k: rename HE capabilities setup/copy functions
>   wifi: ath12k: move HE capabilities processing to a new function
>   wifi: ath12k: process EHT capabilities
>   wifi: ath12k: propagate EHT capabilities to userspace
>   wifi: ath12k: prepare EHT peer assoc parameters
>   wifi: ath12k: add WMI support for EHT peer
>   wifi: ath12k: peer assoc for 320 MHz
>   wifi: ath12k: parse WMI service ready ext2 event
>   wifi: ath12k: configure puncturing bitmap
>
> Muna Sinada (1):
>   wifi: ath12k: add EHT PHY modes
>
> Pradeep Kumar Chitrapu (1):
>   wifi: ath12k: add MLO header in peer association

This breaks WCN7850 support:

[  144.039164] ath12k_pci 0000:06:00.0: BAR 0: assigned [mem 0xda200000-0xda3fffff 64bit]
[  144.039315] ath12k_pci 0000:06:00.0: enabling device (0000 -> 0002)
[  144.046220] ath12k_pci 0000:06:00.0: Hardware name: wcn7850 hw2.0
[  144.118539] mhi mhi0: Requested to power ON
[  144.118716] mhi mhi0: Power on setup success
[  144.222303] mhi mhi0: Wait for device to enter SBL or Mission mode
[  144.627712] ath12k_pci 0000:06:00.0: chip_id 0x2 chip_family 0x4 board_id 0x104 soc_id 0x40170200
[  144.627945] ath12k_pci 0000:06:00.0: fw_version 0x1005bc12 fw_build_timestamp 2022-10-11 12:13 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
[  144.959196] ath12k_pci 0000:06:00.0: failed to parse tlv -22
[  144.959317] ath12k_pci 0000:06:00.0: failed to parse ext2 event tlv -22
[  150.263567] ath12k_pci 0000:06:00.0: failed to receive wmi service ready event: -110
[  150.276547] ath12k_pci 0000:06:00.0: failed to start core: -110
Aloka Dixit April 26, 2023, 4:49 p.m. UTC | #2 
On 4/25/2023 11:03 PM, Kalle Valo wrote:
> Aloka Dixit <quic_alokad@quicinc.com> writes:
> 
>> Add driver support to bring AP up in EHT mode, configure a preamble
>> puncturing bitmap and associate with an EHT client.
>>
>> v3: Modified patches 6 and 9 to fix some issues,
>> changelog included in the respective patches.
>> v2: This version modifies only few commit descriptions,
>> changelog included in the respective patches.
>>
> This breaks WCN7850 support:
> 
> [  144.039164] ath12k_pci 0000:06:00.0: BAR 0: assigned [mem 0xda200000-0xda3fffff 64bit]
> [  144.039315] ath12k_pci 0000:06:00.0: enabling device (0000 -> 0002)
> [  144.046220] ath12k_pci 0000:06:00.0: Hardware name: wcn7850 hw2.0
> [  144.118539] mhi mhi0: Requested to power ON
> [  144.118716] mhi mhi0: Power on setup success
> [  144.222303] mhi mhi0: Wait for device to enter SBL or Mission mode
> [  144.627712] ath12k_pci 0000:06:00.0: chip_id 0x2 chip_family 0x4 board_id 0x104 soc_id 0x40170200
> [  144.627945] ath12k_pci 0000:06:00.0: fw_version 0x1005bc12 fw_build_timestamp 2022-10-11 12:13 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
> [  144.959196] ath12k_pci 0000:06:00.0: failed to parse tlv -22
> [  144.959317] ath12k_pci 0000:06:00.0: failed to parse ext2 event tlv -22
> [  150.263567] ath12k_pci 0000:06:00.0: failed to receive wmi service ready event: -110
> [  150.276547] ath12k_pci 0000:06:00.0: failed to start core: -110
> 

I have started seeing ETIMEDOUT on QCN9274 as well, AP bring up fails in 
vdev sync. It works if the sync timeout is increased.
Aloka Dixit April 28, 2023, 9:50 p.m. UTC | #3 
On 4/26/2023 9:49 AM, Aloka Dixit wrote:
> On 4/25/2023 11:03 PM, Kalle Valo wrote:
>> Aloka Dixit <quic_alokad@quicinc.com> writes:
>>
>>> Add driver support to bring AP up in EHT mode, configure a preamble
>>> puncturing bitmap and associate with an EHT client.
>>>
>>> v3: Modified patches 6 and 9 to fix some issues,
>>> changelog included in the respective patches.
>>> v2: This version modifies only few commit descriptions,
>>> changelog included in the respective patches.
>>>
>> This breaks WCN7850 support:
>>
>> [  144.039164] ath12k_pci 0000:06:00.0: BAR 0: assigned [mem 
>> 0xda200000-0xda3fffff 64bit]
>> [  144.039315] ath12k_pci 0000:06:00.0: enabling device (0000 -> 0002)
>> [  144.046220] ath12k_pci 0000:06:00.0: Hardware name: wcn7850 hw2.0
>> [  144.118539] mhi mhi0: Requested to power ON
>> [  144.118716] mhi mhi0: Power on setup success
>> [  144.222303] mhi mhi0: Wait for device to enter SBL or Mission mode
>> [  144.627712] ath12k_pci 0000:06:00.0: chip_id 0x2 chip_family 0x4 
>> board_id 0x104 soc_id 0x40170200
>> [  144.627945] ath12k_pci 0000:06:00.0: fw_version 0x1005bc12 
>> fw_build_timestamp 2022-10-11 12:13 fw_build_id 
>> QC_IMAGE_VERSION_STRING=WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
>> [  144.959196] ath12k_pci 0000:06:00.0: failed to parse tlv -22
>> [  144.959317] ath12k_pci 0000:06:00.0: failed to parse ext2 event tlv 
>> -22
>> [  150.263567] ath12k_pci 0000:06:00.0: failed to receive wmi service 
>> ready event: -110
>> [  150.276547] ath12k_pci 0000:06:00.0: failed to start core: -110
>>
> 
> I have started seeing ETIMEDOUT on QCN9274 as well, AP bring up fails in 
> vdev sync. It works if the sync timeout is increased.
> 

Just an update, this is the timeout fix required for QCN9274:
https://patchwork.kernel.org/project/linux-wireless/patch/20230428091041.20033-1-quic_rgnanase@quicinc.com/

There are also some changes required from WCN side as well.
Will update here with a link when those are available.
Thanks.
Wen Gong May 5, 2023, 3:09 a.m. UTC | #4 
On 4/26/2023 2:03 PM, Kalle Valo wrote:
> Aloka Dixit <quic_alokad@quicinc.com> writes:
>
>
...
> This breaks WCN7850 support:
>
> [  144.039164] ath12k_pci 0000:06:00.0: BAR 0: assigned [mem 0xda200000-0xda3fffff 64bit]
> [  144.039315] ath12k_pci 0000:06:00.0: enabling device (0000 -> 0002)
> [  144.046220] ath12k_pci 0000:06:00.0: Hardware name: wcn7850 hw2.0
> [  144.118539] mhi mhi0: Requested to power ON
> [  144.118716] mhi mhi0: Power on setup success
> [  144.222303] mhi mhi0: Wait for device to enter SBL or Mission mode
> [  144.627712] ath12k_pci 0000:06:00.0: chip_id 0x2 chip_family 0x4 board_id 0x104 soc_id 0x40170200
> [  144.627945] ath12k_pci 0000:06:00.0: fw_version 0x1005bc12 fw_build_timestamp 2022-10-11 12:13 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
> [  144.959196] ath12k_pci 0000:06:00.0: failed to parse tlv -22
> [  144.959317] ath12k_pci 0000:06:00.0: failed to parse ext2 event tlv -22
> [  150.263567] ath12k_pci 0000:06:00.0: failed to receive wmi service ready event: -110
> [  150.276547] ath12k_pci 0000:06:00.0: failed to start core: -110
WCN7850 use "single_pdev_only = true" in ath12k_hw_params, it has some 
difference while handler WMI_SERVICE_READY_EXT2_EVENTID.
I have patch to handler this for WCN7850, and the patch is verified.