| Message ID | 20230501102035.1180701-1-bhupesh.sharma@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/2] arm64: dts: qcom: qrb4210-rb2: Add SD pinctrl states & fix CD gpio | expand |
On 01/05/2023 12:20, Bhupesh Sharma wrote: > Add the default and sleep pinctrl states for SDHC1 & 2 controllers > on QRB4210 RB2 board. > > While at it also fix the Card-Detect (CD) gpio for SDHC2 which > allows the uSD card to be detected on the board. Separate commit is needed for the fix with Fixes tag. > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- Best regards, Krzysztof
On Mon, 1 May 2023 at 16:06, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 01/05/2023 12:20, Bhupesh Sharma wrote: > > Add the default and sleep pinctrl states for SDHC1 & 2 controllers > > on QRB4210 RB2 board. > > > > While at it also fix the Card-Detect (CD) gpio for SDHC2 which > > allows the uSD card to be detected on the board. > > Separate commit is needed for the fix with Fixes tag. Ok, will send a separate patch in v2. Thanks.
diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts index dc80f0bca767..bff6ba1d689f 100644 --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts @@ -190,6 +190,10 @@ vreg_l24a_2p96: l24 { }; &sdhc_1 { + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&sdc1_state_on>; + pinctrl-1 = <&sdc1_state_off>; + vmmc-supply = <&vreg_l24a_2p96>; vqmmc-supply = <&vreg_l11a_1p8>; no-sdio; @@ -199,7 +203,11 @@ &sdhc_1 { }; &sdhc_2 { - cd-gpios = <&tlmm 88 GPIO_ACTIVE_HIGH>; /* card detect gpio */ + cd-gpios = <&tlmm 88 GPIO_ACTIVE_LOW>; /* card detect gpio */ + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&sdc2_state_on &sdc2_card_det_n>; + pinctrl-1 = <&sdc2_state_off &sdc2_card_det_n>; + vmmc-supply = <&vreg_l22a_2p96>; vqmmc-supply = <&vreg_l5a_2p96>; no-sdio; @@ -216,6 +224,13 @@ &tlmm { <49 1>, <52 1>, <54 1>, <56 3>, <61 2>, <64 1>, <68 1>, <72 8>, <96 1>; + + sdc2_card_det_n: sd-card-det-n-state { + pins = "gpio88"; + function = "gpio"; + drive-strength = <2>; + bias-pull-up; + }; }; &uart4 {
Add the default and sleep pinctrl states for SDHC1 & 2 controllers on QRB4210 RB2 board. While at it also fix the Card-Detect (CD) gpio for SDHC2 which allows the uSD card to be detected on the board. Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)