| Message ID | 483c4f520e4acc6357ebba3e605977b4c56374df.1683022164.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e0f41f836f5e861bdcaf4719f160b62dbb8e9485 |
| Headers | show |
| Series | Input: tests - miscellaneous fixes | expand |
Hello Geert, I've only been Cc'ed in patch #2. Geert Uytterhoeven <geert+renesas@glider.be> writes: > While KUnit tests that cannot be built as a loadable module must depend > on "KUNIT=y", this is not true for modular tests, where it adds an > unnecessary limitation. > > Fix this by relaxing the dependency to "KUNIT". > > Fixes: fdefcbdd6f361841 ("Input: Add KUnit tests for some of the input core helper functions") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Hi Javier, On Tue, May 2, 2023 at 1:19 PM Javier Martinez Canillas <javierm@redhat.com> wrote: > I've only been Cc'ed in patch #2. Not really, you're in the To-header on the full series? https://lore.kernel.org/all/cover.1683022164.git.geert+renesas@glider.be > Geert Uytterhoeven <geert+renesas@glider.be> writes: > > While KUnit tests that cannot be built as a loadable module must depend > > on "KUNIT=y", this is not true for modular tests, where it adds an > > unnecessary limitation. > > > > Fix this by relaxing the dependency to "KUNIT". > > > > Fixes: fdefcbdd6f361841 ("Input: Add KUnit tests for some of the input core helper functions") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Thanks! Gr{oetje,eeting}s, Geert
Geert Uytterhoeven <geert@linux-m68k.org> writes: > Hi Javier, > > On Tue, May 2, 2023 at 1:19 PM Javier Martinez Canillas > <javierm@redhat.com> wrote: >> I've only been Cc'ed in patch #2. > > Not really, you're in the To-header on the full series? > https://lore.kernel.org/all/cover.1683022164.git.geert+renesas@glider.be > Strange... I only got patch #2, neither patch #1 nor the cover letter. For patch #1 as well: Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Sorry for missing that bug and thanks a lot for fixing it!
On Tue, 2 May 2023 at 18:17, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > While KUnit tests that cannot be built as a loadable module must depend > on "KUNIT=y", this is not true for modular tests, where it adds an > unnecessary limitation. > > Fix this by relaxing the dependency to "KUNIT". > > Fixes: fdefcbdd6f361841 ("Input: Add KUnit tests for some of the input core helper functions") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- Works here, thanks! Reviewed-by: David Gow <davidgow@google.com> Cheers, -- David > drivers/input/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig > index 735f90b74ee5ad44..3bdbd34314b3495a 100644 > --- a/drivers/input/Kconfig > +++ b/drivers/input/Kconfig > @@ -168,7 +168,7 @@ config INPUT_EVBUG > > config INPUT_KUNIT_TEST > tristate "KUnit tests for Input" if !KUNIT_ALL_TESTS > - depends on INPUT && KUNIT=y > + depends on INPUT && KUNIT > default KUNIT_ALL_TESTS > help > Say Y here if you want to build the KUnit tests for the input > -- > 2.34.1 >
diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig index 735f90b74ee5ad44..3bdbd34314b3495a 100644 --- a/drivers/input/Kconfig +++ b/drivers/input/Kconfig @@ -168,7 +168,7 @@ config INPUT_EVBUG config INPUT_KUNIT_TEST tristate "KUnit tests for Input" if !KUNIT_ALL_TESTS - depends on INPUT && KUNIT=y + depends on INPUT && KUNIT default KUNIT_ALL_TESTS help Say Y here if you want to build the KUnit tests for the input
While KUnit tests that cannot be built as a loadable module must depend on "KUNIT=y", this is not true for modular tests, where it adds an unnecessary limitation. Fix this by relaxing the dependency to "KUNIT". Fixes: fdefcbdd6f361841 ("Input: Add KUnit tests for some of the input core helper functions") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/input/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)