| Message ID | 20230503115437.262469-1-pizhenwei@bytedance.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | cryptodev: fix memory leak during stats query | expand |
On Wed, 3 May 2023 at 12:54, zhenwei pi <pizhenwei@bytedance.com> wrote: > > object_get_canonical_path already returns newly allocated memory, this > means no additional g_strdup required. Remove g_strdup to avoid memory > leak. > > Fixes: Coverity CID 1508074 > Fixes: f2b901098 ("cryptodev: Support query-stats QMP command") > Cc: Peter Maydell <peter.maydell@linaro.org> > Signed-off-by: zhenwei pi <pizhenwei@bytedance.com> > --- Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
On 5/3/23 20:59, Peter Maydell wrote: > On Wed, 3 May 2023 at 12:54, zhenwei pi <pizhenwei@bytedance.com> wrote: >> >> object_get_canonical_path already returns newly allocated memory, this >> means no additional g_strdup required. Remove g_strdup to avoid memory >> leak. >> >> Fixes: Coverity CID 1508074 >> Fixes: f2b901098 ("cryptodev: Support query-stats QMP command") >> Cc: Peter Maydell <peter.maydell@linaro.org> >> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com> >> --- > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > > thanks > -- PMM Hi, Michael This patch has been ignored, could you please merge this in next PR?
On Fri, May 26, 2023 at 04:34:21PM +0800, zhenwei pi wrote: > > > On 5/3/23 20:59, Peter Maydell wrote: > > On Wed, 3 May 2023 at 12:54, zhenwei pi <pizhenwei@bytedance.com> wrote: > > > > > > object_get_canonical_path already returns newly allocated memory, this > > > means no additional g_strdup required. Remove g_strdup to avoid memory > > > leak. > > > > > > Fixes: Coverity CID 1508074 > > > Fixes: f2b901098 ("cryptodev: Support query-stats QMP command") > > > Cc: Peter Maydell <peter.maydell@linaro.org> > > > Signed-off-by: zhenwei pi <pizhenwei@bytedance.com> > > > --- > > > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > > > > thanks > > -- PMM > > Hi, Michael > > This patch has been ignored, could you please merge this in next PR? > > -- > zhenwei pi > I don't know why - didn't have it in my inbox. Tagged now, thanks!
diff --git a/backends/cryptodev.c b/backends/cryptodev.c index 94ca393cee..7d29517843 100644 --- a/backends/cryptodev.c +++ b/backends/cryptodev.c @@ -522,7 +522,7 @@ static int cryptodev_backend_stats_query(Object *obj, void *data) entry = g_new0(StatsResult, 1); entry->provider = STATS_PROVIDER_CRYPTODEV; - entry->qom_path = g_strdup(object_get_canonical_path(obj)); + entry->qom_path = object_get_canonical_path(obj); entry->stats = stats_list; QAPI_LIST_PREPEND(*stats_results, entry);
object_get_canonical_path already returns newly allocated memory, this means no additional g_strdup required. Remove g_strdup to avoid memory leak. Fixes: Coverity CID 1508074 Fixes: f2b901098 ("cryptodev: Support query-stats QMP command") Cc: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com> --- backends/cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)