mbox series

[0/5] rewrite snd_pcm_playback_silence() again

Message ID 20230505073813.1219175-1-perex@perex.cz (mailing list archive)
Headers show
Series rewrite snd_pcm_playback_silence() again | expand

Message

Jaroslav Kysela May 5, 2023, 7:38 a.m. UTC
This is a split of changes for both patches (the first with the missing
top-up mode + later fix with mixups) proposed by Oswald. The aim was to
pick only real code changes.

Only the first two patches after revert fixes the current silencing issues.
The last two are just cleanups with the extra optimization in the last patch
moving the common code to a function.

Cc: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: Jeff Chua <jeff.chua.linux@gmail.com>

Jaroslav Kysela (5):
  ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()"
  ALSA: pcm: fix playback silence - use the actual new_hw_ptr for the
    threshold mode
  ALSA: pcm: fix playback silence - correct the incremental silencing
  ALSA: pcm: playback silence - remove extra code
  ALSA: pcm: playback silence - move silence variables updates to
    separate function

 sound/core/pcm_lib.c    | 91 +++++++++++++++++++++++++----------------
 sound/core/pcm_local.h  |  3 +-
 sound/core/pcm_native.c |  6 +--
 3 files changed, 61 insertions(+), 39 deletions(-)

Comments

Takashi Iwai May 5, 2023, 9:22 a.m. UTC | #1
On Fri, 05 May 2023 09:38:08 +0200,
Jaroslav Kysela wrote:
> 
> This is a split of changes for both patches (the first with the missing
> top-up mode + later fix with mixups) proposed by Oswald. The aim was to
> pick only real code changes.
> 
> Only the first two patches after revert fixes the current silencing issues.
> The last two are just cleanups with the extra optimization in the last patch
> moving the common code to a function.
> 
> Cc: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
> Cc: Jeff Chua <jeff.chua.linux@gmail.com>
> 
> Jaroslav Kysela (5):
>   ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()"
>   ALSA: pcm: fix playback silence - use the actual new_hw_ptr for the
>     threshold mode
>   ALSA: pcm: fix playback silence - correct the incremental silencing
>   ALSA: pcm: playback silence - remove extra code
>   ALSA: pcm: playback silence - move silence variables updates to
>     separate function

Thanks, this makes it much easier to digest the whole changes!

I watch out for a while whether any objection comes up, then apply
patches in today -- or if we didn't reach to consensus, I'll pick up
only the first revert patch for 6.4-rc1, at least.


Takashi