diff mbox series

[3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property "fsl,wp-controller"

Message ID 20230505084955.238940-3-haibo.chen@nxp.com (mailing list archive)
State New, archived
Headers show
Series [1/4] mmc: sdhci-esdhc-imx: remove unused enum cd_types | expand

Commit Message

Bough Chen May 5, 2023, 8:49 a.m. UTC 
From: Haibo Chen <haibo.chen@nxp.com>

Driver do not use this property, so remove it here.

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
 Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 5 -----
 1 file changed, 5 deletions(-)

Comments

Rob Herring (Arm) May 5, 2023, 9:33 a.m. UTC | #1 
On Fri, 05 May 2023 16:49:54 +0800, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
> 
> Driver do not use this property, so remove it here.
> 
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
>  Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 5 -----
>  1 file changed, 5 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.example.dtb: mmc@70004000: Unevaluated properties are not allowed ('fsl,wp-controller' was unexpected)
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230505084955.238940-3-haibo.chen@nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Bough Chen May 5, 2023, 10:04 a.m. UTC | #2 
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 2023年5月5日 17:33
> To: Bough Chen <haibo.chen@nxp.com>
> Cc: dl-linux-imx <linux-imx@nxp.com>; ulf.hansson@linaro.org;
> cniedermaier@dh-electronics.com; krzysztof.kozlowski+dt@linaro.org;
> kernel@pengutronix.de; kernel@dh-electronics.com; adrian.hunter@intel.com;
> festevam@gmail.com; devicetree@vger.kernel.org;
> linux-mmc@vger.kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> robh+dt@kernel.org
> Subject: Re: [PATCH 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property
> "fsl,wp-controller"
> 
> 
> On Fri, 05 May 2023 16:49:54 +0800, haibo.chen@nxp.com wrote:
> > From: Haibo Chen <haibo.chen@nxp.com>
> >
> > Driver do not use this property, so remove it here.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 5 -----
> >  1 file changed, 5 deletions(-)
> >
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc
> /fsl-imx-esdhc.example.dtb: mmc@70004000: Unevaluated properties are not
> allowed ('fsl,wp-controller' was unexpected)
> 	From schema:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc
> /fsl-imx-esdhc.yaml

Sorry, my bad, I forget to run dt_binding_check and dtbs_check, will send v2 patch which pass these checks.

Best Regards
Haibo Chen
> 
> doc reference errors (make refcheckdocs):
> 
> See
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwor
> k.ozlabs.org%2Fproject%2Fdevicetree-bindings%2Fpatch%2F20230505084955.
> 238940-3-haibo.chen%40nxp.com&data=05%7C01%7Chaibo.chen%40nxp.com
> %7C3056027b14354464981408db4d4bbbbe%7C686ea1d3bc2b4c6fa92cd99c5c
> 301635%7C0%7C0%7C638188759886680874%7CUnknown%7CTWFpbGZsb3d8
> eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%
> 7C3000%7C%7C%7C&sdata=GcuoWB8pDeia%2Fv7Rp7%2FA5gsa0lu9A3qaUcin
> K95qz%2B0%3D&reserved=0
> 
> The base for the series is generally the latest rc1. A different dependency should
> be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
index fbfd822b9270..831eadecc7e4 100644
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
@@ -96,11 +96,6 @@  properties:
   interrupts:
     maxItems: 1
 
-  fsl,wp-controller:
-    description: |
-      boolean, if present, indicate to use controller internal write protection.
-    type: boolean
-
   fsl,delay-line:
     $ref: /schemas/types.yaml#/definitions/uint32
     description: |