mbox series

[ndctl,0/3] Support for inject poison

Message ID 20230220045709.94027-1-junhyeok.im@samsung.com
Headers show
Series Support for inject poison | expand

Message

Junhyeok Im Feb. 20, 2023, 4:57 a.m. UTC
This series adds new ability to inject poison, including library update
and new command interface(inject-poison).

Junhyeok Im (3):
  libcxl: add memdev inject poison support
  cxl: add inject-poison command to cxl tool
  Documentation: add man page documentation for inject-poison

 Documentation/cxl/cxl-inject-poison.txt | 42 ++++++++++++++++++++
 Documentation/cxl/lib/libcxl.txt        |  4 ++
 Documentation/cxl/meson.build           |  1 +
 cxl/builtin.h                           |  1 +
 cxl/cxl.c                               |  1 +
 cxl/lib/libcxl.c                        | 26 ++++++++++++
 cxl/lib/libcxl.sym                      |  5 +++
 cxl/libcxl.h                            |  1 +
 cxl/memdev.c                            | 53 +++++++++++++++++++++++--
 9 files changed, 131 insertions(+), 3 deletions(-)
 create mode 100644 Documentation/cxl/cxl-inject-poison.txt


base-commit: a88bdcfb4202c73aadfee6f83c5502eb5121cbd9

Comments

Alison Schofield Feb. 27, 2023, 2:38 a.m. UTC | #1
On Mon, Feb 20, 2023 at 01:57:06PM +0900, Junhyeok Im wrote:
> This series adds new ability to inject poison, including library update
> and new command interface(inject-poison).

Hi Junhyeok,
Nice to see this set, and sorry for the delay in trying it out. I'm
using it now while prepping another version of the driver support 
for inject and clear.

> 
> Junhyeok Im (3):
>   libcxl: add memdev inject poison support
>   cxl: add inject-poison command to cxl tool
>   Documentation: add man page documentation for inject-poison

The libcxl.sym and libclx.txt changes in the 3rd patch go better
in the 1st patch that adds the libcxl support.

> 
>  Documentation/cxl/cxl-inject-poison.txt | 42 ++++++++++++++++++++
>  Documentation/cxl/lib/libcxl.txt        |  4 ++
>  Documentation/cxl/meson.build           |  1 +
>  cxl/builtin.h                           |  1 +
>  cxl/cxl.c                               |  1 +
>  cxl/lib/libcxl.c                        | 26 ++++++++++++
>  cxl/lib/libcxl.sym                      |  5 +++
>  cxl/libcxl.h                            |  1 +
>  cxl/memdev.c                            | 53 +++++++++++++++++++++++--
>  9 files changed, 131 insertions(+), 3 deletions(-)
>  create mode 100644 Documentation/cxl/cxl-inject-poison.txt
> 
> 
> base-commit: a88bdcfb4202c73aadfee6f83c5502eb5121cbd9
> -- 
> 2.34.1
>
Junhyeok Im Feb. 28, 2023, 9:31 a.m. UTC | #2
On Sun, Feb 26, 2023 at 06:38:21PM -0800, Alison Schofield wrote:
> On Mon, Feb 20, 2023 at 01:57:06PM +0900, Junhyeok Im wrote:
> > This series adds new ability to inject poison, including library update
> > and new command interface(inject-poison).
> 
> Hi Junhyeok,
> Nice to see this set, and sorry for the delay in trying it out. I'm
> using it now while prepping another version of the driver support 
> for inject and clear.
> 
> > 
> > Junhyeok Im (3):
> >   libcxl: add memdev inject poison support
> >   cxl: add inject-poison command to cxl tool
> >   Documentation: add man page documentation for inject-poison
> 
> The libcxl.sym and libclx.txt changes in the 3rd patch go better
> in the 1st patch that adds the libcxl support.
> 

Thank you Alison for your comments.
Since libcxl.sym changes are already in the 1st patch,
I will include libcxl.txt changes in the 1st patch of next series.

> > 
> >  Documentation/cxl/cxl-inject-poison.txt | 42 ++++++++++++++++++++
> >  Documentation/cxl/lib/libcxl.txt        |  4 ++
> >  Documentation/cxl/meson.build           |  1 +
> >  cxl/builtin.h                           |  1 +
> >  cxl/cxl.c                               |  1 +
> >  cxl/lib/libcxl.c                        | 26 ++++++++++++
> >  cxl/lib/libcxl.sym                      |  5 +++
> >  cxl/libcxl.h                            |  1 +
> >  cxl/memdev.c                            | 53 +++++++++++++++++++++++--
> >  9 files changed, 131 insertions(+), 3 deletions(-)
> >  create mode 100644 Documentation/cxl/cxl-inject-poison.txt
> > 
> > 
> > base-commit: a88bdcfb4202c73aadfee6f83c5502eb5121cbd9
> > -- 
> > 2.34.1
> >
Verma, Vishal L May 8, 2023, 6:39 p.m. UTC | #3
On Mon, 2023-02-20 at 13:57 +0900, Junhyeok Im wrote:
> This series adds new ability to inject poison, including library update
> and new command interface(inject-poison).

Hi Junhyeok,

With the now queued for the 6.4 kernel, the userspace side of this can
also target the next ndctl release, v78.

I see these patches will at least need a bit of rework to move from the
sysfs interface to the new debugfs interface.

Did you have a new revision of these in progress?

> 
> Junhyeok Im (3):
>   libcxl: add memdev inject poison support
>   cxl: add inject-poison command to cxl tool
>   Documentation: add man page documentation for inject-poison
> 
>  Documentation/cxl/cxl-inject-poison.txt | 42 ++++++++++++++++++++
>  Documentation/cxl/lib/libcxl.txt        |  4 ++
>  Documentation/cxl/meson.build           |  1 +
>  cxl/builtin.h                           |  1 +
>  cxl/cxl.c                               |  1 +
>  cxl/lib/libcxl.c                        | 26 ++++++++++++
>  cxl/lib/libcxl.sym                      |  5 +++
>  cxl/libcxl.h                            |  1 +
>  cxl/memdev.c                            | 53 +++++++++++++++++++++++--
>  9 files changed, 131 insertions(+), 3 deletions(-)
>  create mode 100644 Documentation/cxl/cxl-inject-poison.txt
> 
> 
> base-commit: a88bdcfb4202c73aadfee6f83c5502eb5121cbd9
Junhyeok Im May 9, 2023, 9:19 a.m. UTC | #4
On Mon, May 08, 2023 at 06:39:39PM +0000, Verma, Vishal L wrote:
> On Mon, 2023-02-20 at 13:57 +0900, Junhyeok Im wrote:
> > This series adds new ability to inject poison, including library update
> > and new command interface(inject-poison).
> 
> Hi Junhyeok,
> 
> With the now queued for the 6.4 kernel, the userspace side of this can
> also target the next ndctl release, v78.
> 
> I see these patches will at least need a bit of rework to move from the
> sysfs interface to the new debugfs interface.
> 
> Did you have a new revision of these in progress?
> 

Hi Vishal,

Thank you for confirming.
Yes, I recently found the history including Alison's inject/clear poison patch.
I am now reworking the previous patch including debugfs modification,
and I think I can submit a new patch soon including clear poison interface.

Thanks!

> > 
> > Junhyeok Im (3):
> >   libcxl: add memdev inject poison support
> >   cxl: add inject-poison command to cxl tool
> >   Documentation: add man page documentation for inject-poison
> > 
> >  Documentation/cxl/cxl-inject-poison.txt | 42 ++++++++++++++++++++
> >  Documentation/cxl/lib/libcxl.txt        |  4 ++
> >  Documentation/cxl/meson.build           |  1 +
> >  cxl/builtin.h                           |  1 +
> >  cxl/cxl.c                               |  1 +
> >  cxl/lib/libcxl.c                        | 26 ++++++++++++
> >  cxl/lib/libcxl.sym                      |  5 +++
> >  cxl/libcxl.h                            |  1 +
> >  cxl/memdev.c                            | 53 +++++++++++++++++++++++--
> >  9 files changed, 131 insertions(+), 3 deletions(-)
> >  create mode 100644 Documentation/cxl/cxl-inject-poison.txt
> > 
> > 
> > base-commit: a88bdcfb4202c73aadfee6f83c5502eb5121cbd9
>