| Message ID | 20230510111638.12408-2-andrea.mayer@uniroma2.it (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 21a933c79a33add3612808f3be4ad65dd4dc026b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | selftests: seg6: make srv6_end_dt4_l3vpn_test more robust | expand |
| Context | Check | Description |
|---|---|---|
| netdev/series_format | success | Posting correctly formatted |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/fixes_present | success | Fixes tag present in non-next series |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 8 this patch: 8 |
| netdev/cc_maintainers | success | CCed 9 of 9 maintainers |
| netdev/build_clang | success | Errors and warnings before: 8 this patch: 8 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/deprecated_api | success | None detected |
| netdev/check_selftest | success | net selftest script(s) already in Makefile |
| netdev/verify_fixes | success | Fixes tag looks correct |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 8 this patch: 8 |
| netdev/checkpatch | warning | WARNING: line length of 81 exceeds 80 columns |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On 5/10/23 5:16 AM, Andrea Mayer wrote: > The srv6_end_dt4_l3vpn_test instantiates a virtual network consisting of > several routers (rt-1, rt-2) and hosts. > When the IPv6 addresses of rt-{1,2} routers are configured, the Deduplicate > Address Detection (DAD) kicks in when enabled in the Linux distros running > the selftests. DAD is used to check whether an IPv6 address is already > assigned in a network. Such a mechanism consists of sending an ICMPv6 Echo > Request and waiting for a reply. > As the DAD process could take too long to complete, it may cause the > failing of some tests carried out by the srv6_end_dt4_l3vpn_test script. > > To make the srv6_end_dt4_l3vpn_test more robust, we disable DAD on routers > since we configure the virtual network manually and do not need any address > deduplication mechanism at all. > > Fixes: 2195444e09b4 ("selftests: add selftest for the SRv6 End.DT4 behavior") > Signed-off-by: Andrea Mayer <andrea.mayer@uniroma2.it> > --- > tools/testing/selftests/net/srv6_end_dt4_l3vpn_test.sh | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: David Ahern <dsahern@kernel.org>
diff --git a/tools/testing/selftests/net/srv6_end_dt4_l3vpn_test.sh b/tools/testing/selftests/net/srv6_end_dt4_l3vpn_test.sh index 1003119773e5..37f08d582d2f 100755 --- a/tools/testing/selftests/net/srv6_end_dt4_l3vpn_test.sh +++ b/tools/testing/selftests/net/srv6_end_dt4_l3vpn_test.sh @@ -232,10 +232,14 @@ setup_rt_networking() local nsname=rt-${rt} ip netns add ${nsname} + + ip netns exec ${nsname} sysctl -wq net.ipv6.conf.all.accept_dad=0 + ip netns exec ${nsname} sysctl -wq net.ipv6.conf.default.accept_dad=0 + ip link set veth-rt-${rt} netns ${nsname} ip -netns ${nsname} link set veth-rt-${rt} name veth0 - ip -netns ${nsname} addr add ${IPv6_RT_NETWORK}::${rt}/64 dev veth0 + ip -netns ${nsname} addr add ${IPv6_RT_NETWORK}::${rt}/64 dev veth0 nodad ip -netns ${nsname} link set veth0 up ip -netns ${nsname} link set lo up
The srv6_end_dt4_l3vpn_test instantiates a virtual network consisting of several routers (rt-1, rt-2) and hosts. When the IPv6 addresses of rt-{1,2} routers are configured, the Deduplicate Address Detection (DAD) kicks in when enabled in the Linux distros running the selftests. DAD is used to check whether an IPv6 address is already assigned in a network. Such a mechanism consists of sending an ICMPv6 Echo Request and waiting for a reply. As the DAD process could take too long to complete, it may cause the failing of some tests carried out by the srv6_end_dt4_l3vpn_test script. To make the srv6_end_dt4_l3vpn_test more robust, we disable DAD on routers since we configure the virtual network manually and do not need any address deduplication mechanism at all. Fixes: 2195444e09b4 ("selftests: add selftest for the SRv6 End.DT4 behavior") Signed-off-by: Andrea Mayer <andrea.mayer@uniroma2.it> --- tools/testing/selftests/net/srv6_end_dt4_l3vpn_test.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)