[v3] media: ov5640: correct comments for default VGA to avoid confusion

Commit Message

G.N. Zhou (OSS) May 9, 2023, 6:56 a.m. UTC

From: "Guoniu.zhou" <[e-mail]>

When OV5640 work at DVP mode, the default initialization settings
make it output 30 frames per second. But when it work at CSI-2 mode
the default link frequency will make it output 60 frames per second,
so correct the comments to make it more clear.

Signed-off-by: Guoniu.zhou <[e-mail]>
---
v2->v3:
  1) modify patch title from "fix incorrect frame frate issue for
     defulat VGA" to "correct comments for default VGA to avoid
     confusion" to make it more accurate description about this
     patch.
  2) remove code change about frame_interval parameters
  3) remove tag since my misunderstand
  4) update commit log

v1->v2:
  1) fix typo issue(s/runn/run)
  2) keep original OV5640 default link frequency
  3) correct comments and frame_interval parameters to match actual
     frame rate
---
 drivers/media/i2c/ov5640.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jacopo Mondi May 11, 2023, 7:10 a.m. UTC | #1

Hello Guoniu Zhou

On Tue, May 09, 2023 at 02:56:45PM +0800, [e-mail] wrote:
> From: "Guoniu.zhou" <[e-mail]>
>
> When OV5640 work at DVP mode, the default initialization settings
> make it output 30 frames per second. But when it work at CSI-2 mode
> the default link frequency will make it output 60 frames per second,
> so correct the comments to make it more clear.
>
> Signed-off-by: Guoniu.zhou <[e-mail]>

Thank you!

Reviewed-by: Jacopo Mondi <[e-mail]>

> ---
> v2->v3:
>   1) modify patch title from "fix incorrect frame frate issue for
>      defulat VGA" to "correct comments for default VGA to avoid
>      confusion" to make it more accurate description about this
>      patch.
>   2) remove code change about frame_interval parameters
>   3) remove tag since my misunderstand
>   4) update commit log
>
> v1->v2:
>   1) fix typo issue(s/runn/run)
>   2) keep original OV5640 default link frequency
>   3) correct comments and frame_interval parameters to match actual
>      frame rate
> ---
>  drivers/media/i2c/ov5640.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> index 1536649b9e90..e9100988a028 100644
> --- a/drivers/media/i2c/ov5640.c
> +++ b/drivers/media/i2c/ov5640.c
> @@ -3851,7 +3851,7 @@ static int ov5640_probe(struct i2c_client *client)
>
>  	/*
>  	 * default init sequence initialize sensor to
> -	 * YUV422 UYVY VGA@30fps
> +	 * YUV422 UYVY VGA(30FPS in parallel mode, 60 in MIPI CSI-2 mode)
>  	 */
>  	sensor->frame_interval.numerator = 1;
>  	sensor->frame_interval.denominator = ov5640_framerates[OV5640_30_FPS];
> --
> 2.37.1
>

Patch

diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 1536649b9e90..e9100988a028 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -3851,7 +3851,7 @@  static int ov5640_probe(struct i2c_client *client)
 
 	/*
 	 * default init sequence initialize sensor to
-	 * YUV422 UYVY VGA@30fps
+	 * YUV422 UYVY VGA(30FPS in parallel mode, 60 in MIPI CSI-2 mode)
 	 */
 	sensor->frame_interval.numerator = 1;
 	sensor->frame_interval.denominator = ov5640_framerates[OV5640_30_FPS];