| Message ID | 20230511094333.38645-1-pieter.jansen-van-vuuren@amd.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 134120b066044399ef59564ff3ba66ab344cfc5b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] sfc: disable RXFCS and RXALL features by default | expand |
On Thu, May 11, 2023 at 10:43:33AM +0100, Pieter Jansen van Vuuren wrote: > By default we would not want RXFCS and RXALL features enabled as they are > mainly intended for debugging purposes. This does not stop users from > enabling them later on as needed. > > Fixes: 8e57daf70671 ("sfc_ef100: RX path for EF100") > Signed-off-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com> > Co-developed-by: Edward Cree <ecree.xilinx@gmail.com> > Signed-off-by: Edward Cree <ecree.xilinx@gmail.com> > Reviewed-by: Martin Habets <habetsm.xilinx@gmail.com> Thanks Pieter, looks good to me. Reviewed-by: Simon Horman <simon.horman@corigine.com>
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 11 May 2023 10:43:33 +0100 you wrote: > By default we would not want RXFCS and RXALL features enabled as they are > mainly intended for debugging purposes. This does not stop users from > enabling them later on as needed. > > Fixes: 8e57daf70671 ("sfc_ef100: RX path for EF100") > Signed-off-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com> > Co-developed-by: Edward Cree <ecree.xilinx@gmail.com> > Signed-off-by: Edward Cree <ecree.xilinx@gmail.com> > Reviewed-by: Martin Habets <habetsm.xilinx@gmail.com> > > [...] Here is the summary with links: - [net] sfc: disable RXFCS and RXALL features by default https://git.kernel.org/netdev/net/c/134120b06604 You are awesome, thank you!
diff --git a/drivers/net/ethernet/sfc/ef100_netdev.c b/drivers/net/ethernet/sfc/ef100_netdev.c index d916877b5a9a..be395cd8770b 100644 --- a/drivers/net/ethernet/sfc/ef100_netdev.c +++ b/drivers/net/ethernet/sfc/ef100_netdev.c @@ -378,7 +378,9 @@ int ef100_probe_netdev(struct efx_probe_data *probe_data) efx->net_dev = net_dev; SET_NETDEV_DEV(net_dev, &efx->pci_dev->dev); - net_dev->features |= efx->type->offload_features; + /* enable all supported features except rx-fcs and rx-all */ + net_dev->features |= efx->type->offload_features & + ~(NETIF_F_RXFCS | NETIF_F_RXALL); net_dev->hw_features |= efx->type->offload_features; net_dev->hw_enc_features |= efx->type->offload_features; net_dev->vlan_features |= NETIF_F_HW_CSUM | NETIF_F_SG |
By default we would not want RXFCS and RXALL features enabled as they are mainly intended for debugging purposes. This does not stop users from enabling them later on as needed. Fixes: 8e57daf70671 ("sfc_ef100: RX path for EF100") Signed-off-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com> Co-developed-by: Edward Cree <ecree.xilinx@gmail.com> Signed-off-by: Edward Cree <ecree.xilinx@gmail.com> Reviewed-by: Martin Habets <habetsm.xilinx@gmail.com> --- drivers/net/ethernet/sfc/ef100_netdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)