| Message ID | 20230512022036.97987-8-xingyu.wu@starfivetech.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Conor Dooley |
| Headers | show |
| Series | Add PLL clocks driver and syscon for StarFive JH7110 SoC | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/tree_selection | success | Guessed tree name to be for-next at HEAD ac9a78681b92 |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 6 and now 6 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 8 this patch: 8 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 8 this patch: 8 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 25 this patch: 3 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 30 lines checked |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On 12/05/2023 04:20, Xingyu Wu wrote: > Add the PLL clock node for the Starfive JH7110 SoC and > modify the SYSCRG node to add PLL clocks input. > @@ -465,6 +469,12 @@ syscrg: clock-controller@13020000 { > sys_syscon: syscon@13030000 { > compatible = "starfive,jh7110-sys-syscon", "syscon", "simple-mfd"; > reg = <0x0 0x13030000 0x0 0x1000>; > + > + pllclk: clock-controller { > + compatible = "starfive,jh7110-pll"; > + clocks = <&osc>; > + #clock-cells = <1>; This should be part of previous patch. You just added that node. Don't add half of devices but entire device. Best regards, Krzysztof
On 2023/5/12 14:37, Krzysztof Kozlowski wrote: > On 12/05/2023 04:20, Xingyu Wu wrote: >> Add the PLL clock node for the Starfive JH7110 SoC and >> modify the SYSCRG node to add PLL clocks input. > > >> @@ -465,6 +469,12 @@ syscrg: clock-controller@13020000 { >> sys_syscon: syscon@13030000 { >> compatible = "starfive,jh7110-sys-syscon", "syscon", "simple-mfd"; >> reg = <0x0 0x13030000 0x0 0x1000>; >> + >> + pllclk: clock-controller { >> + compatible = "starfive,jh7110-pll"; >> + clocks = <&osc>; >> + #clock-cells = <1>; > > This should be part of previous patch. You just added that node. Don't > add half of devices but entire device. > So do I merge the patch 6 and patch 7 into one patch and add syscon and clock-controller together? Best regards, Xingyu Wu
On 12/05/2023 09:15, Xingyu Wu wrote: > On 2023/5/12 14:37, Krzysztof Kozlowski wrote: >> On 12/05/2023 04:20, Xingyu Wu wrote: >>> Add the PLL clock node for the Starfive JH7110 SoC and >>> modify the SYSCRG node to add PLL clocks input. >> >> >>> @@ -465,6 +469,12 @@ syscrg: clock-controller@13020000 { >>> sys_syscon: syscon@13030000 { >>> compatible = "starfive,jh7110-sys-syscon", "syscon", "simple-mfd"; >>> reg = <0x0 0x13030000 0x0 0x1000>; >>> + >>> + pllclk: clock-controller { >>> + compatible = "starfive,jh7110-pll"; >>> + clocks = <&osc>; >>> + #clock-cells = <1>; >> >> This should be part of previous patch. You just added that node. Don't >> add half of devices but entire device. >> > > So do I merge the patch 6 and patch 7 into one patch and add syscon and > clock-controller together? I am okay with adding users of clocks in separate patch, but the clock controller - so part of SYS - should be added when adding SYS. Best regards, Krzysztof
On 2023/5/12 15:22, Krzysztof Kozlowski wrote: > On 12/05/2023 09:15, Xingyu Wu wrote: >> On 2023/5/12 14:37, Krzysztof Kozlowski wrote: >>> On 12/05/2023 04:20, Xingyu Wu wrote: >>>> Add the PLL clock node for the Starfive JH7110 SoC and >>>> modify the SYSCRG node to add PLL clocks input. >>> >>> >>>> @@ -465,6 +469,12 @@ syscrg: clock-controller@13020000 { >>>> sys_syscon: syscon@13030000 { >>>> compatible = "starfive,jh7110-sys-syscon", "syscon", "simple-mfd"; >>>> reg = <0x0 0x13030000 0x0 0x1000>; >>>> + >>>> + pllclk: clock-controller { >>>> + compatible = "starfive,jh7110-pll"; >>>> + clocks = <&osc>; >>>> + #clock-cells = <1>; >>> >>> This should be part of previous patch. You just added that node. Don't >>> add half of devices but entire device. >>> >> >> So do I merge the patch 6 and patch 7 into one patch and add syscon and >> clock-controller together? > > I am okay with adding users of clocks in separate patch, but the clock > controller - so part of SYS - should be added when adding SYS. > Got it. Thanks. Best regards, Xingyu Wu
diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi index fa27fd4169a8..cdfd036a0e6c 100644 --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi @@ -452,12 +452,16 @@ syscrg: clock-controller@13020000 { <&gmac1_rgmii_rxin>, <&i2stx_bclk_ext>, <&i2stx_lrck_ext>, <&i2srx_bclk_ext>, <&i2srx_lrck_ext>, - <&tdm_ext>, <&mclk_ext>; + <&tdm_ext>, <&mclk_ext>, + <&pllclk JH7110_CLK_PLL0_OUT>, + <&pllclk JH7110_CLK_PLL1_OUT>, + <&pllclk JH7110_CLK_PLL2_OUT>; clock-names = "osc", "gmac1_rmii_refin", "gmac1_rgmii_rxin", "i2stx_bclk_ext", "i2stx_lrck_ext", "i2srx_bclk_ext", "i2srx_lrck_ext", - "tdm_ext", "mclk_ext"; + "tdm_ext", "mclk_ext", + "pll0_out", "pll1_out", "pll2_out"; #clock-cells = <1>; #reset-cells = <1>; }; @@ -465,6 +469,12 @@ syscrg: clock-controller@13020000 { sys_syscon: syscon@13030000 { compatible = "starfive,jh7110-sys-syscon", "syscon", "simple-mfd"; reg = <0x0 0x13030000 0x0 0x1000>; + + pllclk: clock-controller { + compatible = "starfive,jh7110-pll"; + clocks = <&osc>; + #clock-cells = <1>; + }; }; sysgpio: pinctrl@13040000 {
Add the PLL clock node for the Starfive JH7110 SoC and modify the SYSCRG node to add PLL clocks input. Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com> --- arch/riscv/boot/dts/starfive/jh7110.dtsi | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)