| Message ID | 20230512120003.587360-1-mika.kahola@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling | expand |
On Fri, May 12, 2023 at 03:00:03PM +0300, Mika Kahola wrote: > While disabling Thunderbolt PLL, we request PLL to be stopped and > wait for ACK bit to be cleared. The expected value should be '0' > instead of '~XELPDP_TBT_CLOCK_ACK' or otherwise we incorrectly > receive dmesg warn "PHY PLL not unlocked in 10us". > > Signed-off-by: Mika Kahola <mika.kahola@intel.com> Reviewed-by: Imre Deak <imre.deak@intel.com> > --- > drivers/gpu/drm/i915/display/intel_cx0_phy.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c > index d94127e7448b..c64cf6778627 100644 > --- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c > +++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c > @@ -2861,9 +2861,7 @@ static void intel_mtl_tbt_pll_disable(struct intel_encoder *encoder) > > /* 3. Poll on PORT_CLOCK_CTL TBT CLOCK Ack == "0". */ > if (__intel_de_wait_for_register(i915, XELPDP_PORT_CLOCK_CTL(encoder->port), > - XELPDP_TBT_CLOCK_ACK, > - ~XELPDP_TBT_CLOCK_ACK, > - 10, 0, NULL)) > + XELPDP_TBT_CLOCK_ACK, 0, 10, 0, NULL)) > drm_warn(&i915->drm, "[ENCODER:%d:%s][%c] PHY PLL not unlocked after 10us.\n", > encoder->base.base.id, encoder->base.name, phy_name(phy)); > > -- > 2.34.1 >
From: Patchwork <patchwork@emeril.freedesktop.org>
Sent: Friday, May 12, 2023 5:27 PM
To: Kahola, Mika <mika.kahola@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.BAT: failure for drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling
Patch Details
Series:
drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling
URL:
https://patchwork.freedesktop.org/series/117690/
State:
failure
Details:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/index.html
CI Bug Log - changes from CI_DRM_13142 -> Patchwork_117690v1
Summary
FAILURE
Serious unknown changes coming with Patchwork_117690v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_117690v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/index.html
Participating hosts (40 -> 38)
Additional (1): fi-kbl-soraka
Missing (3): fi-ilk-650 fi-ivb-3770 fi-snb-2520m
Possible new issues
Here are the unknown changes that may have been introduced in Patchwork_117690v1:
IGT changes
Possible regressions
* igt@dmabuf@all-tests@dma_fence:
* fi-kbl-guc: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/fi-kbl-guc/igt@dmabuf@all-tests@dma_fence.html> -> DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/fi-kbl-guc/igt@dmabuf@all-tests@dma_fence.html>
* igt@gem_exec_fence@nb-await@vecs0:
* bat-adls-5: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-adls-5/igt@gem_exec_fence@nb-await@vecs0.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/bat-adls-5/igt@gem_exec_fence@nb-await@vecs0.html> +1 similar issue
These regressions are unrelated to the MTL patch.
Known issues
Here are the changes found in Patchwork_117690v1 that come from known issues:
IGT changes
Issues hit
* igt@dmabuf@all-tests@sanitycheck:
* fi-kbl-guc: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/fi-kbl-guc/igt@dmabuf@all-tests@sanitycheck.html> -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/fi-kbl-guc/igt@dmabuf@all-tests@sanitycheck.html> (i915#8423<https://gitlab.freedesktop.org/drm/intel/issues/8423>)
* igt@gem_huc_copy@huc-copy:
* fi-kbl-soraka: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#2190<https://gitlab.freedesktop.org/drm/intel/issues/2190>)
* igt@gem_lmem_swapping@basic:
* fi-kbl-soraka: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#4613<https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 similar issues
* igt@i915_selftest@live@gt_heartbeat:
* fi-kbl-soraka: NOTRUN -> DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html> (i915#5334<https://gitlab.freedesktop.org/drm/intel/issues/5334> / i915#7872<https://gitlab.freedesktop.org/drm/intel/issues/7872>)
* igt@i915_selftest@live@gt_pm:
* fi-kbl-soraka: NOTRUN -> DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html> (i915#1886<https://gitlab.freedesktop.org/drm/intel/issues/1886> / i915#7913<https://gitlab.freedesktop.org/drm/intel/issues/7913>)
* igt@i915_selftest@live@migrate:
* bat-atsm-1: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-atsm-1/igt@i915_selftest@live@migrate.html> -> DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/bat-atsm-1/igt@i915_selftest@live@migrate.html> (i915#7699<https://gitlab.freedesktop.org/drm/intel/issues/7699> / i915#7913<https://gitlab.freedesktop.org/drm/intel/issues/7913>)
* igt@i915_selftest@live@reset:
* bat-rpls-2: NOTRUN -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/bat-rpls-2/igt@i915_selftest@live@reset.html> (i915#4983<https://gitlab.freedesktop.org/drm/intel/issues/4983> / i915#7461<https://gitlab.freedesktop.org/drm/intel/issues/7461> / i915#7913<https://gitlab.freedesktop.org/drm/intel/issues/7913> / i915#8347<https://gitlab.freedesktop.org/drm/intel/issues/8347>)
* igt@i915_selftest@live@slpc:
* bat-rpls-1: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-rpls-1/igt@i915_selftest@live@slpc.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/bat-rpls-1/igt@i915_selftest@live@slpc.html> (i915#6367<https://gitlab.freedesktop.org/drm/intel/issues/6367> / i915#7953<https://gitlab.freedesktop.org/drm/intel/issues/7953>)
* igt@kms_chamelium_frames@hdmi-crc-fast:
* fi-kbl-soraka: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +15 similar issues
* igt@kms_setmode@basic-clone-single-crtc:
* fi-kbl-soraka: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/fi-kbl-soraka/igt@kms_setmode@basic-clone-single-crtc.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#4579<https://gitlab.freedesktop.org/drm/intel/issues/4579>)
Possible fixes
* igt@gem_exec_create@basic@smem:
* bat-adls-5: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-adls-5/igt@gem_exec_create@basic@smem.html> (i915#8449<https://gitlab.freedesktop.org/drm/intel/issues/8449>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/bat-adls-5/igt@gem_exec_create@basic@smem.html> +1 similar issue
* igt@i915_selftest@live@gt_heartbeat:
* fi-glk-j4005: DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html> (i915#5334<https://gitlab.freedesktop.org/drm/intel/issues/5334>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html>
* igt@i915_selftest@live@mman:
* bat-rpls-2: TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-rpls-2/igt@i915_selftest@live@mman.html> (i915#6794<https://gitlab.freedesktop.org/drm/intel/issues/6794> / i915#7392<https://gitlab.freedesktop.org/drm/intel/issues/7392>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/bat-rpls-2/igt@i915_selftest@live@mman.html>
* igt@i915_selftest@live@requests:
* {bat-mtlp-6}: ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-mtlp-6/igt@i915_selftest@live@requests.html> (i915#4983<https://gitlab.freedesktop.org/drm/intel/issues/4983> / i915#7920<https://gitlab.freedesktop.org/drm/intel/issues/7920> / i915#7953<https://gitlab.freedesktop.org/drm/intel/issues/7953>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/bat-mtlp-6/igt@i915_selftest@live@requests.html>
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1:
* bat-dg2-8: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html> (i915#7932<https://gitlab.freedesktop.org/drm/intel/issues/7932>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v1/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html>
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
Build changes
* Linux: CI_DRM_13142 -> Patchwork_117690v1
CI-20190529: 20190529
CI_DRM_13142: feb7ce5e6311c1fe13bd46dbcd38385643323e37 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7286: a482779488f11c432d7ddcb1980691ab1603f356 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_117690v1: feb7ce5e6311c1fe13bd46dbcd38385643323e37 @ git://anongit.freedesktop.org/gfx-ci/linux
Linux commits
9dfdd21a454c drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling
From: Patchwork <patchwork@emeril.freedesktop.org>
Sent: Friday, May 12, 2023 8:13 PM
To: Kahola, Mika <mika.kahola@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.BAT: failure for drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling (rev2)
Patch Details
Series:
drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling (rev2)
URL:
https://patchwork.freedesktop.org/series/117690/
State:
failure
Details:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/index.html
CI Bug Log - changes from CI_DRM_13142 -> Patchwork_117690v2
Summary
FAILURE
Serious unknown changes coming with Patchwork_117690v2 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_117690v2, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/index.html
Participating hosts (40 -> 37)
Missing (3): fi-ilk-650 fi-ivb-3770 fi-snb-2520m
Possible new issues
Here are the unknown changes that may have been introduced in Patchwork_117690v2:
IGT changes
Possible regressions
* igt@i915_suspend@basic-s2idle-without-i915:
* fi-hsw-4770: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/fi-hsw-4770/igt@i915_suspend@basic-s2idle-without-i915.html> -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/fi-hsw-4770/igt@i915_suspend@basic-s2idle-without-i915.html>
* igt@kms_pipe_crc_basic@read-crc-frame-sequence:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-adls-5/igt@kms_pipe_crc_basic@read-crc-frame-sequence.html> +6 similar issues
These regressions are unrelated to the MTL patch.
Known issues
Here are the changes found in Patchwork_117690v2 that come from known issues:
IGT changes
Issues hit
* igt@fbdev@eof:
* bat-adls-5: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-adls-5/igt@fbdev@eof.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-adls-5/igt@fbdev@eof.html> (i915#2582<https://gitlab.freedesktop.org/drm/intel/issues/2582>) +4 similar issues
* igt@i915_pm_backlight@basic-brightness:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-adls-5/igt@i915_pm_backlight@basic-brightness.html> (i915#7561<https://gitlab.freedesktop.org/drm/intel/issues/7561>)
* igt@i915_selftest@live@migrate:
* bat-dg2-11: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-dg2-11/igt@i915_selftest@live@migrate.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-dg2-11/igt@i915_selftest@live@migrate.html> (i915#7699<https://gitlab.freedesktop.org/drm/intel/issues/7699> / i915#7953<https://gitlab.freedesktop.org/drm/intel/issues/7953>)
* igt@i915_selftest@live@requests:
* bat-rpls-1: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-rpls-1/igt@i915_selftest@live@requests.html> -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-rpls-1/igt@i915_selftest@live@requests.html> (i915#4983<https://gitlab.freedesktop.org/drm/intel/issues/4983> / i915#7911<https://gitlab.freedesktop.org/drm/intel/issues/7911> / i915#7920<https://gitlab.freedesktop.org/drm/intel/issues/7920> / i915#7953<https://gitlab.freedesktop.org/drm/intel/issues/7953>)
* igt@i915_selftest@live@slpc:
* bat-rpls-2: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-rpls-2/igt@i915_selftest@live@slpc.html> (i915#6367<https://gitlab.freedesktop.org/drm/intel/issues/6367>)
* igt@i915_suspend@basic-s3-without-i915:
* fi-apl-guc: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/fi-apl-guc/igt@i915_suspend@basic-s3-without-i915.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/fi-apl-guc/igt@i915_suspend@basic-s3-without-i915.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982> / i915#8189<https://gitlab.freedesktop.org/drm/intel/issues/8189>)
* igt@kms_busy@basic:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-adls-5/igt@kms_busy@basic.html> (i915#1845<https://gitlab.freedesktop.org/drm/intel/issues/1845>)
* igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
* bat-adls-5: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-adls-5/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-adls-5/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html> (i915#1845<https://gitlab.freedesktop.org/drm/intel/issues/1845>) +5 similar issues
* igt@kms_flip@basic-flip-vs-wf_vblank:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-adls-5/igt@kms_flip@basic-flip-vs-wf_vblank.html> (i915#3637<https://gitlab.freedesktop.org/drm/intel/issues/3637>) +3 similar issues
* igt@kms_frontbuffer_tracking@basic:
* bat-adls-5: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-adls-5/igt@kms_frontbuffer_tracking@basic.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-adls-5/igt@kms_frontbuffer_tracking@basic.html> (i915#1849<https://gitlab.freedesktop.org/drm/intel/issues/1849>)
* igt@prime_vgem@basic-fence-flip:
* bat-adls-5: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-adls-5/igt@prime_vgem@basic-fence-flip.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-adls-5/igt@prime_vgem@basic-fence-flip.html> (fdo#109295<https://bugs.freedesktop.org/show_bug.cgi?id=109295>)
Possible fixes
* igt@i915_selftest@live@gt_heartbeat:
* fi-glk-j4005: DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html> (i915#5334<https://gitlab.freedesktop.org/drm/intel/issues/5334>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html>
* igt@i915_selftest@live@mman:
* bat-rpls-2: TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-rpls-2/igt@i915_selftest@live@mman.html> (i915#6794<https://gitlab.freedesktop.org/drm/intel/issues/6794> / i915#7392<https://gitlab.freedesktop.org/drm/intel/issues/7392>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-rpls-2/igt@i915_selftest@live@mman.html>
* igt@kms_addfb_basic@bad-pitch-0:
* bat-adls-5: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-adls-5/igt@kms_addfb_basic@bad-pitch-0.html> (i915#8449<https://gitlab.freedesktop.org/drm/intel/issues/8449>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-adls-5/igt@kms_addfb_basic@bad-pitch-0.html> +38 similar issues
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1:
* bat-dg2-8: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html> (i915#7932<https://gitlab.freedesktop.org/drm/intel/issues/7932>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html>
Warnings
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
* bat-adls-5: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-adls-5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html> (i915#4103<https://gitlab.freedesktop.org/drm/intel/issues/4103>) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-adls-5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html> (i915#1845<https://gitlab.freedesktop.org/drm/intel/issues/1845>) +1 similar issue
* igt@kms_psr@sprite_plane_onoff:
* bat-adls-5: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-adls-5/igt@kms_psr@sprite_plane_onoff.html> (i915#668<https://gitlab.freedesktop.org/drm/intel/issues/668>) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-adls-5/igt@kms_psr@sprite_plane_onoff.html> (i915#1072<https://gitlab.freedesktop.org/drm/intel/issues/1072>) +3 similar issues
* igt@kms_setmode@basic-clone-single-crtc:
* bat-rplp-1: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13142/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html> (i915#3555<https://gitlab.freedesktop.org/drm/intel/issues/3555> / i915#4579<https://gitlab.freedesktop.org/drm/intel/issues/4579>) -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v2/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html> (i915#4579<https://gitlab.freedesktop.org/drm/intel/issues/4579> / i915#8260<https://gitlab.freedesktop.org/drm/intel/issues/8260>)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
Build changes
* Linux: CI_DRM_13142 -> Patchwork_117690v2
CI-20190529: 20190529
CI_DRM_13142: feb7ce5e6311c1fe13bd46dbcd38385643323e37 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7286: a482779488f11c432d7ddcb1980691ab1603f356 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_117690v2: feb7ce5e6311c1fe13bd46dbcd38385643323e37 @ git://anongit.freedesktop.org/gfx-ci/linux
Linux commits
e22d6a345a67 drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling
From: Patchwork <patchwork@emeril.freedesktop.org>
Sent: Monday, May 15, 2023 8:05 PM
To: Kahola, Mika <mika.kahola@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.BAT: failure for drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling (rev3)
Patch Details
Series:
drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling (rev3)
URL:
https://patchwork.freedesktop.org/series/117690/
State:
failure
Details:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/index.html
CI Bug Log - changes from CI_DRM_13148 -> Patchwork_117690v3
Summary
FAILURE
Serious unknown changes coming with Patchwork_117690v3 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_117690v3, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/index.html
Participating hosts (36 -> 36)
Additional (2): fi-kbl-soraka fi-apl-guc
Missing (2): fi-snb-2520m bat-mtlp-6
Possible new issues
Here are the unknown changes that may have been introduced in Patchwork_117690v3:
IGT changes
Possible regressions
* igt@vgem_basic@create:
* fi-kbl-soraka: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/fi-kbl-soraka/igt@vgem_basic@create.html>
Unrelated to this MTL patch.
Known issues
Here are the changes found in Patchwork_117690v3 that come from known issues:
IGT changes
Issues hit
* igt@debugfs_test@basic-hwmon:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adls-5/igt@debugfs_test@basic-hwmon.html> (i915#7456<https://gitlab.freedesktop.org/drm/intel/issues/7456>)
* igt@fbdev@eof:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adls-5/igt@fbdev@eof.html> (i915#2582<https://gitlab.freedesktop.org/drm/intel/issues/2582>) +4 similar issues
* igt@gem_huc_copy@huc-copy:
* fi-kbl-soraka: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#2190<https://gitlab.freedesktop.org/drm/intel/issues/2190>)
* igt@gem_lmem_swapping@basic:
* fi-apl-guc: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/fi-apl-guc/igt@gem_lmem_swapping@basic.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#4613<https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 similar issues
* fi-kbl-soraka: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#4613<https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 similar issues
* igt@gem_lmem_swapping@random-engines:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adls-5/igt@gem_lmem_swapping@random-engines.html> (i915#4613<https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 similar issues
* igt@gem_tiled_pread_basic:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adls-5/igt@gem_tiled_pread_basic.html> (i915#3282<https://gitlab.freedesktop.org/drm/intel/issues/3282>)
* igt@i915_pm_backlight@basic-brightness:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adls-5/igt@i915_pm_backlight@basic-brightness.html> (i915#7561<https://gitlab.freedesktop.org/drm/intel/issues/7561>)
* igt@i915_pm_backlight@basic-brightness@edp-1:
* bat-rplp-1: NOTRUN -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-rplp-1/igt@i915_pm_backlight@basic-brightness@edp-1.html> (i915#7077<https://gitlab.freedesktop.org/drm/intel/issues/7077>)
* igt@i915_selftest@live@execlists:
* fi-bsw-n3050: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/fi-bsw-n3050/igt@i915_selftest@live@execlists.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/fi-bsw-n3050/igt@i915_selftest@live@execlists.html> (i915#6972<https://gitlab.freedesktop.org/drm/intel/issues/6972> / i915#7913<https://gitlab.freedesktop.org/drm/intel/issues/7913>)
* fi-bsw-nick: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/fi-bsw-nick/igt@i915_selftest@live@execlists.html> -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/fi-bsw-nick/igt@i915_selftest@live@execlists.html> (i915#7913<https://gitlab.freedesktop.org/drm/intel/issues/7913>)
* igt@i915_selftest@live@gt_engines:
* bat-atsm-1: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/bat-atsm-1/igt@i915_selftest@live@gt_engines.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-atsm-1/igt@i915_selftest@live@gt_engines.html> (i915#6268<https://gitlab.freedesktop.org/drm/intel/issues/6268>)
* igt@i915_selftest@live@gt_pm:
* fi-kbl-soraka: NOTRUN -> DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html> (i915#1886<https://gitlab.freedesktop.org/drm/intel/issues/1886> / i915#7913<https://gitlab.freedesktop.org/drm/intel/issues/7913>)
* igt@i915_selftest@live@hangcheck:
* bat-adls-5: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adls-5/igt@i915_selftest@live@hangcheck.html> (i915#5591<https://gitlab.freedesktop.org/drm/intel/issues/5591>)
* igt@i915_selftest@live@slpc:
* bat-rpls-2: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-rpls-2/igt@i915_selftest@live@slpc.html> (i915#6367<https://gitlab.freedesktop.org/drm/intel/issues/6367>)
* igt@i915_suspend@basic-s2idle-without-i915:
* bat-rpls-2: NOTRUN -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html> (i915#6687<https://gitlab.freedesktop.org/drm/intel/issues/6687>)
* igt@kms_chamelium_frames@hdmi-crc-fast:
* fi-kbl-soraka: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +14 similar issues
* igt@kms_chamelium_hpd@vga-hpd-fast:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adls-5/igt@kms_chamelium_hpd@vga-hpd-fast.html> (i915#7828<https://gitlab.freedesktop.org/drm/intel/issues/7828>) +8 similar issues
* fi-apl-guc: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/fi-apl-guc/igt@kms_chamelium_hpd@vga-hpd-fast.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +20 similar issues
* igt@kms_flip@basic-flip-vs-wf_vblank:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adls-5/igt@kms_flip@basic-flip-vs-wf_vblank.html> (i915#3637<https://gitlab.freedesktop.org/drm/intel/issues/3637>) +3 similar issues
* igt@kms_force_connector_basic@force-load-detect:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adls-5/igt@kms_force_connector_basic@force-load-detect.html> (fdo#109285<https://bugs.freedesktop.org/show_bug.cgi?id=109285>)
* igt@kms_frontbuffer_tracking@basic:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adls-5/igt@kms_frontbuffer_tracking@basic.html> (i915#1849<https://gitlab.freedesktop.org/drm/intel/issues/1849>)
* igt@kms_pipe_crc_basic@read-crc:
* bat-adlp-9: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adlp-9/igt@kms_pipe_crc_basic@read-crc.html> (i915#3546<https://gitlab.freedesktop.org/drm/intel/issues/3546>) +1 similar issue
* igt@kms_pipe_crc_basic@read-crc-frame-sequence:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adls-5/igt@kms_pipe_crc_basic@read-crc-frame-sequence.html> (i915#1845<https://gitlab.freedesktop.org/drm/intel/issues/1845>) +15 similar issues
* igt@kms_psr@primary_mmap_gtt:
* bat-rplp-1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html> (i915#1072<https://gitlab.freedesktop.org/drm/intel/issues/1072>)
* igt@kms_psr@sprite_plane_onoff:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adls-5/igt@kms_psr@sprite_plane_onoff.html> (i915#1072<https://gitlab.freedesktop.org/drm/intel/issues/1072>) +3 similar issues
* igt@kms_setmode@basic-clone-single-crtc:
* bat-rplp-1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html> (i915#3555<https://gitlab.freedesktop.org/drm/intel/issues/3555> / i915#4579<https://gitlab.freedesktop.org/drm/intel/issues/4579>)
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adls-5/igt@kms_setmode@basic-clone-single-crtc.html> (i915#3555<https://gitlab.freedesktop.org/drm/intel/issues/3555> / i915#4579<https://gitlab.freedesktop.org/drm/intel/issues/4579>)
* fi-kbl-soraka: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/fi-kbl-soraka/igt@kms_setmode@basic-clone-single-crtc.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#4579<https://gitlab.freedesktop.org/drm/intel/issues/4579>)
* fi-apl-guc: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/fi-apl-guc/igt@kms_setmode@basic-clone-single-crtc.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#4579<https://gitlab.freedesktop.org/drm/intel/issues/4579>)
* igt@prime_vgem@basic-fence-flip:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adls-5/igt@prime_vgem@basic-fence-flip.html> (fdo#109295<https://bugs.freedesktop.org/show_bug.cgi?id=109295> / i915#1845<https://gitlab.freedesktop.org/drm/intel/issues/1845>)
* igt@prime_vgem@basic-read:
* bat-adls-5: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adls-5/igt@prime_vgem@basic-read.html> (fdo#109295<https://bugs.freedesktop.org/show_bug.cgi?id=109295> / i915#3291<https://gitlab.freedesktop.org/drm/intel/issues/3291>) +2 similar issues
Possible fixes
* igt@i915_module_load@load:
* bat-adls-5: ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/bat-adls-5/igt@i915_module_load@load.html> -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-adls-5/igt@i915_module_load@load.html>
* igt@i915_selftest@live@reset:
* bat-rpls-2: ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/bat-rpls-2/igt@i915_selftest@live@reset.html> (i915#4983<https://gitlab.freedesktop.org/drm/intel/issues/4983> / i915#7461<https://gitlab.freedesktop.org/drm/intel/issues/7461> / i915#7913<https://gitlab.freedesktop.org/drm/intel/issues/7913> / i915#8347<https://gitlab.freedesktop.org/drm/intel/issues/8347>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-rpls-2/igt@i915_selftest@live@reset.html>
Warnings
* igt@kms_psr@sprite_plane_onoff:
* bat-rplp-1: ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html> (i915#8442<https://gitlab.freedesktop.org/drm/intel/issues/8442>) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117690v3/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html> (i915#1072<https://gitlab.freedesktop.org/drm/intel/issues/1072>)
Build changes
* Linux: CI_DRM_13148 -> Patchwork_117690v3
CI-20190529: 20190529
CI_DRM_13148: 57a535e042517014a85f33be6fa5ed22145c56e9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7290: 0261157319fe993ccefaf270b2fc7a8ebef418ae @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_117690v3: 57a535e042517014a85f33be6fa5ed22145c56e9 @ git://anongit.freedesktop.org/gfx-ci/linux
Linux commits
a08cbfd549fc drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling
Thank you for the patch and review. Merged the patch. - Radhakrishna(RK) Sripada > -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Imre > Deak > Sent: Friday, May 12, 2023 7:12 AM > To: Kahola, Mika <mika.kahola@intel.com> > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Fix expected reg value for > Thunderbolt PLL disabling > > On Fri, May 12, 2023 at 03:00:03PM +0300, Mika Kahola wrote: > > While disabling Thunderbolt PLL, we request PLL to be stopped and > > wait for ACK bit to be cleared. The expected value should be '0' > > instead of '~XELPDP_TBT_CLOCK_ACK' or otherwise we incorrectly > > receive dmesg warn "PHY PLL not unlocked in 10us". > > > > Signed-off-by: Mika Kahola <mika.kahola@intel.com> > > Reviewed-by: Imre Deak <imre.deak@intel.com> > > > --- > > drivers/gpu/drm/i915/display/intel_cx0_phy.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c > b/drivers/gpu/drm/i915/display/intel_cx0_phy.c > > index d94127e7448b..c64cf6778627 100644 > > --- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c > > +++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c > > @@ -2861,9 +2861,7 @@ static void intel_mtl_tbt_pll_disable(struct > intel_encoder *encoder) > > > > /* 3. Poll on PORT_CLOCK_CTL TBT CLOCK Ack == "0". */ > > if (__intel_de_wait_for_register(i915, > XELPDP_PORT_CLOCK_CTL(encoder->port), > > - XELPDP_TBT_CLOCK_ACK, > > - ~XELPDP_TBT_CLOCK_ACK, > > - 10, 0, NULL)) > > + XELPDP_TBT_CLOCK_ACK, 0, 10, 0, > NULL)) > > drm_warn(&i915->drm, "[ENCODER:%d:%s][%c] PHY PLL not > unlocked after 10us.\n", > > encoder->base.base.id, encoder->base.name, > phy_name(phy)); > > > > -- > > 2.34.1 > >
diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c index d94127e7448b..c64cf6778627 100644 --- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c +++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c @@ -2861,9 +2861,7 @@ static void intel_mtl_tbt_pll_disable(struct intel_encoder *encoder) /* 3. Poll on PORT_CLOCK_CTL TBT CLOCK Ack == "0". */ if (__intel_de_wait_for_register(i915, XELPDP_PORT_CLOCK_CTL(encoder->port), - XELPDP_TBT_CLOCK_ACK, - ~XELPDP_TBT_CLOCK_ACK, - 10, 0, NULL)) + XELPDP_TBT_CLOCK_ACK, 0, 10, 0, NULL)) drm_warn(&i915->drm, "[ENCODER:%d:%s][%c] PHY PLL not unlocked after 10us.\n", encoder->base.base.id, encoder->base.name, phy_name(phy));
While disabling Thunderbolt PLL, we request PLL to be stopped and wait for ACK bit to be cleared. The expected value should be '0' instead of '~XELPDP_TBT_CLOCK_ACK' or otherwise we incorrectly receive dmesg warn "PHY PLL not unlocked in 10us". Signed-off-by: Mika Kahola <mika.kahola@intel.com> --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)