[cip-kernel-config] 5.10.y-cip/arm : Add support for access control lists.

Commit Message

[e-mail] May 15, 2023, 12:12 p.m. UTC

From: Sai <[e-mail]>

These configs are required for acl package to work
which is used for IEC-62443-4-2 evaluation.

Signed-off-by: Sai <[e-mail]>
---
 5.10.y-cip/arm/qemu_arm_defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Pavel Machek May 15, 2023, 8:26 p.m. UTC | #1

Hi!

> From: Sai <[e-mail]>
> 
> These configs are required for acl package to work
> which is used for IEC-62443-4-2 evaluation.
> 
> Signed-off-by: Sai <[e-mail]>

Seems okay to me. We'll need to apply similar changes to 6.1.

If we have ext4, do we need ext2 and ext3? IIRC ext4 can serve as both
of those.

Best regards,
								Pavel
								
> +++ b/5.10.y-cip/arm/qemu_arm_defconfig
> @@ -149,6 +149,8 @@ CONFIG_EXT2_FS=y
>  CONFIG_EXT2_FS_XATTR=y
>  CONFIG_EXT2_FS_POSIX_ACL=y
>  CONFIG_EXT3_FS=y
> +CONFIG_EXT4_FS=y
> +CONFIG_EXT4_FS_POSIX_ACL=y
> +CONFIG_TMPFS_POSIX_ACL=y
>  CONFIG_AUTOFS4_FS=y
>  CONFIG_FUSE_FS=m
>  CONFIG_OVERLAY_FS=m

Nobuhiro Iwamatsu May 15, 2023, 11:50 p.m. UTC | #2

Hi,

> -----Original Message-----
> From: [e-mail] <[e-mail]>
> Sent: Monday, May 15, 2023 9:13 PM
> To: [e-mail]; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□
> ＤＩＴ○ＯＳＴ) <[e-mail]>
> Cc: ashrith sai(ＴＳＩＰ) <[e-mail]>; dinesh
> kumar(ＴＳＩＰ TMIEC ODG Porting) <[e-mail]>
> Subject: [cip-kernel-config] 5.10.y-cip/arm : Add support for access control
> lists.

Please set a more descriptive subject.
User don't know this is a change to ext4 and tmpfs.

> 
> From: Sai <[e-mail]>
> 
> These configs are required for acl package to work which is used for
> IEC-62443-4-2 evaluation.
> 
> Signed-off-by: Sai <[e-mail]>
> ---
>  5.10.y-cip/arm/qemu_arm_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/5.10.y-cip/arm/qemu_arm_defconfig
> b/5.10.y-cip/arm/qemu_arm_defconfig
> index 58ca273..2992fea 100644
> --- a/5.10.y-cip/arm/qemu_arm_defconfig
> +++ b/5.10.y-cip/arm/qemu_arm_defconfig
> @@ -149,6 +149,8 @@ CONFIG_EXT2_FS=y
>  CONFIG_EXT2_FS_XATTR=y
>  CONFIG_EXT2_FS_POSIX_ACL=y
>  CONFIG_EXT3_FS=y
> +CONFIG_EXT4_FS=y
> +CONFIG_EXT4_FS_POSIX_ACL=y
> +CONFIG_TMPFS_POSIX_ACL=y
>  CONFIG_AUTOFS4_FS=y
>  CONFIG_FUSE_FS=m
>  CONFIG_OVERLAY_FS=m
> --
> 2.20.1

I could not apply. Please recheck this patch.

Best regards,
  Nobuhiro

Nobuhiro Iwamatsu May 15, 2023, 11:57 p.m. UTC | #3

Hi,

> -----Original Message-----
> From: Pavel Machek <[e-mail]>
> Sent: Tuesday, May 16, 2023 5:27 AM
> To: [e-mail]
> Cc: iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ)
> <[e-mail]>; ashrith sai(ＴＳＩＰ)
> <[e-mail]>; dinesh kumar(ＴＳＩＰ TMIEC ODG
> Porting) <[e-mail]>
> Subject: Re: [cip-dev] [cip-kernel-config] 5.10.y-cip/arm : Add support for
> access control lists.
> 
> Hi!
> 
> > From: Sai <[e-mail]>
> >
> > These configs are required for acl package to work which is used for
> > IEC-62443-4-2 evaluation.
> >
> > Signed-off-by: Sai <[e-mail]>
> 
> Seems okay to me. We'll need to apply similar changes to 6.1.
> 
> If we have ext4, do we need ext2 and ext3? IIRC ext4 can serve as both of those.

Agree. But IEC-62443-4-2 may require ext3, etc. I don't know the details of this...
Or if we decide to only support ext4 as CIP/QEMU, I think we don't need to configure ext2/ext3.

Best regards,
  Nobuhiro

[e-mail] May 16, 2023, 10:46 a.m. UTC | #4

Hi all,

Based on the discussion, I got that we need to remove the below configs in 5.10 arm defconfig and we need to just include ext4 configs. Is that right ?

CONFIG_EXT2_FS=y
CONFIG_EXT2_FS_XATTR=y
CONFIG_EXT2_FS_POSIX_ACL=y
CONFIG_EXT3_FS=y

Please confirm.

Thanks and regards,
Sai Ashrith (T S I P)

-----Original Message-----
From: iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ) <[e-mail]> 
Sent: Tuesday, May 16, 2023 5:27 AM
To: Pavel Machek <[e-mail]>; [e-mail]
Cc: ashrith sai(ＴＳＩＰ) <[e-mail]>; dinesh kumar(ＴＳＩＰ TMIEC ODG Porting) <[e-mail]>
Subject: RE: [cip-dev] [cip-kernel-config] 5.10.y-cip/arm : Add support for access control lists.

Hi,

> -----Original Message-----
> From: Pavel Machek <[e-mail]>
> Sent: Tuesday, May 16, 2023 5:27 AM
> To: [e-mail]
> Cc: iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ)
> <[e-mail]>; ashrith sai(ＴＳＩＰ)
> <[e-mail]>; dinesh kumar(ＴＳＩＰ TMIEC ODG
> Porting) <[e-mail]>
> Subject: Re: [cip-dev] [cip-kernel-config] 5.10.y-cip/arm : Add 
> support for access control lists.
> 
> Hi!
> 
> > From: Sai <[e-mail]>
> >
> > These configs are required for acl package to work which is used for
> > IEC-62443-4-2 evaluation.
> >
> > Signed-off-by: Sai <[e-mail]>
> 
> Seems okay to me. We'll need to apply similar changes to 6.1.
> 
> If we have ext4, do we need ext2 and ext3? IIRC ext4 can serve as both of those.

Agree. But IEC-62443-4-2 may require ext3, etc. I don't know the details of this...
Or if we decide to only support ext4 as CIP/QEMU, I think we don't need to configure ext2/ext3.

Best regards,
  Nobuhiro

[e-mail] May 16, 2023, 1:10 p.m. UTC | #5

Hi all,

I apologize for the confusion from my side. 

Actually my intention is to add the config for acl package in the IEC layer and it is not to introduce EXT4 file system config for armhf, it was added as a dependency. Currently I am checking with an acl config (CONFIG_EXT3_FS_POSIX_ACL) for the already present EXT3 file system configuration. I will re-share the patch once the outcome is positive.

Thanks and regards,
Sai Ashrith (T S I P)

-----Original Message-----
From: [e-mail] <[e-mail]> On Behalf Of [e-mail]
Sent: Tuesday, May 16, 2023 4:17 PM
To: iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ) <[e-mail]>; [e-mail]; [e-mail]
Cc: dinesh kumar(ＴＳＩＰ TMIEC ODG Porting) <[e-mail]>
Subject: Re: [cip-dev] [cip-kernel-config] 5.10.y-cip/arm : Add support for access control lists.

Hi all,

Based on the discussion, I got that we need to remove the below configs in 5.10 arm defconfig and we need to just include ext4 configs. Is that right ?

CONFIG_EXT2_FS=y
CONFIG_EXT2_FS_XATTR=y
CONFIG_EXT2_FS_POSIX_ACL=y
CONFIG_EXT3_FS=y

Please confirm.

Thanks and regards,
Sai Ashrith (T S I P)

-----Original Message-----
From: iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ) <[e-mail]>
Sent: Tuesday, May 16, 2023 5:27 AM
To: Pavel Machek <[e-mail]>; [e-mail]
Cc: ashrith sai(ＴＳＩＰ) <[e-mail]>; dinesh kumar(ＴＳＩＰ TMIEC ODG Porting) <[e-mail]>
Subject: RE: [cip-dev] [cip-kernel-config] 5.10.y-cip/arm : Add support for access control lists.

Hi,

> -----Original Message-----
> From: Pavel Machek <[e-mail]>
> Sent: Tuesday, May 16, 2023 5:27 AM
> To: [e-mail]
> Cc: iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ)
> <[e-mail]>; ashrith sai(ＴＳＩＰ)
> <[e-mail]>; dinesh kumar(ＴＳＩＰ TMIEC ODG
> Porting) <[e-mail]>
> Subject: Re: [cip-dev] [cip-kernel-config] 5.10.y-cip/arm : Add 
> support for access control lists.
> 
> Hi!
> 
> > From: Sai <[e-mail]>
> >
> > These configs are required for acl package to work which is used for
> > IEC-62443-4-2 evaluation.
> >
> > Signed-off-by: Sai <[e-mail]>
> 
> Seems okay to me. We'll need to apply similar changes to 6.1.
> 
> If we have ext4, do we need ext2 and ext3? IIRC ext4 can serve as both of those.

Agree. But IEC-62443-4-2 may require ext3, etc. I don't know the details of this...
Or if we decide to only support ext4 as CIP/QEMU, I think we don't need to configure ext2/ext3.

Best regards,
  Nobuhiro

Patch

diff --git a/5.10.y-cip/arm/qemu_arm_defconfig b/5.10.y-cip/arm/qemu_arm_defconfig
index 58ca273..2992fea 100644
--- a/5.10.y-cip/arm/qemu_arm_defconfig
+++ b/5.10.y-cip/arm/qemu_arm_defconfig
@@ -149,6 +149,8 @@  CONFIG_EXT2_FS=y
 CONFIG_EXT2_FS_XATTR=y
 CONFIG_EXT2_FS_POSIX_ACL=y
 CONFIG_EXT3_FS=y
+CONFIG_EXT4_FS=y
+CONFIG_EXT4_FS_POSIX_ACL=y
+CONFIG_TMPFS_POSIX_ACL=y
 CONFIG_AUTOFS4_FS=y
 CONFIG_FUSE_FS=m
 CONFIG_OVERLAY_FS=m