| Message ID | 20230516055006.320488-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] arm64: dts: imx8mp: move noc node to correct position | expand |
On 5/16/23 07:50, Alexander Stein wrote: > The base address of NOC is bigger than aips5, but smaller than aips4. > > Fixes: b86c3afabb4f ("arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX") I don't mind this Fixes tag, since this will likely land in the same upcoming release anyway. But in general, is this really Fixes: material ?
On 16/05/2023 09:13, Marek Vasut wrote: > On 5/16/23 07:50, Alexander Stein wrote: >> The base address of NOC is bigger than aips5, but smaller than aips4. >> >> Fixes: b86c3afabb4f ("arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX") > > I don't mind this Fixes tag, since this will likely land in the same > upcoming release anyway. > > But in general, is this really Fixes: material ? Order of nodes in DTS is not a bug... Best regards, Krzysztof
Am Dienstag, 16. Mai 2023, 09:32:31 CEST schrieb Krzysztof Kozlowski: > On 16/05/2023 09:13, Marek Vasut wrote: > > On 5/16/23 07:50, Alexander Stein wrote: > >> The base address of NOC is bigger than aips5, but smaller than aips4. > >> > >> Fixes: b86c3afabb4f ("arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX") > > > > I don't mind this Fixes tag, since this will likely land in the same > > upcoming release anyway. > > > > But in general, is this really Fixes: material ? > > Order of nodes in DTS is not a bug... > > Best regards, > Krzysztof Okay, fine for me. Want me to resend? Best regards, Alexander
On Tue, May 16, 2023 at 07:50:06AM +0200, Alexander Stein wrote: > The base address of NOC is bigger than aips5, but smaller than aips4. > > Fixes: b86c3afabb4f ("arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX") > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Applied with Fixes tag dropped. Shawn
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index 005527ea6934..39aef5fbf77b 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -1176,26 +1176,6 @@ eqos: ethernet@30bf0000 { }; }; - noc: interconnect@32700000 { - compatible = "fsl,imx8mp-noc", "fsl,imx8m-noc"; - reg = <0x32700000 0x100000>; - clocks = <&clk IMX8MP_CLK_NOC>; - #interconnect-cells = <1>; - operating-points-v2 = <&noc_opp_table>; - - noc_opp_table: opp-table { - compatible = "operating-points-v2"; - - opp-200000000 { - opp-hz = /bits/ 64 <200000000>; - }; - - opp-1000000000 { - opp-hz = /bits/ 64 <1000000000>; - }; - }; - }; - aips5: bus@30c00000 { compatible = "fsl,aips-bus", "simple-bus"; reg = <0x30c00000 0x400000>; @@ -1347,6 +1327,26 @@ audio_blk_ctrl: clock-controller@30e20000 { }; }; + noc: interconnect@32700000 { + compatible = "fsl,imx8mp-noc", "fsl,imx8m-noc"; + reg = <0x32700000 0x100000>; + clocks = <&clk IMX8MP_CLK_NOC>; + #interconnect-cells = <1>; + operating-points-v2 = <&noc_opp_table>; + + noc_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp-200000000 { + opp-hz = /bits/ 64 <200000000>; + }; + + opp-1000000000 { + opp-hz = /bits/ 64 <1000000000>; + }; + }; + }; + aips4: bus@32c00000 { compatible = "fsl,aips-bus", "simple-bus"; reg = <0x32c00000 0x400000>;
The base address of NOC is bigger than aips5, but smaller than aips4. Fixes: b86c3afabb4f ("arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX") Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- This patch is to actually move aips5 before noc, but the diff for moving noc is smaller, so that's why it is this way around. arch/arm64/boot/dts/freescale/imx8mp.dtsi | 40 +++++++++++------------ 1 file changed, 20 insertions(+), 20 deletions(-)