| Message ID | 20230515162053.2825405-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 50a1726b148ff30778cb8a6cf3736130b07c93fd |
| Headers | show |
| Series | [v3,1/2] dt-binding: cdns,usb3: Fix cdns,on-chip-buff-size type | expand |
On 15/05/2023 18:20, Frank Li wrote: > In cdns3-gadget.c, 'cdns,on-chip-buff-size' was read using > device_property_read_u16(). It resulted in 0 if a 32bit value was used > in dts. This commit fixes the dt binding doc to declare it as u16. > > Cc: stable@vger.kernel.org > Fixes: 68989fe1c39d ("dt-bindings: usb: Convert cdns-usb3.txt to YAML schema") > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, May 15, 2023 at 12:20:52PM -0400, Frank Li wrote: > In cdns3-gadget.c, 'cdns,on-chip-buff-size' was read using > device_property_read_u16(). It resulted in 0 if a 32bit value was used > in dts. This commit fixes the dt binding doc to declare it as u16. > > Cc: stable@vger.kernel.org > Fixes: 68989fe1c39d ("dt-bindings: usb: Convert cdns-usb3.txt to YAML schema") > Signed-off-by: Frank Li <Frank.Li@nxp.com> Applied both and will send them as fixes for v6.4-rc through arm-soc tree. Shawn
diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml index cae46c4982ad..69a93a0722f0 100644 --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml @@ -64,7 +64,7 @@ properties: description: size of memory intended as internal memory for endpoints buffers expressed in KB - $ref: /schemas/types.yaml#/definitions/uint32 + $ref: /schemas/types.yaml#/definitions/uint16 cdns,phyrst-a-enable: description: Enable resetting of PHY if Rx fail is detected
In cdns3-gadget.c, 'cdns,on-chip-buff-size' was read using device_property_read_u16(). It resulted in 0 if a 32bit value was used in dts. This commit fixes the dt binding doc to declare it as u16. Cc: stable@vger.kernel.org Fixes: 68989fe1c39d ("dt-bindings: usb: Convert cdns-usb3.txt to YAML schema") Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Change from v2 to v3 - add fixes tag and cc stable Change from v1 to v2 - new patch Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)