| Message ID | 20230513132136.15021-7-yi.l.liu@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Enhance vfio PCI hot reset for vfio cdev device | expand |
On Sat, 13 May 2023 06:21:32 -0700 Yi Liu <yi.l.liu@intel.com> wrote: > This is needed by the vfio-pci driver to report affected devices in the > hot reset for a given device. > > Signed-off-by: Yi Liu <yi.l.liu@intel.com> > --- > drivers/iommu/iommufd/device.c | 24 ++++++++++++++++++++++++ > drivers/vfio/iommufd.c | 20 ++++++++++++++++++++ > include/linux/iommufd.h | 6 ++++++ > include/linux/vfio.h | 14 ++++++++++++++ > 4 files changed, 64 insertions(+) > > diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c > index 4f9b2142274c..81466b97023f 100644 > --- a/drivers/iommu/iommufd/device.c > +++ b/drivers/iommu/iommufd/device.c > @@ -116,6 +116,18 @@ void iommufd_device_unbind(struct iommufd_device *idev) > } > EXPORT_SYMBOL_NS_GPL(iommufd_device_unbind, IOMMUFD); > > +struct iommufd_ctx *iommufd_device_to_ictx(struct iommufd_device *idev) > +{ > + return idev->ictx; > +} > +EXPORT_SYMBOL_NS_GPL(iommufd_device_to_ictx, IOMMUFD); > + > +u32 iommufd_device_to_id(struct iommufd_device *idev) > +{ > + return idev->obj.id; > +} > +EXPORT_SYMBOL_NS_GPL(iommufd_device_to_id, IOMMUFD); > + > static int iommufd_device_setup_msi(struct iommufd_device *idev, > struct iommufd_hw_pagetable *hwpt, > phys_addr_t sw_msi_start) > @@ -463,6 +475,18 @@ void iommufd_access_destroy(struct iommufd_access *access) > } > EXPORT_SYMBOL_NS_GPL(iommufd_access_destroy, IOMMUFD); > > +struct iommufd_ctx *iommufd_access_to_ictx(struct iommufd_access *access) > +{ > + return access->ictx; > +} > +EXPORT_SYMBOL_NS_GPL(iommufd_access_to_ictx, IOMMUFD); > + > +u32 iommufd_access_to_id(struct iommufd_access *access) > +{ > + return access->obj.id; > +} > +EXPORT_SYMBOL_NS_GPL(iommufd_access_to_id, IOMMUFD); > + > int iommufd_access_attach(struct iommufd_access *access, u32 ioas_id) > { > struct iommufd_ioas *new_ioas; > diff --git a/drivers/vfio/iommufd.c b/drivers/vfio/iommufd.c > index c1379e826052..a18e920be164 100644 > --- a/drivers/vfio/iommufd.c > +++ b/drivers/vfio/iommufd.c > @@ -105,6 +105,26 @@ void vfio_iommufd_unbind(struct vfio_device *vdev) > vdev->ops->unbind_iommufd(vdev); > } > > +struct iommufd_ctx *vfio_iommufd_physical_ictx(struct vfio_device *vdev) > +{ > + if (vdev->iommufd_device) > + return iommufd_device_to_ictx(vdev->iommufd_device); > + if (vdev->noiommu_access) > + return iommufd_access_to_ictx(vdev->noiommu_access); > + return NULL; > +} > +EXPORT_SYMBOL_GPL(vfio_iommufd_physical_ictx); > + > +int vfio_iommufd_physical_devid(struct vfio_device *vdev) > +{ > + if (vdev->iommufd_device) > + return iommufd_device_to_id(vdev->iommufd_device); > + if (vdev->noiommu_access) > + return iommufd_access_to_id(vdev->noiommu_access); > + return -EINVAL; > +} > +EXPORT_SYMBOL_GPL(vfio_iommufd_physical_devid); I think these exemplify that it would be better if both emulated and noiommu use the same iommufd_access pointer. Thanks, Alex > + > /* > * The physical standard ops mean that the iommufd_device is bound to the > * physical device vdev->dev that was provided to vfio_init_group_dev(). Drivers > diff --git a/include/linux/iommufd.h b/include/linux/iommufd.h > index 1129a36a74c4..68cd65274e28 100644 > --- a/include/linux/iommufd.h > +++ b/include/linux/iommufd.h > @@ -24,6 +24,9 @@ void iommufd_device_unbind(struct iommufd_device *idev); > int iommufd_device_attach(struct iommufd_device *idev, u32 *pt_id); > void iommufd_device_detach(struct iommufd_device *idev); > > +struct iommufd_ctx *iommufd_device_to_ictx(struct iommufd_device *idev); > +u32 iommufd_device_to_id(struct iommufd_device *idev); > + > struct iommufd_access_ops { > u8 needs_pin_pages : 1; > void (*unmap)(void *data, unsigned long iova, unsigned long length); > @@ -45,6 +48,9 @@ iommufd_access_create(struct iommufd_ctx *ictx, > void iommufd_access_destroy(struct iommufd_access *access); > int iommufd_access_attach(struct iommufd_access *access, u32 ioas_id); > > +struct iommufd_ctx *iommufd_access_to_ictx(struct iommufd_access *access); > +u32 iommufd_access_to_id(struct iommufd_access *access); > + > void iommufd_ctx_get(struct iommufd_ctx *ictx); > > #if IS_ENABLED(CONFIG_IOMMUFD) > diff --git a/include/linux/vfio.h b/include/linux/vfio.h > index a61130bc06a2..fcbe084b18c8 100644 > --- a/include/linux/vfio.h > +++ b/include/linux/vfio.h > @@ -115,6 +115,8 @@ struct vfio_device_ops { > }; > > #if IS_ENABLED(CONFIG_IOMMUFD) > +struct iommufd_ctx *vfio_iommufd_physical_ictx(struct vfio_device *vdev); > +int vfio_iommufd_physical_devid(struct vfio_device *vdev); > int vfio_iommufd_physical_bind(struct vfio_device *vdev, > struct iommufd_ctx *ictx, u32 *out_device_id); > void vfio_iommufd_physical_unbind(struct vfio_device *vdev); > @@ -124,6 +126,18 @@ int vfio_iommufd_emulated_bind(struct vfio_device *vdev, > void vfio_iommufd_emulated_unbind(struct vfio_device *vdev); > int vfio_iommufd_emulated_attach_ioas(struct vfio_device *vdev, u32 *pt_id); > #else > +static inline struct iommufd_ctx * > +vfio_iommufd_physical_ictx(struct vfio_device *vdev) > +{ > + return NULL; > +} > + > +static inline int > +vfio_iommufd_physical_devid(struct vfio_device *vdev) > +{ > + return -EOPNOTSUPP; > +} > + > #define vfio_iommufd_physical_bind \ > ((int (*)(struct vfio_device *vdev, struct iommufd_ctx *ictx, \ > u32 *out_device_id)) NULL)
On Wed, May 17, 2023 at 12:15:17PM -0600, Alex Williamson wrote: > > +int vfio_iommufd_physical_devid(struct vfio_device *vdev) > > +{ > > + if (vdev->iommufd_device) > > + return iommufd_device_to_id(vdev->iommufd_device); > > + if (vdev->noiommu_access) > > + return iommufd_access_to_id(vdev->noiommu_access); > > + return -EINVAL; > > +} > > +EXPORT_SYMBOL_GPL(vfio_iommufd_physical_devid); > > I think these exemplify that it would be better if both emulated and > noiommu use the same iommufd_access pointer. Thanks, Oh, I mis understood your other remark.. Yeah good question I have to study this also Jason
On Wed, 17 May 2023 15:22:27 -0300 Jason Gunthorpe <jgg@nvidia.com> wrote: > On Wed, May 17, 2023 at 12:15:17PM -0600, Alex Williamson wrote: > > > > +int vfio_iommufd_physical_devid(struct vfio_device *vdev) > > > +{ > > > + if (vdev->iommufd_device) > > > + return iommufd_device_to_id(vdev->iommufd_device); > > > + if (vdev->noiommu_access) > > > + return iommufd_access_to_id(vdev->noiommu_access); > > > + return -EINVAL; > > > +} > > > +EXPORT_SYMBOL_GPL(vfio_iommufd_physical_devid); > > > > I think these exemplify that it would be better if both emulated and > > noiommu use the same iommufd_access pointer. Thanks, > > Oh, I mis understood your other remark.. Yeah good question I have to > study this also I guess I also missed that this wasn't iommufd_access vs noiommu_access, it's device vs access, but shouldn't any iommufd_access pointer provide the devid? I need to go look why we need two different methods to get a devid... Thanks, Alex
On Wed, May 17, 2023 at 12:40:32PM -0600, Alex Williamson wrote: > On Wed, 17 May 2023 15:22:27 -0300 > Jason Gunthorpe <jgg@nvidia.com> wrote: > > > On Wed, May 17, 2023 at 12:15:17PM -0600, Alex Williamson wrote: > > > > > > +int vfio_iommufd_physical_devid(struct vfio_device *vdev) > > > > +{ > > > > + if (vdev->iommufd_device) > > > > + return iommufd_device_to_id(vdev->iommufd_device); > > > > + if (vdev->noiommu_access) > > > > + return iommufd_access_to_id(vdev->noiommu_access); > > > > + return -EINVAL; > > > > +} > > > > +EXPORT_SYMBOL_GPL(vfio_iommufd_physical_devid); > > > > > > I think these exemplify that it would be better if both emulated and > > > noiommu use the same iommufd_access pointer. Thanks, > > > > Oh, I mis understood your other remark.. Yeah good question I have to > > study this also > > I guess I also missed that this wasn't iommufd_access vs > noiommu_access, it's device vs access, but shouldn't any iommufd_access > pointer provide the devid? I need to go look why we need two different > methods to get a devid... At least this hunk above makes sense, access and device are two different objects with different types, so having different ID accessors is reasonably logical. But it is a good point that this should return the dev id of the normal access for a normal mdev too Ideally I'd like to see that we always return a dev id to userspace for all vfio device types. Then we can rely on it Jason
> From: Alex Williamson <alex.williamson@redhat.com> > Sent: Thursday, May 18, 2023 2:15 AM > > On Sat, 13 May 2023 06:21:32 -0700 > Yi Liu <yi.l.liu@intel.com> wrote: > > > This is needed by the vfio-pci driver to report affected devices in the > > hot reset for a given device. > > > > Signed-off-by: Yi Liu <yi.l.liu@intel.com> > > --- > > drivers/iommu/iommufd/device.c | 24 ++++++++++++++++++++++++ > > drivers/vfio/iommufd.c | 20 ++++++++++++++++++++ > > include/linux/iommufd.h | 6 ++++++ > > include/linux/vfio.h | 14 ++++++++++++++ > > 4 files changed, 64 insertions(+) > > > > diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c > > index 4f9b2142274c..81466b97023f 100644 > > --- a/drivers/iommu/iommufd/device.c > > +++ b/drivers/iommu/iommufd/device.c > > @@ -116,6 +116,18 @@ void iommufd_device_unbind(struct iommufd_device *idev) > > } > > EXPORT_SYMBOL_NS_GPL(iommufd_device_unbind, IOMMUFD); > > > > +struct iommufd_ctx *iommufd_device_to_ictx(struct iommufd_device *idev) > > +{ > > + return idev->ictx; > > +} > > +EXPORT_SYMBOL_NS_GPL(iommufd_device_to_ictx, IOMMUFD); > > + > > +u32 iommufd_device_to_id(struct iommufd_device *idev) > > +{ > > + return idev->obj.id; > > +} > > +EXPORT_SYMBOL_NS_GPL(iommufd_device_to_id, IOMMUFD); > > + > > static int iommufd_device_setup_msi(struct iommufd_device *idev, > > struct iommufd_hw_pagetable *hwpt, > > phys_addr_t sw_msi_start) > > @@ -463,6 +475,18 @@ void iommufd_access_destroy(struct iommufd_access > *access) > > } > > EXPORT_SYMBOL_NS_GPL(iommufd_access_destroy, IOMMUFD); > > > > +struct iommufd_ctx *iommufd_access_to_ictx(struct iommufd_access *access) > > +{ > > + return access->ictx; > > +} > > +EXPORT_SYMBOL_NS_GPL(iommufd_access_to_ictx, IOMMUFD); > > + > > +u32 iommufd_access_to_id(struct iommufd_access *access) > > +{ > > + return access->obj.id; > > +} > > +EXPORT_SYMBOL_NS_GPL(iommufd_access_to_id, IOMMUFD); > > + > > int iommufd_access_attach(struct iommufd_access *access, u32 ioas_id) > > { > > struct iommufd_ioas *new_ioas; > > diff --git a/drivers/vfio/iommufd.c b/drivers/vfio/iommufd.c > > index c1379e826052..a18e920be164 100644 > > --- a/drivers/vfio/iommufd.c > > +++ b/drivers/vfio/iommufd.c > > @@ -105,6 +105,26 @@ void vfio_iommufd_unbind(struct vfio_device *vdev) > > vdev->ops->unbind_iommufd(vdev); > > } > > > > +struct iommufd_ctx *vfio_iommufd_physical_ictx(struct vfio_device *vdev) > > +{ > > + if (vdev->iommufd_device) > > + return iommufd_device_to_ictx(vdev->iommufd_device); > > + if (vdev->noiommu_access) > > + return iommufd_access_to_ictx(vdev->noiommu_access); > > + return NULL; > > +} > > +EXPORT_SYMBOL_GPL(vfio_iommufd_physical_ictx); > > + > > +int vfio_iommufd_physical_devid(struct vfio_device *vdev) > > +{ > > + if (vdev->iommufd_device) > > + return iommufd_device_to_id(vdev->iommufd_device); > > + if (vdev->noiommu_access) > > + return iommufd_access_to_id(vdev->noiommu_access); > > + return -EINVAL; > > +} > > +EXPORT_SYMBOL_GPL(vfio_iommufd_physical_devid); > > I think these exemplify that it would be better if both emulated and > noiommu use the same iommufd_access pointer. Thanks, Sure. Then I shall rename this helper. vfio_iommufd_device_devid() What about your opinion? Regards, Yi Liu
On Thu, 18 May 2023 13:25:59 +0000 "Liu, Yi L" <yi.l.liu@intel.com> wrote: > > From: Alex Williamson <alex.williamson@redhat.com> > > Sent: Thursday, May 18, 2023 2:15 AM > > > > On Sat, 13 May 2023 06:21:32 -0700 > > Yi Liu <yi.l.liu@intel.com> wrote: > > > > > This is needed by the vfio-pci driver to report affected devices in the > > > hot reset for a given device. > > > > > > Signed-off-by: Yi Liu <yi.l.liu@intel.com> > > > --- > > > drivers/iommu/iommufd/device.c | 24 ++++++++++++++++++++++++ > > > drivers/vfio/iommufd.c | 20 ++++++++++++++++++++ > > > include/linux/iommufd.h | 6 ++++++ > > > include/linux/vfio.h | 14 ++++++++++++++ > > > 4 files changed, 64 insertions(+) > > > > > > diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c > > > index 4f9b2142274c..81466b97023f 100644 > > > --- a/drivers/iommu/iommufd/device.c > > > +++ b/drivers/iommu/iommufd/device.c > > > @@ -116,6 +116,18 @@ void iommufd_device_unbind(struct iommufd_device *idev) > > > } > > > EXPORT_SYMBOL_NS_GPL(iommufd_device_unbind, IOMMUFD); > > > > > > +struct iommufd_ctx *iommufd_device_to_ictx(struct iommufd_device *idev) > > > +{ > > > + return idev->ictx; > > > +} > > > +EXPORT_SYMBOL_NS_GPL(iommufd_device_to_ictx, IOMMUFD); > > > + > > > +u32 iommufd_device_to_id(struct iommufd_device *idev) > > > +{ > > > + return idev->obj.id; > > > +} > > > +EXPORT_SYMBOL_NS_GPL(iommufd_device_to_id, IOMMUFD); > > > + > > > static int iommufd_device_setup_msi(struct iommufd_device *idev, > > > struct iommufd_hw_pagetable *hwpt, > > > phys_addr_t sw_msi_start) > > > @@ -463,6 +475,18 @@ void iommufd_access_destroy(struct iommufd_access > > *access) > > > } > > > EXPORT_SYMBOL_NS_GPL(iommufd_access_destroy, IOMMUFD); > > > > > > +struct iommufd_ctx *iommufd_access_to_ictx(struct iommufd_access *access) > > > +{ > > > + return access->ictx; > > > +} > > > +EXPORT_SYMBOL_NS_GPL(iommufd_access_to_ictx, IOMMUFD); > > > + > > > +u32 iommufd_access_to_id(struct iommufd_access *access) > > > +{ > > > + return access->obj.id; > > > +} > > > +EXPORT_SYMBOL_NS_GPL(iommufd_access_to_id, IOMMUFD); > > > + > > > int iommufd_access_attach(struct iommufd_access *access, u32 ioas_id) > > > { > > > struct iommufd_ioas *new_ioas; > > > diff --git a/drivers/vfio/iommufd.c b/drivers/vfio/iommufd.c > > > index c1379e826052..a18e920be164 100644 > > > --- a/drivers/vfio/iommufd.c > > > +++ b/drivers/vfio/iommufd.c > > > @@ -105,6 +105,26 @@ void vfio_iommufd_unbind(struct vfio_device *vdev) > > > vdev->ops->unbind_iommufd(vdev); > > > } > > > > > > +struct iommufd_ctx *vfio_iommufd_physical_ictx(struct vfio_device *vdev) > > > +{ > > > + if (vdev->iommufd_device) > > > + return iommufd_device_to_ictx(vdev->iommufd_device); > > > + if (vdev->noiommu_access) > > > + return iommufd_access_to_ictx(vdev->noiommu_access); > > > + return NULL; > > > +} > > > +EXPORT_SYMBOL_GPL(vfio_iommufd_physical_ictx); > > > + > > > +int vfio_iommufd_physical_devid(struct vfio_device *vdev) > > > +{ > > > + if (vdev->iommufd_device) > > > + return iommufd_device_to_id(vdev->iommufd_device); > > > + if (vdev->noiommu_access) > > > + return iommufd_access_to_id(vdev->noiommu_access); > > > + return -EINVAL; > > > +} > > > +EXPORT_SYMBOL_GPL(vfio_iommufd_physical_devid); > > > > I think these exemplify that it would be better if both emulated and > > noiommu use the same iommufd_access pointer. Thanks, > > Sure. Then I shall rename this helper. vfio_iommufd_device_devid() > What about your opinion? Yes, it really didn't even occur to me that "physical" in the name was meant to suggest this shouldn't be used for emulated mdev devices. It should work for all devices and using a shared iommufd access pointer between noiommu and emulated should simplify that somewhat. Thanks, Alex
> From: Liu, Yi L <yi.l.liu@intel.com> > Sent: Thursday, May 18, 2023 9:26 PM > > > +int vfio_iommufd_physical_devid(struct vfio_device *vdev) > > > +{ > > > + if (vdev->iommufd_device) > > > + return iommufd_device_to_id(vdev->iommufd_device); > > > + if (vdev->noiommu_access) > > > + return iommufd_access_to_id(vdev->noiommu_access); > > > + return -EINVAL; > > > +} > > > +EXPORT_SYMBOL_GPL(vfio_iommufd_physical_devid); > > > > I think these exemplify that it would be better if both emulated and > > noiommu use the same iommufd_access pointer. Thanks, > > Sure. Then I shall rename this helper. vfio_iommufd_device_devid() > What about your opinion? > Probably just vfio_iommufd_device_id().
diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c index 4f9b2142274c..81466b97023f 100644 --- a/drivers/iommu/iommufd/device.c +++ b/drivers/iommu/iommufd/device.c @@ -116,6 +116,18 @@ void iommufd_device_unbind(struct iommufd_device *idev) } EXPORT_SYMBOL_NS_GPL(iommufd_device_unbind, IOMMUFD); +struct iommufd_ctx *iommufd_device_to_ictx(struct iommufd_device *idev) +{ + return idev->ictx; +} +EXPORT_SYMBOL_NS_GPL(iommufd_device_to_ictx, IOMMUFD); + +u32 iommufd_device_to_id(struct iommufd_device *idev) +{ + return idev->obj.id; +} +EXPORT_SYMBOL_NS_GPL(iommufd_device_to_id, IOMMUFD); + static int iommufd_device_setup_msi(struct iommufd_device *idev, struct iommufd_hw_pagetable *hwpt, phys_addr_t sw_msi_start) @@ -463,6 +475,18 @@ void iommufd_access_destroy(struct iommufd_access *access) } EXPORT_SYMBOL_NS_GPL(iommufd_access_destroy, IOMMUFD); +struct iommufd_ctx *iommufd_access_to_ictx(struct iommufd_access *access) +{ + return access->ictx; +} +EXPORT_SYMBOL_NS_GPL(iommufd_access_to_ictx, IOMMUFD); + +u32 iommufd_access_to_id(struct iommufd_access *access) +{ + return access->obj.id; +} +EXPORT_SYMBOL_NS_GPL(iommufd_access_to_id, IOMMUFD); + int iommufd_access_attach(struct iommufd_access *access, u32 ioas_id) { struct iommufd_ioas *new_ioas; diff --git a/drivers/vfio/iommufd.c b/drivers/vfio/iommufd.c index c1379e826052..a18e920be164 100644 --- a/drivers/vfio/iommufd.c +++ b/drivers/vfio/iommufd.c @@ -105,6 +105,26 @@ void vfio_iommufd_unbind(struct vfio_device *vdev) vdev->ops->unbind_iommufd(vdev); } +struct iommufd_ctx *vfio_iommufd_physical_ictx(struct vfio_device *vdev) +{ + if (vdev->iommufd_device) + return iommufd_device_to_ictx(vdev->iommufd_device); + if (vdev->noiommu_access) + return iommufd_access_to_ictx(vdev->noiommu_access); + return NULL; +} +EXPORT_SYMBOL_GPL(vfio_iommufd_physical_ictx); + +int vfio_iommufd_physical_devid(struct vfio_device *vdev) +{ + if (vdev->iommufd_device) + return iommufd_device_to_id(vdev->iommufd_device); + if (vdev->noiommu_access) + return iommufd_access_to_id(vdev->noiommu_access); + return -EINVAL; +} +EXPORT_SYMBOL_GPL(vfio_iommufd_physical_devid); + /* * The physical standard ops mean that the iommufd_device is bound to the * physical device vdev->dev that was provided to vfio_init_group_dev(). Drivers diff --git a/include/linux/iommufd.h b/include/linux/iommufd.h index 1129a36a74c4..68cd65274e28 100644 --- a/include/linux/iommufd.h +++ b/include/linux/iommufd.h @@ -24,6 +24,9 @@ void iommufd_device_unbind(struct iommufd_device *idev); int iommufd_device_attach(struct iommufd_device *idev, u32 *pt_id); void iommufd_device_detach(struct iommufd_device *idev); +struct iommufd_ctx *iommufd_device_to_ictx(struct iommufd_device *idev); +u32 iommufd_device_to_id(struct iommufd_device *idev); + struct iommufd_access_ops { u8 needs_pin_pages : 1; void (*unmap)(void *data, unsigned long iova, unsigned long length); @@ -45,6 +48,9 @@ iommufd_access_create(struct iommufd_ctx *ictx, void iommufd_access_destroy(struct iommufd_access *access); int iommufd_access_attach(struct iommufd_access *access, u32 ioas_id); +struct iommufd_ctx *iommufd_access_to_ictx(struct iommufd_access *access); +u32 iommufd_access_to_id(struct iommufd_access *access); + void iommufd_ctx_get(struct iommufd_ctx *ictx); #if IS_ENABLED(CONFIG_IOMMUFD) diff --git a/include/linux/vfio.h b/include/linux/vfio.h index a61130bc06a2..fcbe084b18c8 100644 --- a/include/linux/vfio.h +++ b/include/linux/vfio.h @@ -115,6 +115,8 @@ struct vfio_device_ops { }; #if IS_ENABLED(CONFIG_IOMMUFD) +struct iommufd_ctx *vfio_iommufd_physical_ictx(struct vfio_device *vdev); +int vfio_iommufd_physical_devid(struct vfio_device *vdev); int vfio_iommufd_physical_bind(struct vfio_device *vdev, struct iommufd_ctx *ictx, u32 *out_device_id); void vfio_iommufd_physical_unbind(struct vfio_device *vdev); @@ -124,6 +126,18 @@ int vfio_iommufd_emulated_bind(struct vfio_device *vdev, void vfio_iommufd_emulated_unbind(struct vfio_device *vdev); int vfio_iommufd_emulated_attach_ioas(struct vfio_device *vdev, u32 *pt_id); #else +static inline struct iommufd_ctx * +vfio_iommufd_physical_ictx(struct vfio_device *vdev) +{ + return NULL; +} + +static inline int +vfio_iommufd_physical_devid(struct vfio_device *vdev) +{ + return -EOPNOTSUPP; +} + #define vfio_iommufd_physical_bind \ ((int (*)(struct vfio_device *vdev, struct iommufd_ctx *ictx, \ u32 *out_device_id)) NULL)
This is needed by the vfio-pci driver to report affected devices in the hot reset for a given device. Signed-off-by: Yi Liu <yi.l.liu@intel.com> --- drivers/iommu/iommufd/device.c | 24 ++++++++++++++++++++++++ drivers/vfio/iommufd.c | 20 ++++++++++++++++++++ include/linux/iommufd.h | 6 ++++++ include/linux/vfio.h | 14 ++++++++++++++ 4 files changed, 64 insertions(+)