mbox series

[v3,0/5] PCI/ASPM: aspm_disable/default state handling and other trivial fixes

Message ID 20230504111301.229358-1-ajayagarwal@google.com (mailing list archive)
Headers show
Series PCI/ASPM: aspm_disable/default state handling and other trivial fixes | expand

Message

Ajay Agarwal May 4, 2023, 11:12 a.m. UTC 
On going through the aspm driver, I found some potential bugs
and opportunities for code cleanup in the way the aspm_disable
and aspm_default states are being handled by the driver.
Perform other refactoring as well.

Changes from v2 to v3:
 - Commit message updates

Changes from v1 to v2:
 - Split the patches into smaller patches
 - Add the patch to rename L1.2 specific functions

Ajay Agarwal (5):
  PCI/ASPM: Disable ASPM_STATE_L1 only when driver disables L1 ASPM
  PCI/ASPM: Set ASPM_STATE_L1 only when driver enables L1
  PCI/ASPM: Set ASPM_STATE_L1 when driver enables L1ss
  PCI/ASPM: Rename L1.2 specific functions
  PCI/ASPM: Remove unnecessary ASPM_STATE_L1SS check

 drivers/pci/pcie/aspm.c | 34 +++++++++++++++-------------------
 1 file changed, 15 insertions(+), 19 deletions(-)

Comments

Bjorn Helgaas May 18, 2023, 9:50 p.m. UTC | #1 
On Thu, May 04, 2023 at 04:42:56PM +0530, Ajay Agarwal wrote:
> On going through the aspm driver, I found some potential bugs
> and opportunities for code cleanup in the way the aspm_disable
> and aspm_default states are being handled by the driver.
> Perform other refactoring as well.
> 
> Changes from v2 to v3:
>  - Commit message updates
> 
> Changes from v1 to v2:
>  - Split the patches into smaller patches
>  - Add the patch to rename L1.2 specific functions
> 
> Ajay Agarwal (5):
>   PCI/ASPM: Disable ASPM_STATE_L1 only when driver disables L1 ASPM
>   PCI/ASPM: Set ASPM_STATE_L1 only when driver enables L1
>   PCI/ASPM: Set ASPM_STATE_L1 when driver enables L1ss
>   PCI/ASPM: Rename L1.2 specific functions
>   PCI/ASPM: Remove unnecessary ASPM_STATE_L1SS check
> 
>  drivers/pci/pcie/aspm.c | 34 +++++++++++++++-------------------
>  1 file changed, 15 insertions(+), 19 deletions(-)

Applied to pci/aspm for v6.5, thanks!

Bjorn
Bjorn Helgaas May 18, 2023, 9:54 p.m. UTC | #2 
On Thu, May 18, 2023 at 04:50:18PM -0500, Bjorn Helgaas wrote:
> On Thu, May 04, 2023 at 04:42:56PM +0530, Ajay Agarwal wrote:
> > On going through the aspm driver, I found some potential bugs
> > and opportunities for code cleanup in the way the aspm_disable
> > and aspm_default states are being handled by the driver.
> > Perform other refactoring as well.
> > 
> > Changes from v2 to v3:
> >  - Commit message updates
> > 
> > Changes from v1 to v2:
> >  - Split the patches into smaller patches
> >  - Add the patch to rename L1.2 specific functions
> > 
> > Ajay Agarwal (5):
> >   PCI/ASPM: Disable ASPM_STATE_L1 only when driver disables L1 ASPM
> >   PCI/ASPM: Set ASPM_STATE_L1 only when driver enables L1
> >   PCI/ASPM: Set ASPM_STATE_L1 when driver enables L1ss
> >   PCI/ASPM: Rename L1.2 specific functions
> >   PCI/ASPM: Remove unnecessary ASPM_STATE_L1SS check
> > 
> >  drivers/pci/pcie/aspm.c | 34 +++++++++++++++-------------------
> >  1 file changed, 15 insertions(+), 19 deletions(-)
> 
> Applied to pci/aspm for v6.5, thanks!

Forgot to mention that I picked up Sathy's Reviewed-by on patches 1
and 2 from the v2 posting.  If you only change things suggested by the
reviewer, you can carry those tags forward to the next posting.

Bjorn