[0/5] ASoC: topology: Clean up error messages handling

Message

Amadeusz Sławiński May 19, 2023, 7:56 p.m. UTC

Series of patches cleaning up error messages when loading topology. In
few places instead of logging in place of failure message is logged in
caller. Additionally there are places where both caller and failing
function log error, leading to unnecessary logs. Clean all of the above
up.

Amadeusz Sławiński (5):
  ASoC: topology: Log control load errors in soc_tplg_control_load()
  ASoC: topology: Remove redundant logs
  ASoC: topology: Do not split message string on multiple lines
  ASoC: topology: Remove redundant log
  ASoC: topology: Remove redundant log

 sound/soc/soc-topology.c | 63 ++++++++++++----------------------------
 1 file changed, 19 insertions(+), 44 deletions(-)

Comments

Cezary Rojewski May 19, 2023, noon UTC | #1

On 2023-05-19 9:56 PM, Amadeusz Sławiński wrote:
> Series of patches cleaning up error messages when loading topology. In
> few places instead of logging in place of failure message is logged in
> caller. Additionally there are places where both caller and failing
> function log error, leading to unnecessary logs. Clean all of the above
> up.
> 
> Amadeusz Sławiński (5):
>    ASoC: topology: Log control load errors in soc_tplg_control_load()
>    ASoC: topology: Remove redundant logs
>    ASoC: topology: Do not split message string on multiple lines
>    ASoC: topology: Remove redundant log
>    ASoC: topology: Remove redundant log


Marvelous! And not reviewed by me earlier at all :D

Reviewed-by: Cezary Rojewski <[e-mail]>

Pierre-Louis Bossart May 19, 2023, 2:58 p.m. UTC | #2

On 5/19/23 14:56, Amadeusz Sławiński wrote:
> Series of patches cleaning up error messages when loading topology. In
> few places instead of logging in place of failure message is logged in
> caller. Additionally there are places where both caller and failing
> function log error, leading to unnecessary logs. Clean all of the above
> up.
> 
> Amadeusz Sławiński (5):
>   ASoC: topology: Log control load errors in soc_tplg_control_load()
>   ASoC: topology: Remove redundant logs
>   ASoC: topology: Do not split message string on multiple lines
>   ASoC: topology: Remove redundant log
>   ASoC: topology: Remove redundant log

Nice cleanup.

For the series:

Reviewed-by: Pierre-Louis Bossart <[e-mail]>

> 
>  sound/soc/soc-topology.c | 63 ++++++++++++----------------------------
>  1 file changed, 19 insertions(+), 44 deletions(-)
>

Mark Brown May 22, 2023, 3:33 p.m. UTC | #3

On Fri, 19 May 2023 21:56:06 +0200, Amadeusz Sławiński wrote:
> Series of patches cleaning up error messages when loading topology. In
> few places instead of logging in place of failure message is logged in
> caller. Additionally there are places where both caller and failing
> function log error, leading to unnecessary logs. Clean all of the above
> up.
> 
> Amadeusz Sławiński (5):
>   ASoC: topology: Log control load errors in soc_tplg_control_load()
>   ASoC: topology: Remove redundant logs
>   ASoC: topology: Do not split message string on multiple lines
>   ASoC: topology: Remove redundant log
>   ASoC: topology: Remove redundant log
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/5] ASoC: topology: Log control load errors in soc_tplg_control_load()
      commit: ec5dffcd428f54c117158c7b2cd79a1e14aa5b70
[2/5] ASoC: topology: Remove redundant logs
      commit: 2316c11fa97779d06bfd7990f45b13a7b6ec1dae
[3/5] ASoC: topology: Do not split message string on multiple lines
      commit: 5308540278d776e10519db144cb0cf3b3dd7ffbf
[4/5] ASoC: topology: Remove redundant log
      commit: f9d1fe7e81b87378e7bb4a0be9c6fb29bbaa73c0
[5/5] ASoC: topology: Remove redundant log
      commit: f9d1fe7e81b87378e7bb4a0be9c6fb29bbaa73c0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark