mbox series

[ndctl,0/6] cxl/monitor and ndctl/monitor fixes

Message ID 20230513142038.753351-1-lizhijian@fujitsu.com (mailing list archive)
Headers show
Series cxl/monitor and ndctl/monitor fixes | expand

Message

Zhijian Li (Fujitsu) May 13, 2023, 2:20 p.m. UTC
It mainly fix monitor not working when log file is specified. For
example
$ cxl monitor -l ./cxl-monitor.log
It seems that someone missed something at the begining.

Furture, it compares the filename with reserved works more accurately

Li Zhijian (6):
  cxl/monitor: Fix monitor not working
  cxl/monitor: compare the whole filename with reserved words
  cxl/monitor: Enable default_log and refactor sanity check
  cxl/monitor: always log started message
  Documentation/cxl/cxl-monitor.txt: Fix inaccurate description
  ndctl/monitor: compare the whole filename with reserved words

 Documentation/cxl/cxl-monitor.txt |  3 +-
 cxl/monitor.c                     | 47 ++++++++++++++++---------------
 ndctl/monitor.c                   |  4 +--
 3 files changed, 27 insertions(+), 27 deletions(-)

Comments

Dave Jiang May 19, 2023, 5:47 p.m. UTC | #1
On 5/13/23 7:20 AM, Li Zhijian wrote:
> It mainly fix monitor not working when log file is specified. For
> example
> $ cxl monitor -l ./cxl-monitor.log
> It seems that someone missed something at the begining.
> 
> Furture, it compares the filename with reserved works more accurately
> 
> Li Zhijian (6):
>    cxl/monitor: Fix monitor not working
>    cxl/monitor: compare the whole filename with reserved words
>    cxl/monitor: Enable default_log and refactor sanity check
>    cxl/monitor: always log started message
>    Documentation/cxl/cxl-monitor.txt: Fix inaccurate description
>    ndctl/monitor: compare the whole filename with reserved words
> 
>   Documentation/cxl/cxl-monitor.txt |  3 +-
>   cxl/monitor.c                     | 47 ++++++++++++++++---------------
>   ndctl/monitor.c                   |  4 +--
>   3 files changed, 27 insertions(+), 27 deletions(-)
> 

Please cc linux-cxl@vger.kernel.org as well for future revs since this 
impacts CXL CLI.
Zhijian Li (Fujitsu) May 22, 2023, 6:25 a.m. UTC | #2
On 20/05/2023 01:47, Dave Jiang wrote:
> 
> 
> On 5/13/23 7:20 AM, Li Zhijian wrote:
>> It mainly fix monitor not working when log file is specified. For
>> example
>> $ cxl monitor -l ./cxl-monitor.log
>> It seems that someone missed something at the begining.
>>
>> Furture, it compares the filename with reserved works more accurately
>>
>> Li Zhijian (6):
>>    cxl/monitor: Fix monitor not working
>>    cxl/monitor: compare the whole filename with reserved words
>>    cxl/monitor: Enable default_log and refactor sanity check
>>    cxl/monitor: always log started message
>>    Documentation/cxl/cxl-monitor.txt: Fix inaccurate description
>>    ndctl/monitor: compare the whole filename with reserved words
>>
>>   Documentation/cxl/cxl-monitor.txt |  3 +-
>>   cxl/monitor.c                     | 47 ++++++++++++++++---------------
>>   ndctl/monitor.c                   |  4 +--
>>   3 files changed, 27 insertions(+), 27 deletions(-)
>>
> 
> Please cc linux-cxl@vger.kernel.org as well for future revs since this impacts CXL CLI.
Yeah

I have double confirmed recipient in this repo by 'git grep @', look we have to document it
in the CONTRIBUTING.md as well :)
Dave Jiang May 22, 2023, 3:19 p.m. UTC | #3
On 5/21/23 11:25 PM, Zhijian Li (Fujitsu) wrote:
> 
> 
> On 20/05/2023 01:47, Dave Jiang wrote:
>>
>>
>> On 5/13/23 7:20 AM, Li Zhijian wrote:
>>> It mainly fix monitor not working when log file is specified. For
>>> example
>>> $ cxl monitor -l ./cxl-monitor.log
>>> It seems that someone missed something at the begining.
>>>
>>> Furture, it compares the filename with reserved works more accurately
>>>
>>> Li Zhijian (6):
>>>     cxl/monitor: Fix monitor not working
>>>     cxl/monitor: compare the whole filename with reserved words
>>>     cxl/monitor: Enable default_log and refactor sanity check
>>>     cxl/monitor: always log started message
>>>     Documentation/cxl/cxl-monitor.txt: Fix inaccurate description
>>>     ndctl/monitor: compare the whole filename with reserved words
>>>
>>>    Documentation/cxl/cxl-monitor.txt |  3 +-
>>>    cxl/monitor.c                     | 47 ++++++++++++++++---------------
>>>    ndctl/monitor.c                   |  4 +--
>>>    3 files changed, 27 insertions(+), 27 deletions(-)
>>>
>>
>> Please cc linux-cxl@vger.kernel.org as well for future revs since this impacts CXL CLI.
> Yeah
> 
> I have double confirmed recipient in this repo by 'git grep @', look we have to document it
> in the CONTRIBUTING.md as well :)

Please feel free to submit a patch and rectify this. :)