| Message ID | 20230519125236.352050-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v4,1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries | expand |
On Fri, May 19, 2023 at 09:52:33AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > On the i.MX6SX there is a single entry for 'reg' and 'reg-names', so add > some logic to reflect that. > > Signed-off-by: Fabio Estevam <festevam@denx.de> Whoops, didn't see this patch yesterday.. > --- > Changes since v3: > - None. > > .../bindings/display/bridge/fsl,ldb.yaml | 28 +++++++++++++++++-- > 1 file changed, 25 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml > index 07388bf2b90d..cd63f9ef9484 100644 > --- a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml > @@ -28,12 +28,12 @@ properties: > const: ldb > > reg: > + minItems: 1 > maxItems: 2 > > reg-names: > - items: > - - const: ldb > - - const: lvds > + minItems: 1 > + maxItems: 2 > > ports: > $ref: /schemas/graph.yaml#/properties/ports > @@ -74,6 +74,28 @@ allOf: > properties: > port@2: false > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx6sx-ldb Why not const: for the single item? Trying to avoid churn when you add your next one? > + then: > + properties: > + reg: > + maxItems: 1 > + reg-names: > + items: > + - const: ldb Again, can drop the items: for const: for the single item, no? Thanks, Conor.
diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml index 07388bf2b90d..cd63f9ef9484 100644 --- a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml @@ -28,12 +28,12 @@ properties: const: ldb reg: + minItems: 1 maxItems: 2 reg-names: - items: - - const: ldb - - const: lvds + minItems: 1 + maxItems: 2 ports: $ref: /schemas/graph.yaml#/properties/ports @@ -74,6 +74,28 @@ allOf: properties: port@2: false + - if: + properties: + compatible: + contains: + enum: + - fsl,imx6sx-ldb + then: + properties: + reg: + maxItems: 1 + reg-names: + items: + - const: ldb + else: + properties: + reg: + minItems: 2 + reg-names: + items: + - const: ldb + - const: lvds + additionalProperties: false examples: