| Message ID | 20230520173105.8562-1-ebiggers@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto/Kconfig: warn about performance overhead of CRYPTO_STATS | expand |
On Sat, 20 May 2023 at 19:31, Eric Biggers <ebiggers@kernel.org> wrote: > > From: Eric Biggers <ebiggers@google.com> > > Make the help text for CRYPTO_STATS explicitly mention that it reduces > the performance of the crypto API. > > Signed-off-by: Eric Biggers <ebiggers@google.com> Acked-by: Ard Biesheuvel <ardb@kernel.org> > --- > crypto/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/crypto/Kconfig b/crypto/Kconfig > index 42751d63cd4d9..fdf3742f1106b 100644 > --- a/crypto/Kconfig > +++ b/crypto/Kconfig > @@ -1393,6 +1393,9 @@ config CRYPTO_STATS > help > Enable the gathering of crypto stats. > > + Enabling this option reduces the performance of the crypto API. It > + should only be enabled when there is actually a use case for it. > + > This collects data sizes, numbers of requests, and numbers > of errors processed by: > - AEAD ciphers (encrypt, decrypt) > > base-commit: f573db7aa528f11820dcc811bc7791b231d22b1c > -- > 2.40.1 >
Eric Biggers <ebiggers@kernel.org> wrote: > From: Eric Biggers <ebiggers@google.com> > > Make the help text for CRYPTO_STATS explicitly mention that it reduces > the performance of the crypto API. > > Signed-off-by: Eric Biggers <ebiggers@google.com> > --- > crypto/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) Patch applied. Thanks.
diff --git a/crypto/Kconfig b/crypto/Kconfig index 42751d63cd4d9..fdf3742f1106b 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -1393,6 +1393,9 @@ config CRYPTO_STATS help Enable the gathering of crypto stats. + Enabling this option reduces the performance of the crypto API. It + should only be enabled when there is actually a use case for it. + This collects data sizes, numbers of requests, and numbers of errors processed by: - AEAD ciphers (encrypt, decrypt)