[wireless-next,v1,4/4] wifi: rtw88: Add support for the SDIO based RTL8723DS chipset

Commit Message

Martin Blumenstingl May 18, 2023, 4:17 p.m. UTC

Wire up RTL8723DS chipset support using the rtw88 SDIO HCI code as well
as the existing RTL8723D chipset code.

Signed-off-by: Martin Blumenstingl <[e-mail]>
---
 drivers/net/wireless/realtek/rtw88/Kconfig    | 11 +++++
 drivers/net/wireless/realtek/rtw88/Makefile   |  3 ++
 .../net/wireless/realtek/rtw88/rtw8723ds.c    | 41 +++++++++++++++++++
 3 files changed, 55 insertions(+)
 create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8723ds.c

Comments

Ping-Ke Shih May 22, 2023, 1:49 a.m. UTC | #1

> -----Original Message-----
> From: Martin Blumenstingl <[e-mail]>
> Sent: Friday, May 19, 2023 12:18 AM
> To: [e-mail]
> Cc: [e-mail]; [e-mail]; [e-mail]; [e-mail];
> [e-mail]; Peter Robinson <[e-mail]>; Ping-Ke Shih <[e-mail]>;
> [e-mail]; Martin Blumenstingl <[e-mail]>
> Subject: [PATCH wireless-next v1 4/4] wifi: rtw88: Add support for the SDIO based RTL8723DS chipset
> 
> Wire up RTL8723DS chipset support using the rtw88 SDIO HCI code as well
> as the existing RTL8723D chipset code.
> 
> Signed-off-by: Martin Blumenstingl <[e-mail]>

I'm so surprised that this small patchset can support an new chip. Nice job. :-)

Reviewed-by: Ping-Ke Shih <[e-mail]>

[...]

Larry Finger May 22, 2023, 1:58 a.m. UTC | #2

On 5/21/23 20:49, Ping-Ke Shih wrote:
> 
> 
>> -----Original Message-----
>> From: Martin Blumenstingl <[e-mail]>
>> Sent: Friday, May 19, 2023 12:18 AM
>> To: [e-mail]
>> Cc: [e-mail]; [e-mail]; [e-mail]; [e-mail];
>> [e-mail]; Peter Robinson <[e-mail]>; Ping-Ke Shih <[e-mail]>;
>> [e-mail]; Martin Blumenstingl <[e-mail]>
>> Subject: [PATCH wireless-next v1 4/4] wifi: rtw88: Add support for the SDIO based RTL8723DS chipset
>>
>> Wire up RTL8723DS chipset support using the rtw88 SDIO HCI code as well
>> as the existing RTL8723D chipset code.
>>
>> Signed-off-by: Martin Blumenstingl <[e-mail]>
> 
> I'm so surprised that this small patchset can support an new chip. Nice job. :-)
> 
> Reviewed-by: Ping-Ke Shih <[e-mail]>

I agree that this is a nice job. This driver has been tested using my rtw88 repo 
at GitHub.com. I do not have a device, thus a tested=by tag would not be 
appropriate, but I do have a very satisfied user!

Larry

Martin Blumenstingl May 22, 2023, 8:13 p.m. UTC | #3

On Mon, May 22, 2023 at 3:49 AM Ping-Ke Shih <[e-mail]> wrote:
>
>
>
> > -----Original Message-----
> > From: Martin Blumenstingl <[e-mail]>
> > Sent: Friday, May 19, 2023 12:18 AM
> > To: [e-mail]
> > Cc: [e-mail]; [e-mail]; [e-mail]; [e-mail];
> > [e-mail]; Peter Robinson <[e-mail]>; Ping-Ke Shih <[e-mail]>;
> > [e-mail]; Martin Blumenstingl <[e-mail]>
> > Subject: [PATCH wireless-next v1 4/4] wifi: rtw88: Add support for the SDIO based RTL8723DS chipset
> >
> > Wire up RTL8723DS chipset support using the rtw88 SDIO HCI code as well
> > as the existing RTL8723D chipset code.
> >
> > Signed-off-by: Martin Blumenstingl <[e-mail]>
>
> I'm so surprised that this small patchset can support an new chip. Nice job. :-)
Please also take it as feedback/learning for yourself and to your team
at Realtek:
In my opinion the rtw88 driver is a good piece of software and it
shows why it is the first choice that Jernej and I had in mind when
thinking about future RTL8723BS support.

> Reviewed-by: Ping-Ke Shih <[e-mail]>
Thank you!


Best regards,
Martin

Patch

diff --git a/drivers/net/wireless/realtek/rtw88/Kconfig b/drivers/net/wireless/realtek/rtw88/Kconfig
index 29eb2f8e0eb7..cffad1c01249 100644
--- a/drivers/net/wireless/realtek/rtw88/Kconfig
+++ b/drivers/net/wireless/realtek/rtw88/Kconfig
@@ -111,6 +111,17 @@  config RTW88_8723DE
 
 	  802.11n PCIe wireless network adapter
 
+config RTW88_8723DS
+	tristate "Realtek 8723DS SDIO wireless network adapter"
+	depends on MMC
+	select RTW88_CORE
+	select RTW88_SDIO
+	select RTW88_8723D
+	help
+	  Select this option will enable support for 8723DS chipset
+
+	  802.11n SDIO wireless network adapter
+
 config RTW88_8723DU
 	tristate "Realtek 8723DU USB wireless network adapter"
 	depends on USB
diff --git a/drivers/net/wireless/realtek/rtw88/Makefile b/drivers/net/wireless/realtek/rtw88/Makefile
index 82979b30ae8d..fd212c09d88a 100644
--- a/drivers/net/wireless/realtek/rtw88/Makefile
+++ b/drivers/net/wireless/realtek/rtw88/Makefile
@@ -50,6 +50,9 @@  rtw88_8723d-objs		:= rtw8723d.o rtw8723d_table.o
 obj-$(CONFIG_RTW88_8723DE)	+= rtw88_8723de.o
 rtw88_8723de-objs		:= rtw8723de.o
 
+obj-$(CONFIG_RTW88_8723DS)	+= rtw88_8723ds.o
+rtw88_8723ds-objs		:= rtw8723ds.o
+
 obj-$(CONFIG_RTW88_8723DU)	+= rtw88_8723du.o
 rtw88_8723du-objs		:= rtw8723du.o
 
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723ds.c b/drivers/net/wireless/realtek/rtw88/rtw8723ds.c
new file mode 100644
index 000000000000..e5b6960ba0a0
--- /dev/null
+++ b/drivers/net/wireless/realtek/rtw88/rtw8723ds.c
@@ -0,0 +1,41 @@ 
+// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
+/* Copyright(c) Martin Blumenstingl <[e-mail]>
+ */
+
+#include <linux/mmc/sdio_func.h>
+#include <linux/mmc/sdio_ids.h>
+#include <linux/module.h>
+#include "main.h"
+#include "rtw8723d.h"
+#include "sdio.h"
+
+static const struct sdio_device_id rtw_8723ds_id_table[] =  {
+	{
+		SDIO_DEVICE(SDIO_VENDOR_ID_REALTEK,
+			    SDIO_DEVICE_ID_REALTEK_RTW8723DS_1ANT),
+		.driver_data = (kernel_ulong_t)&rtw8723d_hw_spec,
+	},
+	{
+		SDIO_DEVICE(SDIO_VENDOR_ID_REALTEK,
+			    SDIO_DEVICE_ID_REALTEK_RTW8723DS_2ANT),
+		.driver_data = (kernel_ulong_t)&rtw8723d_hw_spec,
+	},
+	{}
+};
+MODULE_DEVICE_TABLE(sdio, rtw_8723ds_id_table);
+
+static struct sdio_driver rtw_8723ds_driver = {
+	.name = "rtw_8723ds",
+	.probe = rtw_sdio_probe,
+	.remove = rtw_sdio_remove,
+	.id_table = rtw_8723ds_id_table,
+	.drv = {
+		.pm = &rtw_sdio_pm_ops,
+		.shutdown = rtw_sdio_shutdown,
+	}
+};
+module_sdio_driver(rtw_8723ds_driver);
+
+MODULE_AUTHOR("Martin Blumenstingl <[e-mail]>");
+MODULE_DESCRIPTION("Realtek 802.11n wireless 8723ds driver");
+MODULE_LICENSE("Dual BSD/GPL");