diff mbox series

[net-next,v3,1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0

Message ID 1684531184-14009-2-git-send-email-justin.chen@broadcom.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series Brcm ASP 2.0 Ethernet Controller | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next, async
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/cc_maintainers warning 2 maintainers not CCed: rafal@milecki.pl conor+dt@kernel.org
netdev/build_clang success Errors and warnings before: 8 this patch: 8
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Justin Chen May 19, 2023, 9:19 p.m. UTC 
The ASP 2.0 Ethernet controller uses a brcm unimac.

Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Justin Chen <justin.chen@broadcom.com>
---
 Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Conor Dooley May 22, 2023, 6:17 p.m. UTC | #1 
On Fri, May 19, 2023 at 02:19:39PM -0700, Justin Chen wrote:
 > The ASP 2.0 Ethernet controller uses a brcm unimac.
 >
 > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
 > Signed-off-by: Justin Chen <justin.chen@broadcom.com>
 > ---
 >  Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++
 >  1 file changed, 2 insertions(+)
 >
 > diff --git 
a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml 
b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
 > index 0be426ee1e44..6684810fcbf0 100644
 > --- a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
 > +++ b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
 > @@ -22,6 +22,8 @@ properties:
 >        - brcm,genet-mdio-v3
 >        - brcm,genet-mdio-v4
 >        - brcm,genet-mdio-v5
 > +      - brcm,asp-v2.0-mdio
 > +      - brcm,asp-v2.1-mdio
 >        - brcm,unimac-mdio


 From V(N-1), there was some discussion between Rob & Florian:
 > > How many SoCs does each of these correspond to? SoC specific 
compatibles
 > > are preferred to version numbers (because few vendors are disciplined
 > > at versioning and also not changing versions with every Soc).
 >
 > So far there is a 1:1 mapping between the number of versions and the
 > number of SoCs, and the older SoC uses v2.0, while the newer one uses 
v2.1.

Rob's not around right now, but I don't really get why if there is a 1:1
mapping you don't just name these things after the SoCs?

Also, my mailer **refused** to let me reply to you because of something
to do with a garbage S/MIME signature? Dunno wtf is happening there.

Cheers,
Conor.
Florian Fainelli May 22, 2023, 6:25 p.m. UTC | #2 
On 5/22/23 11:17, Conor Dooley wrote:
> On Fri, May 19, 2023 at 02:19:39PM -0700, Justin Chen wrote:
>  > The ASP 2.0 Ethernet controller uses a brcm unimac.
>  >
>  > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
>  > Signed-off-by: Justin Chen <justin.chen@broadcom.com>
>  > ---
>  >  Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++
>  >  1 file changed, 2 insertions(+)
>  >
>  > diff --git 
> a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml 
> b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
>  > index 0be426ee1e44..6684810fcbf0 100644
>  > --- a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
>  > +++ b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
>  > @@ -22,6 +22,8 @@ properties:
>  >        - brcm,genet-mdio-v3
>  >        - brcm,genet-mdio-v4
>  >        - brcm,genet-mdio-v5
>  > +      - brcm,asp-v2.0-mdio
>  > +      - brcm,asp-v2.1-mdio
>  >        - brcm,unimac-mdio
> 
> 
>  From V(N-1), there was some discussion between Rob & Florian:
>  > > How many SoCs does each of these correspond to? SoC specific 
> compatibles
>  > > are preferred to version numbers (because few vendors are disciplined
>  > > at versioning and also not changing versions with every Soc).
>  >
>  > So far there is a 1:1 mapping between the number of versions and the
>  > number of SoCs, and the older SoC uses v2.0, while the newer one uses 
> v2.1.
> 
> Rob's not around right now, but I don't really get why if there is a 1:1
> mapping you don't just name these things after the SoCs?

There is a 1:1 mapping now, but in the future there may be more SoCs 
with a given implemented version. This is especially true for the MDIO 
controller which has been largely unchanged since it was introduced.

> 
> Also, my mailer **refused** to let me reply to you because of something
> to do with a garbage S/MIME signature? Dunno wtf is happening there.

Our SMTP server is configured to automatically wrap the message in a 
S/MIME envelope, nothing invalid though AFAICT. What's your email client?
Conor Dooley May 22, 2023, 6:38 p.m. UTC | #3 
On Mon, May 22, 2023 at 11:25:54AM -0700, Florian Fainelli wrote:
> On 5/22/23 11:17, Conor Dooley wrote:
> > On Fri, May 19, 2023 at 02:19:39PM -0700, Justin Chen wrote:
> >  > The ASP 2.0 Ethernet controller uses a brcm unimac.
> >  >
> >  > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> >  > Signed-off-by: Justin Chen <justin.chen@broadcom.com>
> >  > ---
> >  >  Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++
> >  >  1 file changed, 2 insertions(+)
> >  >
> >  > diff --git
> > a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
> > b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
> >  > index 0be426ee1e44..6684810fcbf0 100644
> >  > --- a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
> >  > +++ b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
> >  > @@ -22,6 +22,8 @@ properties:
> >  >        - brcm,genet-mdio-v3
> >  >        - brcm,genet-mdio-v4
> >  >        - brcm,genet-mdio-v5
> >  > +      - brcm,asp-v2.0-mdio
> >  > +      - brcm,asp-v2.1-mdio
> >  >        - brcm,unimac-mdio
> > 
> > 
> >  From V(N-1), there was some discussion between Rob & Florian:
> >  > > How many SoCs does each of these correspond to? SoC specific
> > compatibles
> >  > > are preferred to version numbers (because few vendors are disciplined
> >  > > at versioning and also not changing versions with every Soc).
> >  >
> >  > So far there is a 1:1 mapping between the number of versions and the
> >  > number of SoCs, and the older SoC uses v2.0, while the newer one uses
> > v2.1.
> > 
> > Rob's not around right now, but I don't really get why if there is a 1:1
> > mapping you don't just name these things after the SoCs?
> 
> There is a 1:1 mapping now, but in the future there may be more SoCs with a
> given implemented version. This is especially true for the MDIO controller
> which has been largely unchanged since it was introduced.

Figured that'd be it, but what was written in the previous thread made
the opposite appear true!
Acked-by: Conor Dooley <conor.dooley@microchip.com>

> > Also, my mailer **refused** to let me reply to you because of something
> > to do with a garbage S/MIME signature? Dunno wtf is happening there.
> 
> Our SMTP server is configured to automatically wrap the message in a S/MIME
> envelope, nothing invalid though AFAICT. What's your email client?

Mutt - I guess it was user-error because getting S/MIME stuff
auto-populated the security field on my end. Annoying but w/e...
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
index 0be426ee1e44..6684810fcbf0 100644
--- a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
+++ b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
@@ -22,6 +22,8 @@  properties:
       - brcm,genet-mdio-v3
       - brcm,genet-mdio-v4
       - brcm,genet-mdio-v5
+      - brcm,asp-v2.0-mdio
+      - brcm,asp-v2.1-mdio
       - brcm,unimac-mdio
 
   reg: